Created

Embed URL

HTTPS clone URL

SSH clone URL

You can clone with HTTPS or SSH.

Download Gist

T5 Extend Email Checks

View t5-extend-email-checks.php
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22
<?php # -*- coding: utf-8 -*-
/*
Plugin Name: T5 Extend Email Checks
Description: Overrides the results of the functions <code>is_email()</code> and <code>sanitize_email()</code>. Allows for example <code>me@localhost</code> or punycode encoded email adresses by using PHP’s internal filter function.
Version: 2012.08.29
Plugin URI: http://toscho.de/?p=2195
Author: Thomas Scholz
Author URI: http://toscho.de
License: MIT
*/
! defined( 'ABSPATH' ) and exit;
if ( ! function_exists( 't5_extend_email_checks' ) )
{
add_filter( 'is_email', 'extend_email_checks', 10, 2 );
add_filter( 'sanitize_email', 'extend_email_checks', 10, 2 );
function t5_extend_email_checks( $result, $email )
{
return filter_var( $email, FILTER_VALIDATE_EMAIL );
}
}
hakre commented

Is there a reason you don't return the filtered $email if the filter_var did not false?

Owner
toscho commented

Uhm … but I do exactly this!?

hakre commented

filtered in the meaning of filter_var(), e.g.: return filter_var( $email, FILTER_VALIDATE_EMAIL ); -- filter_var will either return FALSE or the filtered value of $email. In your gist you return $email unfiltered.

Owner
toscho commented

Oh, I see. :) Changed.

Ive tested this and it still errors on an apostrophe.. is it working for you ?

Owner

Do you mean an apostrophe in a mail address or a parse error?

no, no parse error, but the address is still rejected.

does the PHP filter not allow apostrophes ?

Owner

The filter allows apostrophes, at least the fake apostrophe '. Hm, the WordPress functions should allow it too. I’m not sure what happens here.

They, dont, its a logged issue in WP Trac. Im trying to find the easiest workaround...

Are we going to get this change pushed into a future release ?

https://wordpress.org/support/topic/writing-a-plugin-to-amend-the-core-possible?replies=9#post-2769861

It would be handy to support email address's properly...

Owner

There is an open ticket: http://core.trac.wordpress.org/ticket/17433

Go, vote for it, add Unit tests. Then it may become part of the core.

Owner

Ask on Trac. I have no influence to core development.

The callback functions need the t5_ prefix - have forked a working example.

Note that apostrophes are escaped by WordPress, so they are still invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.