- We found a Node.js bug. When
Object.definePropertywas monkeypatched, in certain situations other things would break. For example, usingconsole.logafter the monkeypatch but not before (ifconsole.logalso appeared before the monkeypatch, it would work).- which was triggered by that kind of monkeypatch mistakenly being attached due to a syntax error in the Ruby uglifier gem’s
es5.jsshim (v2.7.1 - fixed by https://github.com/lautis/uglifier/commit/31a53a92da537af3776711471d6e9582d96dc49d, released in uglifier v3.0.0) - which was used as the js compressor for our static jekyll blog - luckily a direct dependency, and upgrading had no dependency conflicts - easy fix.
- which was triggered by that kind of monkeypatch mistakenly being attached due to a syntax error in the Ruby uglifier gem’s
- Introduced in Node 11.12.0 by: https://github.com/nodejs/node/commit/c14aa07b94d684de8e2a23a54d0e6a3c25a2e460
- Fixed in Node 12.0.0 by: https://github.com/nodejs/node/commit/908292cf1f551c614a733d858528ffb13fb3a524
- [I was running Node 11.14.0.]
Last active
June 30, 2019 15:30
-
-
Save trptcolin/6039cd454acfe6e820d13cbdce5e4064 to your computer and use it in GitHub Desktop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment