Skip to content

Instantly share code, notes, and snippets.

@vn971
Created September 12, 2019 16:01
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save vn971/7bcbc5fc6ebf731abc8399988dfb4fef to your computer and use it in GitHub Desktop.
Save vn971/7bcbc5fc6ebf731abc8399988dfb4fef to your computer and use it in GitHub Desktop.
rua shellcheck xcalib/PKGBUILD
$ rua shellcheck xcalib/PKGBUILD
In xcalib/PKGBUILD line 15:
source=(${pkgname}::"git://github.com/OpenICC/xcalib.git")
^--------^ SC2206: Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
In xcalib/PKGBUILD line 27:
install -m644 *.icc *.icm "${pkgdir}/usr/share/xcalib/"
^-- SC2035: Use ./*glob* or -- *glob* so names with dashes won't become options.
^-- SC2035: Use ./*glob* or -- *glob* so names with dashes won't become options.
In xcalib/PKGBUILD line 28:
install -m644 *.1 "${pkgdir}/usr/share/man/man1/"
^-- SC2035: Use ./*glob* or -- *glob* so names with dashes won't become options.
For more information:
https://www.shellcheck.net/wiki/SC2206 -- Quote to prevent word splitting/g...
https://www.shellcheck.net/wiki/SC2035 -- Use ./*glob* or -- *glob* so name...
1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment