Skip to content

Instantly share code, notes, and snippets.

@vn971
Created September 12, 2019 16:02
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save vn971/edb08becb9ed7dd558b4c8655b57adec to your computer and use it in GitHub Desktop.
Save vn971/edb08becb9ed7dd558b4c8655b57adec to your computer and use it in GitHub Desktop.
shellcheck xcalib/PKGBUILD
$ shellcheck xcalib/PKGBUILD
In xcalib/PKGBUILD line 1:
# Maintainer: gato_lento
^-- SC2148: Tips depend on target shell and yours is unknown. Add a shebang.
In xcalib/PKGBUILD line 7:
pkgver=0.10
^----^ SC2034: pkgver appears unused. Verify use (or export if used externally).
In xcalib/PKGBUILD line 8:
pkgrel=1
^----^ SC2034: pkgrel appears unused. Verify use (or export if used externally).
In xcalib/PKGBUILD line 9:
pkgdesc="A tiny monitor calibration loader for X.org"
^-----^ SC2034: pkgdesc appears unused. Verify use (or export if used externally).
In xcalib/PKGBUILD line 10:
arch=('i686' 'x86_64')
^--^ SC2034: arch appears unused. Verify use (or export if used externally).
In xcalib/PKGBUILD line 11:
url="https://github.com/OpenICC/xcalib"
^-^ SC2034: url appears unused. Verify use (or export if used externally).
In xcalib/PKGBUILD line 12:
license=('GPL2')
^-----^ SC2034: license appears unused. Verify use (or export if used externally).
In xcalib/PKGBUILD line 13:
depends=('libxxf86vm' 'libxrandr')
^-----^ SC2034: depends appears unused. Verify use (or export if used externally).
In xcalib/PKGBUILD line 14:
makedepends=('git')
^---------^ SC2034: makedepends appears unused. Verify use (or export if used externally).
In xcalib/PKGBUILD line 15:
source=(${pkgname}::"git://github.com/OpenICC/xcalib.git")
^----^ SC2034: source appears unused. Verify use (or export if used externally).
^--------^ SC2206: Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
In xcalib/PKGBUILD line 16:
sha256sums=('SKIP')
^--------^ SC2034: sha256sums appears unused. Verify use (or export if used externally).
In xcalib/PKGBUILD line 19:
cd ${pkgname}
^-----------^ SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
Did you mean:
cd ${pkgname} || exit
In xcalib/PKGBUILD line 24:
cd ${pkgname}
^-----------^ SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
Did you mean:
cd ${pkgname} || exit
In xcalib/PKGBUILD line 25:
install -d ${pkgdir}/usr/{share/xcalib,share/man/man1,bin}
^-------^ SC2154: pkgdir is referenced but not assigned.
^-------^ SC2086: Double quote to prevent globbing and word splitting.
Did you mean:
install -d "${pkgdir}"/usr/{share/xcalib,share/man/man1,bin}
In xcalib/PKGBUILD line 27:
install -m644 *.icc *.icm "${pkgdir}/usr/share/xcalib/"
^-- SC2035: Use ./*glob* or -- *glob* so names with dashes won't become options.
^-- SC2035: Use ./*glob* or -- *glob* so names with dashes won't become options.
In xcalib/PKGBUILD line 28:
install -m644 *.1 "${pkgdir}/usr/share/man/man1/"
^-- SC2035: Use ./*glob* or -- *glob* so names with dashes won't become options.
For more information:
https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y...
https://www.shellcheck.net/wiki/SC2034 -- arch appears unused. Verify use (...
https://www.shellcheck.net/wiki/SC2154 -- pkgdir is referenced but not assi...
1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment