Skip to content

Instantly share code, notes, and snippets.

@vrongmeal

vrongmeal/gsoc19_final_eval.md

Last active August 26, 2019 12:47
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save vrongmeal/f5cd3bbfa75f1abd5bfb870e3190f029 to your computer and use it in GitHub Desktop.
Save vrongmeal/f5cd3bbfa75f1abd5bfb870e3190f029 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
gsoc19_final_eval.md

Google Summer of Code 2019 : The Zulip Open Source Project

In this document I have listed all the Pull Requests that I have worked on during the summer. The link to all my Pull Requests and the commits merged is also added at the end of the document.

My summer with Zulip was spent majorly on introducing SCSS nesting and other SCSS features in current stylesheets. Here's the issue to keep track of this particular project: #12528 (css: Use SCSS nesting in stylesheets.)

All the relevant PRs are listed below (closed and merged):

  • #13064: css: Use SCSS nesting for compose.scss. (1)
  • #13063: css: Use SCSS nesting for #compose-buttons in compose.scss.
  • #13033: css: Use SCSS nesting in informational-overlays.scss.
  • #13014: css: Use SCSS nesting in drafts.scss.
  • #12935: css: Use SCSS nesting in widgets.scss.
  • #12927: css: Use SCSS nesting in subscriptions.scss for media queries.
  • #12887: css: Use SCSS nesting for ul.grey-box in subscriptions.scss.
  • #12848: css: Use SCSS nesting for #subscription_overlay and *creation*.
  • #12817: css: Use SCSS nesting for .subscriptions-container.
  • #12763: css: Use SCSS nesting for subscribers' list in subscriptions.scss.
  • #12722: css: Use SCSS nesting in subscriptions.scss for .stream-row.
  • #12713: css: Use SCSS nesting in popovers.scss.
  • #12680: css: Use SCSS nesting in input_pill.scss.
  • #12546: css: Use SCSS nesting in lightbox.scss.
  • #12510: css: Use SCSS nesting in alerts.scss.
  • #12497: css: Use SCSS nesting in hotspots.scss.
  • #12494: css: Add similar nesting to night-mode emoji elements as in reactions.scss.
  • #12473: css: Use SCSS nesting in reactions.scss. (2)
  • #12416: css: Use SCSS nesting in app_components.scss.
  • #12392: Use SCSS nesting in components.scss.
  • #12351: css: Use SCSS nesting in reactions.scss.

I worked on various other PRs, some of which are listed below:

  • #12892: reactions_button: Remove title from reaction button in controls. Closed
  • #12594: message_view: Add unread divider in message list. Open
  • #12560: css: Move stylesheets not included in the app to another directory. Closed
  • #12456: markdown: Add .rendered_markdown to elements in with MD content. Closed
  • #12372: user_info: Add bot owner to the user info popover. Closed
  • #11596: messagebox: Refactor message_body to introduce three column structure. Open

A complete list of my pull-requests can be found here: https://github.com/zulip/zulip/pulls?q=is%3Apr+author%3Avrongmeal

During my GSoC period, I got more than 150 commits merged into the master. A complete list of all the commits that got merged can be found here: https://github.com/zulip/zulip/commits?author=vrongmeal

Working with Zulip has been a great learning experience. I look forward to contributing to Zulip post my GSoC completing all the stylesheets mentioned in the aforementioned issue, completing other pending Pull Requests and issues that I started working on during the GSoC period and also taking up new issues and projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment