Julien xoco70

## code-review-checklist.md

      
              1 file
            
          
              0 forks
            
          
              0 comments
            
          
              0 stars
            
          
                xoco70
                / code-review-checklist.md
            
            
              Last active
              June 21, 2022 14:56
                — forked from nerandell/code-review-checklist.md
            
              
                PHP Code Review Guidelines
              
          
    Make sure these boxes are checked before submitting/approving the PR
General


 The code works
 The code is easy to understand
 Follows coding conventions
 Names are simple and if possible short
 Names are spelt correctly
 Names contain units where applicable
 There are no usages of magic numbers


## gist:8a9c7042238400e370796cb23cb11c88
➜  ~ minikube logs
==> Docker <==
-- Logs begin at Wed 2019-06-19 15:34:35 CEST, end at Thu 2019-10-24 17:36:01 CEST. --
oct. 24 15:12:01 ubuntu dockerd[1374]: time="2019-10-24T15:12:01.167614453+02:00" level=warning msg="failed to prune image docker.io/library/docker@sha256:5d11c2a1300b7438e21cbb5b2bd704e663b70534abe90c9072081dfb18e144de: No such image: docker@sha256:5d11c2a1300b7438e21cbb5b2bd704e663b70534abe90c9072081dfb18e144de"
oct. 24 15:12:03 ubuntu dockerd[1374]: time="2019-10-24T15:12:03.811309007+02:00" level=warning msg="failed to prune image registry.gitlab.com/sunchain/enedis_api@sha256:9d874e03c8ff40cb72518b946d892589b9fc04ac4c220e39fe6d2687bcadce46: No such image: registry.gitlab.com/sunchain/enedis_api@sha256:9d874e03c8ff40cb72518b946d892589b9fc04ac4c220e39fe6d2687bcadce46"
oct. 24 15:12:05 ubuntu dockerd[1374]: time="2019-10-24T15:12:05.708851998+02:00" level=warning msg="failed to prune image k8s.gcr.io/etcd@sha256:17da501f5d2a675be46040422a27b7cc21b8a43895ac998b171db1c346f361f7: No such ima
	➜ ~ minikube logs
	==> Docker <==
	-- Logs begin at Wed 2019-06-19 15:34:35 CEST, end at Thu 2019-10-24 17:36:01 CEST. --
	oct. 24 15:12:01 ubuntu dockerd[1374]: time="2019-10-24T15:12:01.167614453+02:00" level=warning msg="failed to prune image docker.io/library/docker@sha256:5d11c2a1300b7438e21cbb5b2bd704e663b70534abe90c9072081dfb18e144de: No such image: docker@sha256:5d11c2a1300b7438e21cbb5b2bd704e663b70534abe90c9072081dfb18e144de"
	oct. 24 15:12:03 ubuntu dockerd[1374]: time="2019-10-24T15:12:03.811309007+02:00" level=warning msg="failed to prune image registry.gitlab.com/sunchain/enedis_api@sha256:9d874e03c8ff40cb72518b946d892589b9fc04ac4c220e39fe6d2687bcadce46: No such image: registry.gitlab.com/sunchain/enedis_api@sha256:9d874e03c8ff40cb72518b946d892589b9fc04ac4c220e39fe6d2687bcadce46"
	oct. 24 15:12:05 ubuntu dockerd[1374]: time="2019-10-24T15:12:05.708851998+02:00" level=warning msg="failed to prune image k8s.gcr.io/etcd@sha256:17da501f5d2a675be46040422a27b7cc21b8a43895ac998b171db1c346f361f7: No such ima