Skip to content

Instantly share code, notes, and snippets.

@yaboi
Last active January 12, 2016 20:37
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save yaboi/43f12540c07974dbfce8 to your computer and use it in GitHub Desktop.
Save yaboi/43f12540c07974dbfce8 to your computer and use it in GitHub Desktop.
merge into 'dev' from 'inline-share'

Fixes #372

What's this PR do?

Optimizes the sharing functionality on the campaign page. Removes Semantic sidebar UI and instead replaces with an inline Semantic segment UI that flows better with campaign page and is more reproducible in other places.

Where should the reviewer start?

New file client/scripts/share/share-semantic.html which is included in client/scripts/giftstart/giftstart.html.

How should this be manually tested?

  1. Click link in description section that reads "Get it to 100% by sharing this campaign"
  2. Hover question mark indicator next to "Write a message" and view tips.
  3. Write a message, click each social share icon.
  4. Click "Need help? Use a suggested messages."
  5. Select one or more "suggested message" and notice update to "Write a message" input along with indication of selected message.
  6. Click each social share icon.
  7. Manually update "suggested message", notice indication of selected message.
  8. Click "Share Email", notice error message. Clear "Write a message", click "Share Email", notice error message. Write/select message, enter email, click "Share Email", notice error message (doesn't work on local, needs to be tested on dev)
  9. Click "Copy Url", notice success popup. Open Safari, follow steps 1 above, click "Copy Url", notice degradation in Safari. (read more here and here)
  10. Click "Go Back" (outside of segment) to return to campaign details.

Note: This should all work exactly the same while "sharing" after a contribution. (doesn't work on local, needs to be tested on dev)

Any background context you want to provide?

There was a ton of logic removed from client/scripts/share/share.controller.js that isn't being used anymore with the new update. It was used to do a lot of internal API type sharing which is now being handled more simply by socialshare (see below under, "Does this add new dependencies").

What are the relevant tickets?

#372

Screenshots (if appropriate)

Before screen shot 2016-01-12 at 2 13 52 pm After screen shot 2016-01-12 at 2 15 41 pm screen shot 2016-01-12 at 2 16 22 pm screen shot 2016-01-12 at 2 16 43 pm

Questions:

  • Is there a blog post? Yes.
  • Does the knowledge base or Wiki need an update? Maybe.
  • Does this add new dependencies? Which ones? Yes - socialshare and clipboard (internal dependency, but based on ngclipboard). Make sure to run $ bower install angular-socialshare
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment