Skip to content

Instantly share code, notes, and snippets.

@yuriy77k
Forked from gorbunovperm/ETH_LuckyStrikeV4_report.md
Created May 29, 2019 14:23
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save yuriy77k/062ccb91ccb0e1ac317969407e40d1c2 to your computer and use it in GitHub Desktop.
Save yuriy77k/062ccb91ccb0e1ac317969407e40d1c2 to your computer and use it in GitHub Desktop.
Lucky Strike v4 security audit report

Lucky Strike v4 security audit report

Summary

This is the report from a security audit performed on Lucky Strike v4 by gorbunovperm.

Lucky Strike, based fully in Ethereum smart-contract, is bringing the core philosophy of blockchain to the gambling industry – enhancing it with an ICO model we’re calling ‘Bet & Own.’

https://lucky-strike.io/game/#/

In scope

  1. LuckyStrike
  2. LuckyStrikeTokens

Findings

In total, 3 issues were reported including:

  • 0 high severity issue.

  • 0 medium severity issues.

  • 1 low severity issues.

  • 1 owner privileges.

  • 1 minor observations.

Security issues

1. Known vulnerabilities of ERC-20 token

Severity: low

Description

  • It is possible to double withdrawal attack. More details here

  • Lack of transaction handling mechanism issue. WARNING! This is a very common issue and it already caused millions of dollars losses for lots of token users! More details here

2. Possibility of minting more than hardCap

Severity: minor observation

Code snippet

Description

Function mint allows owner to mint more tokens than hardCap.

Recommendation

You should check (invested + _invested) > hardCap before minting and if it's true, mint only hardCap - invested number of tokens and return remainder to investor.

3. Owner Privileges

Severity: owner privileges

Code snippet

Description

adjustAllocation function allows the owner to reset the rates of the different jackpots and income rate.

Conclusion

There are no serious vulnerabilities that should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment