Skip to content

Instantly share code, notes, and snippets.

@yuriy77k
Forked from pro100skm/BitUnits.md
Created October 19, 2018 19:45
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save yuriy77k/598a97f409c1a890b26571e416ebff7f to your computer and use it in GitHub Desktop.
Save yuriy77k/598a97f409c1a890b26571e416ebff7f to your computer and use it in GitHub Desktop.

BitUnits audit report

Summary

This is the report from a security audit performed on BitUnits by pro100skm.

The audit focused primarily on the security of BitUnits smart contract.

In scope

  1. https://gist.github.com/yuriy77k/d0d28a553000ddc1a64f63b0fb4d4b05

Findings

In total, 2 issues were reported including:

  • 0 high severity issues.

  • 0 medium severity issues.

  • 1 low severity issues.

  • 1 minor observations.

Security issues

https://gist.github.com/yuriy77k/d0d28a553000ddc1a64f63b0fb4d4b05#file-bitunits-sol-L208

1. Logical mistake

Severity: low

Description

Accidentally transfered to zero address tokens may be sold.

2. Token calculating

Severity: minor

Description

50000 TKN should cost 1 ETC as it written here.
Actually calculated as ETC divided by priceDiv, where priceDiv equals 10000000.
That means 100.000.000.000 TKN will cost 1 ETC.

Conclusion

There weren't detected any high severity vulnerabilities that can directly hurt the BitUnits smart contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment