Skip to content

Instantly share code, notes, and snippets.

@zev
Created June 18, 2014 02:59
Show Gist options
  • Save zev/68cba11aa3f81bbb6875 to your computer and use it in GitHub Desktop.
Save zev/68cba11aa3f81bbb6875 to your computer and use it in GitHub Desktop.
RecordNotFound missing descriptive message from various ActiveRecord versions
# Activate the gem you are reporting the issue against.
gem 'activerecord', '3.2.18'
require 'active_record'
require 'minitest/autorun'
require 'logger'
# Ensure backward compatibility with Minitest 4
Minitest::Test = MiniTest::Unit::TestCase unless defined?(Minitest::Test)
# This connection will do for database-independent bug reports.
ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')
ActiveRecord::Base.logger = Logger.new(STDOUT)
ActiveRecord::Schema.define do
create_table :posts do |t|
end
end
class Post < ActiveRecord::Base
has_many :comments
end
class BugTest < Minitest::Test
def test_record_not_found_message
assert_equal 0, Post.count
find_message = nil
begin
Post.find(99999)
rescue ActiveRecord::RecordNotFound => err
find_message = err.message
end
assert_equal "Couldn't find Post with id=99999", find_message
class_message = nil
begin
Post.find_by_id!(99999)
rescue ActiveRecord::RecordNotFound => err
class_message = err.message
end
assert_equal "Couldn't find Post with id = 99999", class_message
# Using the where form loses information about which Model can't be found
no_class_message = nil
begin
Post.where(id: 99999).first!
rescue ActiveRecord::RecordNotFound => err
no_class_message = err.message
end
assert_equal "Couldn't find Post with [WHERE \"posts\".\"id\" = 99999]", no_class_message
end
end
# Activate the gem you are reporting the issue against.
gem 'activerecord', '4.0.5'
require 'active_record'
require 'minitest/autorun'
require 'logger'
# Ensure backward compatibility with Minitest 4
Minitest::Test = MiniTest::Unit::TestCase unless defined?(Minitest::Test)
# This connection will do for database-independent bug reports.
ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')
ActiveRecord::Base.logger = Logger.new(STDOUT)
ActiveRecord::Schema.define do
create_table :posts do |t|
end
end
class Post < ActiveRecord::Base
end
class BugTest < Minitest::Test
def test_record_not_found_message
assert_equal 0, Post.count
find_message = nil
begin
Post.find(99999)
rescue ActiveRecord::RecordNotFound => err
find_message = err.message
end
assert_equal "Couldn't find Post with id=99999", find_message
no_class_message = nil
begin
Post.find_by!(id: 99999)
rescue ActiveRecord::RecordNotFound => err
no_class_message = err.message
end
assert_equal "Couldn't find Post with [WHERE \"posts\".\"id\" = 99999]", no_class_message
end
end
# Activate the gem you are reporting the issue against.
gem 'activerecord', '4.1.1'
require 'active_record'
require 'minitest/autorun'
require 'logger'
# Ensure backward compatibility with Minitest 4
Minitest::Test = MiniTest::Unit::TestCase unless defined?(Minitest::Test)
# This connection will do for database-independent bug reports.
ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')
ActiveRecord::Base.logger = Logger.new(STDOUT)
ActiveRecord::Schema.define do
create_table :posts do |t|
end
end
class Post < ActiveRecord::Base
end
class BugTest < Minitest::Test
def test_record_not_found_message
assert_equal 0, Post.count
find_message = nil
begin
Post.find(99999)
rescue ActiveRecord::RecordNotFound => err
find_message = err.message
end
assert_equal "Couldn't find Post with 'id'=99999", find_message
no_class_message = nil
begin
Post.find_by!(id: 99999)
rescue ActiveRecord::RecordNotFound => err
no_class_message = err.message
end
assert_equal "Couldn't find Post with [WHERE \"posts\".\"id\" = 99999]", no_class_message
end
end
unless File.exist?('Gemfile')
File.write('Gemfile', <<-GEMFILE)
source 'https://rubygems.org'
gem 'rails', github: 'rails/rails'
gem 'arel', github: 'rails/arel'
gem 'sqlite3'
GEMFILE
system 'bundle'
end
require 'bundler'
Bundler.setup(:default)
require 'active_record'
require 'minitest/autorun'
require 'logger'
# This connection will do for database-independent bug reports.
ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')
ActiveRecord::Base.logger = Logger.new(STDOUT)
ActiveRecord::Schema.define do
create_table :posts do |t|
end
end
class Post < ActiveRecord::Base
end
class BugTest < Minitest::Test
def test_record_not_found_message
assert_equal 0, Post.count
find_message = nil
begin
Post.find(99999)
rescue ActiveRecord::RecordNotFound => err
find_message = err.message
end
assert_equal "Couldn't find Post with 'id'=99999", find_message
no_class_message = nil
begin
Post.find_by!(id: 99999)
rescue ActiveRecord::RecordNotFound => err
no_class_message = err.message
end
assert_equal "Couldn't find Post with [WHERE \"posts\".\"id\" = 99999]", no_class_message
end
end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment