Beautiful Code, blog post on my blog http://rizky.abdi.la

unpick1.php

function unpickSeatById($seating_id){
    $book_key = "booking-seat-" . strval($seating_id);
    $this->redis->del($book_key);
    return changeSeatStatusById($seating_id, 1);
}

unpick2.php

function unpickSeatById($seating_id){
    $book_key = "booking-seat-" . strval($seating_id);
    $this->redis->del($book_key);

    $seat_status = getSeatStatusById($seating_id);
    if ($seat_status == 3){
        return false;
    }
    return changeSeatStatusById($seating_id, 1);
}

unpick3.php

function unpickSeatById($seating_id, $bypass=false){
    $book_key = "booking-seat-" . strval($seating_id);
    $this->redis->del($book_key);

    if ($bypass){
        return changeSeatStatusById($seating_id, 1);
    } else{
        $seat_status = getSeatStatusById($seating_id);
        if ($seat_status == 3){
            return false;
        }
        return changeSeatStatusById($seating_id, 1);
    }
}

unpick4.php

function unpickSeatById($seating_id, $bypass=false){
    $book_key = "booking-seat-" . strval($seating_id);
    $this->redis->del($book_key);

    $change = true;
    if (!$bypass){
        $change = false        
        $seat_status = getSeatStatusById($seating_id);
        if ($seat_status != 3){
            $change = true;
        }
    }

    $rv = false;
    if ($change){
        $rv = changeSeatStatusById($seating_id, 1);
    }
    return $rv;
}

unpick_final.php

function unpickSeatById($seating_id, $bypass=false){
    $book_key = "booking-seat-" . strval($seating_id);
    $this->redis->del($book_key);

    $seat_status = getSeatStatusById($seating_id);
    // jika tidak di set bypass == true dan seat status == 3 (terjual)
    // maka kursi tidak dilepas
    if ($seat_status != 3 || $bypass){
        return changeSeatStatusById($seating_id, 1);
    }
    return false;
}