Code Tidbits: #23 No Else Return (Medium Post)

23-example-with-nested-if-else-statements.js

// ❌  You can skip the else block
function calcPercentage(number) {
  
  // Check if valid number
  if(typeof number === 'number') {
    
    // Another check: only do calculation number is less than 1
    if (number > 1) {
      return 'Number must be less than 1';
    } else {
      return `${number * 100}%`;
    }
  }  else {
    return 'Please enter valid whole number';
  }
}

// ✅  Yay, much easier to read
function calcPercentage(number) {
  
  if(typeof number === 'number') {
    
    if (number > 1) {
      return 'Number must be less than 1';
    }

    return `${number * 100}%`;
  } 
  
  return 'Please enter valid whole number';
}