Forked from samanthaming/23-example-with-nested-if-else-statements.js
Created
July 9, 2018 17:39
-
-
Save aymenbz/87e05f409b5596f9d63ce5037a115d92 to your computer and use it in GitHub Desktop.
Code Tidbits: #23 No Else Return (Medium Post)
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// ❌ You can skip the else block | |
function calcPercentage(number) { | |
// Check if valid number | |
if(typeof number === 'number') { | |
// Another check: only do calculation number is less than 1 | |
if (number > 1) { | |
return 'Number must be less than 1'; | |
} else { | |
return `${number * 100}%`; | |
} | |
} else { | |
return 'Please enter valid whole number'; | |
} | |
} | |
// ✅ Yay, much easier to read | |
function calcPercentage(number) { | |
if(typeof number === 'number') { | |
if (number > 1) { | |
return 'Number must be less than 1'; | |
} | |
return `${number * 100}%`; | |
} | |
return 'Please enter valid whole number'; | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment