Created
February 6, 2025 17:40
-
-
Save atdt/03c102d5ca5a475dcaa17f8c530eb161 to your computer and use it in GitHub Desktop.
Patches to divert PHP8 Excimer profiles to separate ArcLamp sinks (TT385199)
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# operations/mediawiki-config | |
From 17163a2df5ea1891ddf03b650791782e3be93ce1 Mon Sep 17 00:00:00 2001 | |
From: Ori Livneh <ori.livneh@gmail.com> | |
Date: Thu, 6 Feb 2025 12:35:26 -0500 | |
Subject: [PATCH 1/1] Route PHP8 Excimer profiles to separate ArcLamp sinks | |
--- | |
src/Profiler.php | 7 +++++++ | |
1 file changed, 7 insertions(+) | |
diff --git a/src/Profiler.php b/src/Profiler.php | |
index f5a8bf9913..eb5955dba1 100644 | |
--- a/src/Profiler.php | |
+++ b/src/Profiler.php | |
@@ -235,6 +235,13 @@ class Profiler { | |
if ( ClusterConfig::getInstance()->isK8s() ) { | |
$redisChannel .= '-k8s'; | |
} | |
+ // Temporarily route PHP 8 profiles to a separate set of sinks | |
+ // (excimer-k8s-php8, excimer-k8s-php8-wall) during the migration to | |
+ // PHP 8, to facilitate comparison and diffing with PHP 7 profiles | |
+ // (TT385199). | |
+ if ( PHP_MAJOR_VERSION === 8 ) { | |
+ $redisChannel .= '-php8'; | |
+ } | |
// The period is 60s, so there's no point waiting for more samples to arrive | |
// before the end of the request, they probably won't. | |
-- | |
2.48.1.362 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# operations/puppet | |
From a78cf309cc09eb6bd3af4950261eba36abcc3dab Mon Sep 17 00:00:00 2001 | |
From: Ori Livneh <ori.livneh@gmail.com> | |
Date: Thu, 6 Feb 2025 12:28:49 -0500 | |
Subject: [PATCH 1/1] Set up ArcLamp pipeline for PHP8 | |
--- | |
modules/arclamp/manifests/init.pp | 4 ++++ | |
1 file changed, 4 insertions(+) | |
diff --git a/modules/arclamp/manifests/init.pp b/modules/arclamp/manifests/init.pp | |
index 9f635e5d58..57813a7f8a 100644 | |
--- a/modules/arclamp/manifests/init.pp | |
+++ b/modules/arclamp/manifests/init.pp | |
@@ -181,5 +181,9 @@ class arclamp( | |
description => 'PHP Excimer (k8s CPU)'; | |
'excimer-k8s-wall': # T288165 | |
description => 'PHP Excimer (k8s wall clock)'; | |
+ 'excimer-php8-k8s': # T385199 | |
+ description => 'PHP Excimer (k8s, PHP8 CPU)'; | |
+ 'excimer-php8-k8s-wall': # T385199 | |
+ description => 'PHP Excimer (k8s, PHP8 wall clock)'; | |
} | |
} | |
-- | |
2.48.1.362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment