pw981652-p14154202

checkpatch-WARNING

WARNING: 'wont' may be misspelled - perhaps 'won't'?
#27: 
In case toolchain doesn't support cfi extension, cfi kselftest wont
                                                               ^^^^

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#78: 
new file mode 100644

CHECK: Lines should not end with a '('
#271: FILE: tools/testing/selftests/riscv/cfi/riscv_cfi_test.c:70:
+		asm volatile (

WARNING: unnecessary whitespace before a quoted newline
#273: FILE: tools/testing/selftests/riscv/cfi/riscv_cfi_test.c:72:
+		"jalr a5 \n"

WARNING: unnecessary whitespace before a quoted newline
#274: FILE: tools/testing/selftests/riscv/cfi/riscv_cfi_test.c:73:
+		"nop \n"

WARNING: unnecessary whitespace before a quoted newline
#275: FILE: tools/testing/selftests/riscv/cfi/riscv_cfi_test.c:74:
+		"nop \n"

CHECK: braces {} should be used on all arms of this statement
#289: FILE: tools/testing/selftests/riscv/cfi/riscv_cfi_test.c:88:
+		if (WIFSTOPPED(status)) {
[...]
+		} else
[...]

CHECK: Unbalanced braces around else statement
#294: FILE: tools/testing/selftests/riscv/cfi/riscv_cfi_test.c:93:
+		} else

CHECK: Alignment should match open parenthesis
#304: FILE: tools/testing/selftests/riscv/cfi/riscv_cfi_test.c:103:
+				ksft_exit_fail_msg("%s: ptrace_getregset failed, %llu\n", __func__,
+				cfi_reg.cfi_status.cfi_state);

CHECK: Alignment should match open parenthesis
#307: FILE: tools/testing/selftests/riscv/cfi/riscv_cfi_test.c:106:
+				ksft_exit_fail_msg("%s: NULL shadow stack pointer, test failed\n",
+				__func__);

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#660: FILE: tools/testing/selftests/riscv/cfi/shadowstack.c:280:
+volatile bool break_loop;

total: 0 errors, 6 warnings, 5 checks, 694 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 105a0cad2b79 ("kselftest/riscv: kselftest for user mode cfi") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 6 warnings, 5 checks, 694 lines checked
CHECK: Alignment should match open parenthesis
CHECK: Lines should not end with a '('
CHECK: Unbalanced braces around else statement
CHECK: braces {} should be used on all arms of this statement
WARNING: 'wont' may be misspelled - perhaps 'won't'?
WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
WARNING: unnecessary whitespace before a quoted newline