Skip to content

Instantly share code, notes, and snippets.

Created September 21, 2017 03:26
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save anonymous/11443e08667851949d4143cdb8b8af64 to your computer and use it in GitHub Desktop.
Save anonymous/11443e08667851949d4143cdb8b8af64 to your computer and use it in GitHub Desktop.
commit 1361fd6ae837bd53f9cfdaa01cfaabde00d499a0
Author: Chris Burgess <chrisburgess@catalyst.net.nz>
Date: Thu Sep 21 15:25:20 2017 +1200
Issue #2910372. Coding standards for Media WYSIWYG.
diff --git a/modules/media_wysiwyg/includes/media_wysiwyg.file_usage.inc b/modules/media_wysiwyg/includes/media_wysiwyg.file_usage.inc
index 7d90166..2280477 100644
--- a/modules/media_wysiwyg/includes/media_wysiwyg.file_usage.inc
+++ b/modules/media_wysiwyg/includes/media_wysiwyg.file_usage.inc
@@ -121,8 +121,8 @@ function media_wysiwyg_filter_parse_from_fields($entity_type, $entity) {
/**
* Utility function to get the file count in this entity
*
- * @param type $entity
- * @param type $entity_type
+ * @param string or int or object... $entity
+ * @param string or int or object... $entity_type
* @return int
*/
function media_wysiwyg_entity_field_count_files($entity_type, $entity) {
@@ -154,8 +154,8 @@ function media_wysiwyg_entity_delete($entity, $type) {
/**
* Implements hook_field_attach_delete_revision().
*
- * @param type $entity_type
- * @param type $entity
+ * @param string or int or object... $entity_type
+ * @param string or int or object... $entity
*/
function media_wysiwyg_field_attach_delete_revision($entity_type, $entity) {
list($entity_id) = entity_extract_ids($entity_type, $entity);
diff --git a/modules/media_wysiwyg/includes/media_wysiwyg.pages.inc b/modules/media_wysiwyg/includes/media_wysiwyg.pages.inc
index fdb4c53..1c919dd 100644
--- a/modules/media_wysiwyg/includes/media_wysiwyg.pages.inc
+++ b/modules/media_wysiwyg/includes/media_wysiwyg.pages.inc
@@ -80,7 +80,7 @@ function media_wysiwyg_format_form($form, &$form_state, $file) {
'#default_value' => $default_view_mode,
'#description' => t('Choose the type of display you would like for this
file. Please be aware that files may display differently than they do when
- they are inserted into an editor.')
+ they are inserted into an editor.'),
);
// If necessary, display the alignment widget.
@@ -212,7 +212,7 @@ function media_wysiwyg_format_form_view_mode(&$form, $form_state, $file) {
}
/**
- * AJAX callback to select the portion of the format form to be updated with a preview.
+ * AJAX callback to select portion of format form to be updated with a preview.
*
* @param array $form
* An associative array containing the structure of the form.
diff --git a/modules/media_wysiwyg/js/wysiwyg-media.js b/modules/media_wysiwyg/js/wysiwyg-media.js
index 87ac8cc..86df7e4 100644
--- a/modules/media_wysiwyg/js/wysiwyg-media.js
+++ b/modules/media_wysiwyg/js/wysiwyg-media.js
@@ -1,4 +1,3 @@
-
/**
* @file
* Attach Media WYSIWYG behaviors.
@@ -137,7 +136,8 @@ InsertMedia.prototype = {
}
};
-/** Helper functions */
+ /**
+ * Helper functions */
/**
* Ensures the tag map has been initialized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment