Skip to content

Instantly share code, notes, and snippets.

@nati

nati/gist:1355816

Created November 10, 2011 19:12
Show Gist options
  • Save nati/1355816 to your computer and use it in GitHub Desktop.
Save nati/1355816 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
gistfile1.txt
/home/nova/essex2/nova
##############856034######################
-Test Specification
https://docs.google.com/spreadsheet/ccc?key=0AsUHVTZg__ridEcwNlU4VktxU1ZqVlZ1ZDJhOWlyNXc\u0026hl=en_US
-Tracability-matrix
https://docs.google.com/spreadsheet/ccc?key=0Ato6uknaqvE8dE0zVzFmdU14OXRWaXcyM3hvUm9McXc\u0026hl=en_US
-github
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-856034
git checkout master
git checkout -b essex-openstack-qa-nova-856034
git cherry-pick 353ae48fc9bee008fc1697c012c31fad2e307fad
git cherry-pick bfd1d57e5b92d167fc7cd2f4c8f8cbb203d0d512
git cherry-pick a03a2fd2b381d6739df0db54657645ec9e9e29ce
git cherry-pick 6abe1857848e04066bd75b00e3505ba553796ea4
####Status
100644 efc0122ee9310db8bd81d382d5ec01112140ef82 1 nova/tests/test_compute_manager.py
100644 65037d8672dd797c174ef1cb66208667981856ae 3 nova/tests/test_compute_manager.py
##############860401######################
-Test Specification
https://docs.google.com/spreadsheet/ccc?key=0AulGiQepLutkdDVNN19nMVptNWRUbUd6N3hoOVM4UFE\u0026hl=en_US
-Tracability-matrix
https://docs.google.com/spreadsheet/ccc?key=0AulGiQepLutkdHFabXVQMlN0QWtmM1RDY1BHUlhyeEE\u0026hl=en_US
-Github branch
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-860401
git checkout master
git checkout -b essex-openstack-qa-nova-860401
git cherry-pick 9722811cd49edc842254f1eaacc2c49ba2880e64
# On branch essex-openstack-qa-nova-860401
nothing to commit (working directory clean)
####Status
##############860437######################
-Test specification
https://docs.google.com/spreadsheet/ccc?key=0AulGiQepLutkdDlCZ3RJMG9FWXBBNlA3NGhrYXdoLXc\u0026hl=en_US
-Tracability-matrix
https://docs.google.com/spreadsheet/ccc?key=0AulGiQepLutkdEpDNkl4RzFFaXpMNlF2MzVJR3Npbmc\u0026hl=en_US
-Github branch
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-860437
git checkout master
git checkout -b essex-openstack-qa-nova-860437
git cherry-pick bec0e8cdc26913dde07fab3745c0f38c8e133e9c
####Status
100644 09f532239cb9fc99e5c4b5cb18b5a2f26ebc9b24 1 nova/tests/test_instance_types.py
100644 58f0cb00d864abc69be9f9efb6dac3ed588aab08 2 nova/tests/test_instance_types.py
100644 da3dd75cef5995e4c2e1b4559a60186b1c062719 3 nova/tests/test_instance_types.py
##############862202######################
Checklist:
https://docs.google.com/spreadsheet/ccc?key=0As5cC18HZlbndEx5bTBFblNqM1RHbkQzVmJUUzVTU3c\u0026hl=en_US
Traceability_Matrix:
https://docs.google.com/spreadsheet/ccc?key=0As5cC18HZlbndFBJcjhqZl9wQUh3RkxvR1hwOUt1V2c\u0026hl=en_US#gid=0
github:
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-862202
git checkout master
git checkout -b essex-openstack-qa-nova-862202
git cherry-pick a0c0d129c229561745f9f6f979fd6bd524093c55
git cherry-pick f5d65bdbae36685901c2446167eb7ed0b8c97af6
git cherry-pick 7c28905df0e3066ca1ebd5d0ef5516e02c665490
git cherry-pick 9365f367da6d2301e6d048aeb756970a9f1e849e
git cherry-pick 5117acada2ac4f63d9c1fcb3b2c4ed5834ea8bba
git cherry-pick 733b9c17a30b06aaad1049aa99f07b377581576a
git cherry-pick b9fb28047751734b0cd4e64fc32299c076d6f701
git cherry-pick 975b1e7313238a13f44a7dbc843f532855dcd9ad
git cherry-pick 5c75ce0d400fdd2129547824d24c232c185b4ad0
git cherry-pick cb4702f565bec5d25c7e4a6d9129c1d491333015
git cherry-pick d727f31ddfaa82daf1a64d5254bdda4505c46b59
####Status
100644 e873a4e82fc39189c5d66ad2b609740d531a2ae9 1 nova/tests/test_network.py
100644 759650839f75c9640af6a552062dbc27a5b575aa 2 nova/tests/test_network.py
100644 ed29c262b6d8dd2903b7c65af5d28ec01cf1c37a 3 nova/tests/test_network.py
##############863209######################
spec_nova.service
https://docs.google.com/spreadsheet/ccc?key=0AuaiYdujau1adHZGS2xIek44M1psWW9MTEpvQlNUUnc\u0026hl=ja#gid=0
Traceability_Matrix_for_SmallTest_service
https://docs.google.com/spreadsheet/ccc?key=0AuaiYdujau1adDRibjlyN1V6YlJDaGRROEJ4M3ItOWc\u0026hl=ja#gid=0
git checkout master
git checkout -b essex-openstack-qa-nova-863209
git cherry-pick 05016d5fc851c5e9dd24f451a0a9d13ba12926e8
# On branch essex-openstack-qa-nova-863209
nothing to commit (working directory clean)
####Status
##############868103######################
Checklist:
https://docs.google.com/spreadsheet/ccc?key=0As5cC18HZlbndE1rNkUzcDd5eTVUUmwzOHAxWXNSZUE\u0026hl=en_US
Traceability_Matrix:
https://docs.google.com/spreadsheet/ccc?key=0As5cC18HZlbndGk1b1g0NW00SU9qUzl5eFJVWGZERWc\u0026hl=en_US
github:
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-868103
git checkout master
git checkout -b essex-openstack-qa-nova-868103
git cherry-pick b13f2023e16c7101b3c02fb9ab12493a5ea5ffcd
git cherry-pick 57a8300e3866389d22fa64100910b5d177242f31
git cherry-pick 4fe9dda293f2896ac7c8bb98e6065109a957f8f2
####Status
100644 3b0676a9e57e0ce4828f006221f4d6de3af0a9a8 1 nova/tests/test_compute_utils.py
100644 12b98aa0bff660b09b98ea36a0b1c5606fc106fd 2 nova/tests/test_compute_utils.py
100644 a52f50fbb935cf9c070076cbfe81deeb64091426 3 nova/tests/test_compute_utils.py
##############868105######################
-Test Specification
https://docs.google.com/spreadsheet/ccc?key=0Ato6uknaqvE8dHE1TWhjZlRaa1RKNkVUdHp1Y1BoTlE\u0026hl=en_US
-Tracability-matrix
https://docs.google.com/spreadsheet/ccc?key=0Ato6uknaqvE8dGNMNE9obUFhUi12bDJaUExQMTFZNHc\u0026hl=en_US
-github
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-868105
git checkout master
git checkout -b essex-openstack-qa-nova-868105
git cherry-pick 469d06a58ad3a110acde357c47a6ab53a1ae8003
git cherry-pick 2f6c8f73c9c89ddd072a9d85550a28ddefa4f18a
####Status
100644 631751bf75d17bafde02bc8dfa3e91d3b7a90f5a 1 nova/tests/test_linux_net.py
100755 0e933eff5f78efbd07161c97e8280f5ac8a0574c 2 nova/tests/test_linux_net.py
100644 9a65e77a554a5be541239a34315ab8f81117e4b4 3 nova/tests/test_linux_net.py
##############869641######################
-Test Specification
https://docs.google.com/spreadsheet/ccc?key=0AulGiQepLutkdHNYVFo0b2ZmLUtONkRhSS04YXY2VVE\u0026hl=en_US
-Tracability-matrix
https://docs.google.com/spreadsheet/ccc?key=0AulGiQepLutkdGNoSUVadTVjcjNWTHNpcDFwMW1zTWc\u0026hl=en_US
-Github branch
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-869641
git checkout master
git checkout -b essex-openstack-qa-nova-869641
git cherry-pick 5aa6974c96e8b5431d3a6e2f3b551aa1c2cbd771
####Status
100644 1ba794a1a95471629b030776e40150619e5c6bf9 1 nova/tests/test_utils.py
100644 9ca56bfa699602778030b961f5a5f0695521d0a6 2 nova/tests/test_utils.py
100644 93eefbff45fa570e6f3c5461f5d4750e2f149c1c 3 nova/tests/test_utils.py
##############869862######################
Checklist:
https://docs.google.com/spreadsheet/ccc?key=0As5cC18HZlbndDZxd2daa3JETmc3LVZ5UDRoLW5pMmc\u0026hl=en_US
Traceability_Matrix:
https://docs.google.com/spreadsheet/ccc?key=0As5cC18HZlbndHNNM2hTUE9LMW5BZHJOUnljNjk4Q3c\u0026hl=en_US
github:
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-869862
git checkout master
git checkout -b essex-openstack-qa-nova-869862
git cherry-pick d1138c0df9c9fc2cd778b61d09733cef8e683d71
git cherry-pick 452de1c92bd9b4a55a79a4c501bfbb29cfa60f37
####Status
100644 90daff5236797ddb1191e14966dd606bf0703194 1 nova/tests/test_flags.py
100644 dab11c5e0178e3bbdf8dd78adb3660eeffb6be3c 2 nova/tests/test_flags.py
100644 f1bff7c65f918b24f09d5d2394193d837df6f14a 3 nova/tests/test_flags.py
##############872171######################
Checklist:
https://docs.google.com/spreadsheet/ccc?key=0Ato6uknaqvE8dF91M1ZUTjhzODktQnl6ZXhiS0lNbGc\u0026hl=en_US
Traceability_Matrix:
https://docs.google.com/spreadsheet/ccc?key=0Ato6uknaqvE8dHJSOWdvdVFDeGRWVUtOMHE2V3B0U0E\u0026hl=en_US
github
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-872171
git checkout master
git checkout -b essex-openstack-qa-nova-872171
git cherry-pick 7900c2728770ff0936d89abe70416d64f7bb8c80
git cherry-pick 7a77e991c8196b65a537cd9f500eb8eb51fbf9af
git cherry-pick eef552701d7aba4da34e7dfb907cb2c5ad6c59ff
####Status
100644 06d6a54cf5841d95b40a1c4f98d503ee9ac21768 1 nova/tests/test_exception.py
100644 d3bc1f6e874d4909eea481fe258a8e479dd148ab 2 nova/tests/test_exception.py
100644 941b91ea8b787e23558b18cb0e3166a51aa5dca1 3 nova/tests/test_exception.py
##############872450######################
utils.xhtml_escape should escape apostrophe, U+0027 to \u0026apos;
nova/utils.py
514 xhtml_escape(value)
git checkout master
git checkout -b essex-openstack-qa-nova-872450
git cherry-pick 8196445e939f44cd0c9bd74f6e910738cdcce7a1
[essex-openstack-qa-nova-872450 05b93a5] Fixes bug 872450
1 files changed, 1 insertions(+), 1 deletions(-)
####Status
##############872457######################
The uuid check should be
[0-9A-Fa-f]{8}\\-[0-9A-Fa-f]{4}\\-[0-9A-Fa-f]{4}\\-[0-9A-Fa-f]{4}\\-[0-9A-Fa-f]{12}
git checkout master
git checkout -b essex-openstack-qa-nova-872457
git cherry-pick d1c6b53f9034122d5e2a963a356f2b1b0eb870dc
[essex-openstack-qa-nova-872457 4d8adaa] Fixes bug 872457
1 files changed, 6 insertions(+), 0 deletions(-)
####Status
##############872475######################
nova.compute.manager throws exception.Error.
This is not informative, so the manager should raise more specific exception.
git checkout master
git checkout -b essex-openstack-qa-nova-872475
git cherry-pick a05c2726ca6619f02996a3b77669334de05265a0
[essex-openstack-qa-nova-872475 715d4b2] Modified nova.compute.manager throws invalid Error Fixes bug 872475.
1 files changed, 123 insertions(+), 0 deletions(-)
create mode 100644 nova/tests/test_compute_manager.py
git cherry-pick a54f37d2e8c07543bc91c9465d7df6e9249c57f3
####Status
100644 5feb840beb5bb5af12edc4d65e6da808fd3fcb43 1 nova/compute/manager.py
100644 2bb315d8fc3c68e875a50f28a1d60d9fed80ddae 2 nova/compute/manager.py
100644 d6c2bb68b4480ad1b19698208d92681d23d3a237 3 nova/compute/manager.py
##############872489######################
utils.execute throws exception.ProcessExecutionError but it is not handled in many case.
These exceptions must be handled and intermediate state must be rollbacked.
Examples:
In IptablesManager.apply(), util.execute used. When an exception.ProcessExecutionError raised during loop, left procedures are not performed.
- initialize_gateway_device()
- LinuxBridgeInterfaceDriver.ensure_bridge()
- bind_floating_ip()
- unbind_floating_ip()
- ensure_metadata_ip()
- release_dhcp()
- update_dhcp()
- update_ra()
- LinuxBridgeInterfaceDriver.ensure_vlan()
- LinuxOVSInterfaceDriver.plug()
- _device_exists()
- _stop_dnsmasq()
git checkout master
git checkout -b essex-openstack-qa-nova-872489
git cherry-pick 78dc88965de9a84d1e7cb175270ebf2518474b73
git cherry-pick a74f660074a19b8e085c401955704cc039c7c4e5
####Status
100644 06502c2dd4a4c9cc5c4746bc964d22f4a16fd14f 1 nova/tests/test_virt_libvirt_vif.py
100644 1d8578f483f787fcfb468b0992ff6cf9a528a3cb 3 nova/tests/test_virt_libvirt_vif.py
100644 077c32474d6a33fb98cb3d636e04d6f44853456c 1 nova/virt/libvirt/vif.py
100644 96cf2e77d9d06c0a153bc94270a4527c87788ef8 2 nova/virt/libvirt/vif.py
100644 aab07f1975a316a52ee288294aa55247f5a3b2c0 3 nova/virt/libvirt/vif.py
##############872490######################
The exception handling in utils.py should be improved.
- utils.py raises exception.Error. This is not informative.
- IOError\u3001socket.errors are not handled
git checkout master
git checkout -b essex-openstack-qa-nova-872490
git cherry-pick e590ba3ffe0471a6f4813c46b7bcd923440857ab
[essex-openstack-qa-nova-872490 ce907f4] Add testcase for nova.exception.LinkIpNotFound Fixes bug 872490
1 files changed, 16 insertions(+), 0 deletions(-)
git cherry-pick 1c0e93dd0cf6c224ec2745800bc82cd9ca62e5f8
[essex-openstack-qa-nova-872490 2762c27] Fixes bug 872490
2 files changed, 73 insertions(+), 32 deletions(-)
####Status
##############872504######################
nova.compute.util.terminate_volumes do not handle exceptions such as ApiError during loop.
When the exception raised in for loop, other BlockDeviceMapping records are not cleaned up.
git checkout master
git checkout -b essex-openstack-qa-nova-872504
git cherry-pick 8e216f6ad85c88ba4d4196c05b82f7ca52db07c9
git cherry-pick a070f1b038b991f8cf5fc4a7fa941ad6beb25b2d
####Status
100644 83bb97436a597872c9f098c0f3daf166ac730b0d 1 nova/compute/utils.py
100644 885ba9360d7d8ae1a6bb3934811266d6909f80e8 2 nova/compute/utils.py
100644 3902fc0249639b92e65c90555d2335e990bec0b8 3 nova/compute/utils.py
##############872513######################
Following api call do not handle exceptions well.
(See bad exception handling example in blueprint
https://blueprints.launchpad.net/openstack-qa/+spec/nova-exception-policy)
NetworkManager.init_host()
FloatingIP.init_host_floating_ips()
FloatingIP.deallocate_for_instance()
NetworkManager.init_host()
NetworkManager.deallocate_for_instance()
NetworkManager.get_instance_nw_info()
NetworkManager._allocate_mac_addresses()
NetworkManager.remove_fixed_ip_from_instance()
NetworkManager.create_networks()
NetworkManager._create_fixed_ips()
git checkout master
git checkout -b essex-openstack-qa-nova-872513
git cherry-pick f1dccfb2daa17acfd57a4322ac32f2db686d4486
####Status
100644 c582d4d4ca3e29cbcddb75ef32cd715284a9341b 1 nova/network/manager.py
100644 2c5d0b5cb21f7da188f72932d5f7eeb71efb6fc1 2 nova/network/manager.py
100644 aecda3dca794118181c12ac1788867222af2035e 3 nova/network/manager.py
##############872522######################
db.network_get_by_cidr() can return None.
In that case some method in network manager such as delete_network raises AttriuteError.
But this is not informative. In this case, Network manager should throw exception.
Following methods have same problem.
- FloatingIP.associate_floating_ip()
- NetworkManager._get_dhcp_ip()
- NetworkManager.allocate_fixed_ip()
- NetworkManager.deallocate_fixed_ip()
- NetworkManager.lease_fixed_ip()
- NetworkManager.release_fixed_ip()
- NetworkManager.validate_networks()
- VlanManager.allocate_fixed_ip()
git checkout master
git checkout -b essex-openstack-qa-nova-872522
git cherry-pick e8a00b7bff5e03336a536e4324c304732c0271c8
[essex-openstack-qa-nova-872522 78e625d] Fixes bug 872522.
1 files changed, 838 insertions(+), 0 deletions(-)
create mode 100644 nova/tests/test_network_api.py
git cherry-pick 14715fedfdb3137455a000e9084c15ae36a46d47
####Status
100644 6cc678a59a74634904fbd188de8ca68bfa2f27d2 1 nova/db/sqlalchemy/api.py
100644 77d018d43839d5d49fc812838421a7dc5f1f1a2a 2 nova/db/sqlalchemy/api.py
100644 88d8d093a3cbffe934b187c831e62573a60c74d1 3 nova/db/sqlalchemy/api.py
100644 78580d360ba06cc0e293a88bed665ee4fcd31c8b 1 nova/network/api.py
100644 89a746359fda93d68dea3e864bda150cc4eb52b3 2 nova/network/api.py
100644 db2888d0852486015d483f418dea560569ca5941 3 nova/network/api.py
100644 c582d4d4ca3e29cbcddb75ef32cd715284a9341b 1 nova/network/manager.py
100644 2c5d0b5cb21f7da188f72932d5f7eeb71efb6fc1 2 nova/network/manager.py
100644 6ecab37d399635332a588f90a5b5ae58a8176003 3 nova/network/manager.py
100644 60d7abd8c21cd0477d802e3a0b2826b56edc296c 1 nova/tests/test_db_api.py
100644 590505a232f539b5d6ad10d59013f5092804d2e3 2 nova/tests/test_db_api.py
100644 9052a7032dc4a353fb5143fa041281bf6aba0efc 3 nova/tests/test_db_api.py
100644 844aba25a0917fd0d129455f9498193c8c3b4a77 1 nova/tests/test_network.py
100644 759650839f75c9640af6a552062dbc27a5b575aa 2 nova/tests/test_network.py
100644 028a79d3caa85cc29d3787efd4f1335170bfe3a0 3 nova/tests/test_network.py
##############872536######################
nova.compute.api raises exception inconsistently.
For example, start method didn't raise exception when this api stops without processing request.
\u00a0def start(self, context, instance_id):
\u00a0\u00a0\u00a0\u00a0\u00a0\u00a0\u00a0\u00a0\
git checkout master
git checkout -b essex-openstack-qa-nova-872536
git cherry-pick a325661ea29654d92b8a80011bed157dae2a9f1a
####Status
100644 0d6e16d1571234482cddbac419d06cfb20730724 1 nova/compute/api.py
100644 a996fa310d593595d7ec3cf7e751823ead85de9f 2 nova/compute/api.py
100644 5f3f9bb4f8664b2d4ee8adf3d500ccf1cf9216e8 3 nova/compute/api.py
##############872541######################
nova.compute.api don't raise exception when an instance is locked.
The Compute manager and the driver do nothing, but api says \
git checkout master
git checkout -b essex-openstack-qa-nova-872541
git cherry-pick a52f94a3470120aab0e03dce9059572ab9b01d7a
####Status
100644 0d6e16d1571234482cddbac419d06cfb20730724 1 nova/compute/api.py
100644 a996fa310d593595d7ec3cf7e751823ead85de9f 2 nova/compute/api.py
100644 3df275576d310fc2229af358b9c536e77117b436 3 nova/compute/api.py
##############872615######################
nova.compute.api.create don't validate max_count is a valid number or not.
When the user input a string value as max_count, then nova.compute creates max quota number of instances .
git checkout master
git checkout -b essex-openstack-qa-nova-872615
git cherry-pick 0c8ae5213c8aeefcec3d6af02f752f2d0adbe7a5
####Status
100644 0d6e16d1571234482cddbac419d06cfb20730724 1 nova/compute/api.py
100644 a996fa310d593595d7ec3cf7e751823ead85de9f 2 nova/compute/api.py
100644 ce99d42abc66afce175d122e9191e5a45aa1785c 3 nova/compute/api.py
##############872618######################
get_instance_type and get_default_instance_type in instance_types.py don't handle exception.InstanceTypeNotFound.
This exception must be handled and then this class should produce APIError.
git checkout master
git checkout -b essex-openstack-qa-nova-872618
git cherry-pick bd6688a282df09966aaba7f316ccac3a58857e03
####Status
100644 824416514642f192f63a8061dbf818ec2d6daadf 1 nova/compute/instance_types.py
100644 b727de2cc2ee7bf23a0dd8bd0d9806d2c3c83b95 2 nova/compute/instance_types.py
100644 974e713d72506f7113abe5a358fb2f54bb12436a 3 nova/compute/instance_types.py
##############873153######################
Checklist:
https://docs.google.com/spreadsheet/ccc?key=0As5cC18HZlbndHBaWk1yU2pCb2NzSmZhZFhHQThDeWc\u0026hl=en_US
Traceability_Matrix:
https://docs.google.com/spreadsheet/ccc?key=0As5cC18HZlbndEwyQlN0ZjktbFNCMlM3bVhIckNHb3c\u0026hl=en_US
github:
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-873153
git checkout master
git checkout -b essex-openstack-qa-nova-873153
git cherry-pick 83b6bcf813cb7ca7324a5386cb922d763e55d442
git cherry-pick 4d14d0d1a762a85769727d8b74fcf884cb9ec2cb
git cherry-pick b43e7b5a5a1fe43e7a8f56e041637b91071365d4
git cherry-pick 364af709803f0fd40076858f0fdcde6d4436b70c
git cherry-pick c3a140058cc0f767ab8e94d77ba8f5fc042107cd
git cherry-pick 233ae8fc780f16e4614fe7bc39bc632c93b12578
####Status
100644 e31b9be851dde8499f71a3933d1635a4d58774a2 1 nova/tests/test_crypto.py
100644 6c25b396e4b6a97fa4688bf32f76a4b937ca8842 2 nova/tests/test_crypto.py
100644 bddb6495ee4e91a39bed7e9c41d0771c433895a9 3 nova/tests/test_crypto.py
##############873183######################
-Test Specification
https://docs.google.com/spreadsheet/ccc?key=0AulGiQepLutkdHVEcVE3T0x5SVRpTVhBZkNLMm5QZUE\u0026hl=en_US
-Tracability-matrix
https://docs.google.com/spreadsheet/ccc?key=0AulGiQepLutkdERVZXpHb3JoSVpwcXU3SWFSTGtZNnc\u0026hl=en_US
-Github branch
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-873183
git checkout master
git checkout -b essex-openstack-qa-nova-873183
git cherry-pick 3c1c905489d62542ee62716ead350669c1f96be2
[essex-openstack-qa-nova-873183 4eca96e] Add testcases for nova.wsgi Fixes bug 873183
1 files changed, 570 insertions(+), 0 deletions(-)
####Status
##############876120######################
Checklist:
https://docs.google.com/spreadsheet/ccc?key=0Ato6uknaqvE8dHdwT2dqRkZod25oYlpuTkl4Y0oxbVE\u0026hl=en_US#gid=0
Traceability_Matrix:
https://docs.google.com/spreadsheet/ccc?key=0Ato6uknaqvE8dDhvOUNGbktJSzdWVU5UMGp6T3ZuZmc\u0026hl=en_US#gid=0
github
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-876120
git checkout master
git checkout -b essex-openstack-qa-nova-876120
git cherry-pick 8a4790f4be03568c507310889f1f7566f02a42c4
git cherry-pick a67a84ff26e1dc6223d4c6e9b0f4cd434550ac84
####Status
100644 aa2302a92446733714483066bc5e91d6b07f3121 1 nova/tests/db/test_base.py
100644 67ee865e9335b5588be6b2412c1ea18f4ecf295c 3 nova/tests/db/test_base.py
##############876275######################
Checklist:
https://docs.google.com/spreadsheet/ccc?key=0Ato6uknaqvE8dDBWbmVhQUJXWVVzQ2lRSkZDSEU3M2c\u0026hl=en_US
Traceability_Matrix:
https://docs.google.com/spreadsheet/ccc?key=0Ato6uknaqvE8dExtX3hINFlwYUh1am01NWNGZmVGR0E\u0026hl=en_US
github:
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-876275
git checkout master
git checkout -b essex-openstack-qa-nova-876275
git cherry-pick 44727e132001925c5f5571d0f42da7ed9bef8794
git cherry-pick e1fa5f4e3c71de53db58b49c3d0656bcf58d7838
git cherry-pick 1936478c761fc9afe187ead38364bd2af16c0a2a
git cherry-pick 9e9fa31177dbbcf3fa9f2d815fa3de8fd7dec44b
git cherry-pick 02b57247830d5727abf440532cddf4b5d229ae69
####Status
100644 cf730d3c6e7b9651d14374619575db57a7dcca96 1 nova/tests/test_virt_images.py
100644 11e569347ad321aecd71220a59f0f944d6986c81 3 nova/tests/test_virt_images.py
##############877091######################
-Test Specification
https://docs.google.com/spreadsheet/ccc?key=0AhaCUzjDteQYdFozek1OVHM4MVFwNkFoRUYwUTRxOWc\u0026hl=en_US#gid=0
-Traceability_Matrix:
https://docs.google.com/spreadsheet/ccc?key=0AhaCUzjDteQYdEpzR3BrOGlQQ1QycFJnb3VfekppVXc\u0026hl=en_US
git checkout master
git checkout -b essex-openstack-qa-nova-877091
git cherry-pick 93ef9b8e994f5f5be5bb22ce2810e790ee039985
[essex-openstack-qa-nova-877091 e8b10c6] Add testcases for nova.notifier.api Fixes bug 877091
1 files changed, 150 insertions(+), 0 deletions(-)
create mode 100644 nova/tests/notifier/test_notifier_api.py
####Status
##############877115######################
-Test Specification
https://docs.google.com/spreadsheet/ccc?key=0AhaCUzjDteQYdGpVYVNSeDd4UzlUSHhwRDVkVXJXZnc\u0026hl=en_US
-Traceability_Matrix:
https://docs.google.com/spreadsheet/ccc?key=0AhaCUzjDteQYdEY3T09VMUV5ekhrbmd1VG1IV3VCUXc\u0026hl=en_US
-Github branch
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-877115
git checkout master
git checkout -b essex-openstack-qa-nova-877115
git cherry-pick bd1b20b02b11be6c56e9a7942fe5c22209d9a0a9
[essex-openstack-qa-nova-877115 aa532c5] Add testcases for nova.notifier.no_op_notifier Fixes bug 877115
1 files changed, 52 insertions(+), 0 deletions(-)
create mode 100644 nova/tests/notifier/test_no_op_notifier.py
####Status
##############877121######################
Checklist:
https://docs.google.com/spreadsheet/ccc?key=0As5cC18HZlbndGc4UGdmTzBIM2dZVlNkTXNzN2h0UHc\u0026hl=en_US
Traceability_Matrix:
https://docs.google.com/spreadsheet/ccc?key=0As5cC18HZlbndDBTQ29FRmJIdlJvQ2xEY0QwQnVwYmc\u0026hl=en_US
github:
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-877121
git checkout master
git checkout -b essex-openstack-qa-nova-877121
git cherry-pick f153dd02dfdb7ce5814db71b5c6e35ec927d0749
git cherry-pick 361d5ce78fa62c86dab4b92683e4f90e092de1d7
####Status
100644 087e6d3652384ec1d73f44867c476691911e8e7c 1 nova/tests/test_quota.py
100644 6b39adab2994ff9f24cb7c4ce52b589669b2b7ab 2 nova/tests/test_quota.py
100644 82c85677608a63bdb662ca5cf55906eed58685eb 3 nova/tests/test_quota.py
##############877291######################
-Test Specification
https://docs.google.com/spreadsheet/ccc?key=0Ah4SRFAhJkHXdG0xZi1iYXRFemlYWEVDeGgxVUlHRXc\u0026hl=en_US
-Traceability_Matrix:
https://docs.google.com/spreadsheet/ccc?key=0Ah4SRFAhJkHXdFF6Ukx5UmlqaHltYm83WlR5aVVveXc\u0026hl=en_US
-Gibhub branch
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-877291
git checkout master
git checkout -b essex-openstack-qa-nova-877291
git cherry-pick 9361ce9c428e6ba8bf1b26ebefec55bb03e7bc49
[essex-openstack-qa-nova-877291 d942b16] Add testcases for nova.notifier.log_notifier Fixes bug 877291
1 files changed, 75 insertions(+), 0 deletions(-)
create mode 100644 nova/tests/notifier/test_log_notifier.py
####Status
##############877305######################
-Test Specification
https://docs.google.com/spreadsheet/ccc?key=0Ah4SRFAhJkHXdFg3RTFDanBoRktFcDJ0YmV5ZHZwYUE\u0026hl=en_US
-Traceability_Matrix:
https://docs.google.com/spreadsheet/ccc?key=0Ah4SRFAhJkHXdE1uc2FxcEpWemdFajBWcmlRX01GNkE\u0026hl=en_US
-Github branch
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-877305
git checkout master
git checkout -b essex-openstack-qa-nova-877305
git cherry-pick e5a954bbfdf57a013888716876b529713d93b7cd
[essex-openstack-qa-nova-877305 0b3bba1] Add testcases for nova.notifier.list_notifier Fixes bug 877305
1 files changed, 73 insertions(+), 6 deletions(-)
####Status
##############877980######################
Checklist:
https://docs.google.com/spreadsheet/ccc?key=0AuaiYdujau1adDdpTWx3YVJTU2JNVkw0TmMxTUZPenc\u0026hl=ja#gid=0
Traceability_Matrix:
https://docs.google.com/spreadsheet/ccc?key=0AuaiYdujau1adE94bC1wZ1FzQjd1WkI5Z1dCaVdYT0E\u0026hl=ja#gid=0
git checkout master
git checkout -b essex-openstack-qa-nova-877980
git cherry-pick 183029e85fdad168dc8f2da7815f6d56baf98701
[essex-openstack-qa-nova-877980 7d45666] Add testcases for nova.virt.vif.py Fixes bug 877980.
1 files changed, 43 insertions(+), 0 deletions(-)
create mode 100644 nova/tests/test_virt_vif.py
####Status
##############877981######################
Checklist:
https://docs.google.com/spreadsheet/ccc?key=0Ato6uknaqvE8dEdFQWcySU8xN0E5V0NQRE5aaDkxUlE\u0026hl=en_US
Traceability_Matrix:
https://docs.google.com/spreadsheet/ccc?key=0Ato6uknaqvE8dFF1c3hhZzdSejk1SlEzN0lpbFo2bGc\u0026hl=en_US
github:
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-877981
git checkout master
git checkout -b essex-openstack-qa-nova-877981
git cherry-pick 03f8bc0383f95af2be8c44381b32598c10615248
git cherry-pick 6980e82e0cb33f2279a33fa5a0eca26762943475
git cherry-pick 04dbf6a5f08874b52265448efdd9f3d5ac17888a
####Status
100644 7b7e67341e0e1d23bbc3fd45e7b5c6319cdf81f0 1 nova/tests/db/test_sqlalchemy_session.py
100644 a4f91ac7742eb499db84f1f966113356178aeee4 3 nova/tests/db/test_sqlalchemy_session.py
##############878064######################
-Test Specification
https://docs.google.com/spreadsheet/ccc?key=0AuaiYdujau1adE9jRENFZUNIQ0JpQWRBMWdrM0hIMVE\u0026hl=ja
-Tracability-matrix
https://docs.google.com/spreadsheet/ccc?key=0AuaiYdujau1adHJkVFRoZ1JXY3A1VUJlOUR4N1ZtRmc\u0026hl=ja#gid=0
git checkout master
git checkout -b essex-openstack-qa-nova-878064
git cherry-pick d099dc17688647d17eddf02b556efc23434f2ef0
git cherry-pick 358aa47b4614296835d00a8682cfdfb7f44f6f0e
####Status
100644 a9bafe01ac2ccd39adae4704500f795cb01d141d 1 nova/tests/test_log.py
100644 122351ff660a5e6529deb6e2db6f895c4250f0b9 2 nova/tests/test_log.py
100644 3399fba32d3038f2ff53de40cf9f594274a4d587 3 nova/tests/test_log.py
##############878603######################
Checklist:
https://docs.google.com/spreadsheet/ccc?key=0AuaiYdujau1adEFiWXZyYjg4UXg2N21nNnRWN0FCdmc\u0026hl=ja#gid=0
Traceability_Matrix:
https://docs.google.com/spreadsheet/ccc?key=0AuaiYdujau1adEYzZ3VTbk5FSnBaLTFWRjFfRW9uWmc\u0026hl=ja#gid=0
git checkout master
git checkout -b essex-openstack-qa-nova-878603
git cherry-pick 036ea887c5056d2bca4de27acaaf5e087e7f454e
[essex-openstack-qa-nova-878603 5f2db04] Add testcases for nova.rpc.impl_kombu.py Fixes bug 878603
2 files changed, 234 insertions(+), 3 deletions(-)
####Status
##############878673######################
-Test Specification
https://docs.google.com/spreadsheet/ccc?key=0AulGiQepLutkdHk0QmFvbVhUZVB5SF9QVDNlbWVZRXc\u0026hl=en_US
-Tracability-matrix
https://docs.google.com/spreadsheet/ccc?key=0AulGiQepLutkdGFtZ3pObW1zRWR2dUlkb3RlWFJTa0E\u0026hl=en_US
git checkout master
git checkout -b essex-openstack-qa-nova-878673
git cherry-pick 3cba4e2ebad1745f1cbe9fe0346d8bd57881f7f9
git cherry-pick d2f6fcca610a88ccbc99304b193815c5eb5e2e0b
####Status
100644 eef76b67b75c8162c501d955387baa0fca9aa518 1 nova/tests/image/test_glance.py
100644 2ab1897f922f46af65eb138f194ec2e1d59c98b8 2 nova/tests/image/test_glance.py
100644 10d1d8e4aeff955a6c53a1ab42e03f93f27e3b65 3 nova/tests/image/test_glance.py
##############878680######################
Checklist:
https://docs.google.com/spreadsheet/ccc?key=0As5cC18HZlbndDJsMWM1a1RHNGd0Q2NLVEh1VGpHVmc\u0026hl=en_US
Traceability_Matrix:
https://docs.google.com/spreadsheet/ccc?key=0As5cC18HZlbndGVxUkdnWDlJazVqdjNCUFY5UEpvT1E\u0026hl=en_US
github
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-878680
git checkout master
git checkout -b essex-openstack-qa-nova-878680
git cherry-pick ef745612254991ae03517c06dbb2e3afd8240b4d
git cherry-pick 0b74d09aaff67120ee771a93d5d6e271b08cd7c5
git cherry-pick c9ac5a6e240f5a28105f9f09c14e63b94e6caba8
####Status
100644 a6dcfff6bd9673cba9c53456c39ace9fcdbafb72 1 nova/tests/scheduler/test_base_scheduler.py
100644 c73944f3691ab642af1d2fa202513438af5e6384 3 nova/tests/scheduler/test_base_scheduler.py
##############879315######################
-Test Specification
https://docs.google.com/spreadsheet/ccc?key=0AulGiQepLutkdFA3eElza181Ymx5Z0ZwMWcwX05nQmc\u0026hl=en_US
-Tracability-matrix
https://docs.google.com/spreadsheet/ccc?key=0AulGiQepLutkdDgweXhHcHNpcHBIbU5mNGpCRWtQNVE\u0026hl=en_US
-Github branch
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-879315
git checkout master
git checkout -b essex-openstack-qa-nova-879315
git cherry-pick f201b7cf3c11518f386d13e996df141fce62a590
git cherry-pick 2b868723bcbadf7e8bafde27b96cf21f47fc352e
####Status
100644 38acead1e71871c02b0b459987782725e8b5645f 1 nova/tests/test_notifier.py
100644 7de3a4a99832d9147613ce4fd22047074f362b6e 2 nova/tests/test_notifier.py
100644 69f6ffd22da74f62aa8a1a8235d2dc002055c9a5 3 nova/tests/test_notifier.py
##############880615######################
-Test Specification
https://docs.google.com/spreadsheet/ccc?key=0AuaiYdujau1adFkwbEowOFFhQ0xlMF9mM3lNMGZxd3c\u0026hl=ja
-Traceability_Matrix
https://docs.google.com/spreadsheet/ccc?key=0AuaiYdujau1adFBzRTQ3d1VJaE00eVJHdWwyNnc2OEE\u0026hl=ja#gid=0
git checkout master
git checkout -b essex-openstack-qa-nova-880615
git cherry-pick 6cbfb0c09856ac6138b992eb3b89b6070f4a0712
git cherry-pick a83a289251694b1782f170ea903f52d30fea5475
git cherry-pick f9725992930096e9a045961212238db19867210b
####Status
100644 ba7276a1b283cd2f1899447059ae8aa0517771bd 1 nova/tests/test_virt_libvirt_vif.py
100644 c96f700c695f80ece191217700ea2ede1bb9da9d 3 nova/tests/test_virt_libvirt_vif.py
##############880617######################
Checklist:
https://docs.google.com/spreadsheet/ccc?key=0As5cC18HZlbndEdtdUN3QU9vZHFVNXhWbDJlVjY3ZkE\u0026hl=en_US
Traceability_Matrix:
https://docs.google.com/spreadsheet/ccc?key=0As5cC18HZlbndGEycWFyaUsxWEZwNEdBTE9ubE9wd3c\u0026hl=en_US
github:
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-880617
git checkout master
git checkout -b essex-openstack-qa-nova-880617
git cherry-pick 4f33636f76b6e8e1f8a66a4e0051284db9c8393e
git cherry-pick 725437420678656929ea075d3d184ec857d2060e
git cherry-pick 1252238d8a4fd621827021ba7b0fac7285723669
git cherry-pick 956dc257d3b070e024bf705c2f6af2be972a7f94
git cherry-pick 2eed1b37f2b19ac935c1e6ee2cdf3a830621dee3
####Status
100644 0a37b10fddb8b404ba65af697186045197794e4c 1 nova/tests/test_network_api.py
100644 087b66614c18f95bd0c312f1a94af51e51e75dc1 3 nova/tests/test_network_api.py
##############880652######################
Checklist:
https://docs.google.com/spreadsheet/ccc?key=0As5cC18HZlbndFNsZUNRNHhjU1JyYW1iaFJvNVNPdlE\u0026hl=en_US
Traceability_Matrix:
https://docs.google.com/spreadsheet/ccc?key=0As5cC18HZlbndFRYUWxBd0hNWnNRU1FYc3dUdE56NkE\u0026hl=en_US
github:
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-880652
git checkout master
git checkout -b essex-openstack-qa-nova-880652
git cherry-pick 258f7012ba8e65915b9d3b7e215bd04521864415
git cherry-pick 16bed3eb2278bec5ef56e2b483d826c3402425f3
git cherry-pick ba5e485e96997209732f2184105ddf23c817c1d5
####Status
100644 2bb6ffc106bff79dad877d2fbf1b7c0c8ca25a4a 1 nova/tests/test_manager.py
100644 b0ac19e22ad8f83af74676709fb1f31b4aca06af 3 nova/tests/test_manager.py
##############881239######################
Checklist:
https://docs.google.com/spreadsheet/ccc?key=0As5cC18HZlbndGt2MVBYdHpqQ09mZ2l1R0tzaGxtOUE\u0026hl=en_US
Traceability_Matrix:
github:
https://github.com/ntt-pf-lab/nova/tree/openstack-qa-nova-881239
git checkout master
git checkout -b essex-openstack-qa-nova-881239
git cherry-pick 1d339d09c50a89e05ca4e42857808a8076ccfa7c
git cherry-pick 231dfdd627f02717bb9cf575143824538017cd23
git cherry-pick 25bf554ca936e0839cd5e2e4534f796c3d1f9833
git cherry-pick 63cb326131c46b4cce8816de217f1a1717f140a9
git cherry-pick 57edafc6d5cc62536c7f1a7095bb037b860f5482
git cherry-pick cd0fbfd933a30b506517c9ec8303ef51582708a1
git cherry-pick a7cbbb7caecd1f060cfbdf71fde72677c95977aa
git cherry-pick 9c3e4c624366f828b8801525af97cd84fe285253
git cherry-pick 080007798c1a2b5608aca30e6bf5bbff511d7af7
git cherry-pick 8ac8d6d0790df76d83c05b97f50f3179cfa9475e
####Status
100644 0d0e2e700ce14cf29cc8e9e216725211b6642a61 1 nova/tests/test_db_api.py
100644 590505a232f539b5d6ad10d59013f5092804d2e3 2 nova/tests/test_db_api.py
100644 75bd6a681e33f2e81c3d49085d888f8351a26c1c 3 nova/tests/test_db_api.py
##############883002######################
-Test Specification
https://docs.google.com/spreadsheet/ccc?key=0AulGiQepLutkdFF3OVVkcHJ0Qjk2R042XzBkbjByQkE\u0026hl=en_US
-Tracability-matrix
https://docs.google.com/spreadsheet/ccc?key=0AulGiQepLutkdHpOdUtFVXNuN0ZkYWVuOTRpUk84Q0E
git checkout master
git checkout -b essex-openstack-qa-nova-883002
git cherry-pick 0aa8542669fec1b0623244c3960928df8fdbe22c
git cherry-pick 0dc1e5c9f90fcd0f1609c8c7ed1cf887a64a89c7
####Status
100644 749ea0781832890f081c813319bae2f19f57cc5b 1 nova/tests/scheduler/test_scheduler_driver.py
100644 6185dc2008528b7134aaae50d17135c61c62358c 3 nova/tests/scheduler/test_scheduler_driver.py
##############883233######################
In nova/scheduler/driver.py assert_compute_node_has_enough_memory() when it throws an exception it gives the reason as:
reason = _(\
git checkout master
git checkout -b essex-openstack-qa-nova-883233
git cherry-pick ab8a9335783e65fa574691adc60a502b79cef0a8
[essex-openstack-qa-nova-883233 1249ff7] typo in nova/scheduler/driver.py assert_compute_node_has_enough_memory() Fixes bug 883233.
1 files changed, 3 insertions(+), 0 deletions(-)
####Status
##############883251######################
https://github.com/openstack/nova/blob/stable/diablo/nova/compute/manager.py#L285
vollume_id shoud be volume_id
snapshot: %(snapshot_id) should be 'snapshot: %(snapshot_id)s
git checkout master
git checkout -b essex-openstack-qa-nova-883251
git cherry-pick 413866f7721b5ba6c198c23aaa93869c721fac6d
####Status
100644 5feb840beb5bb5af12edc4d65e6da808fd3fcb43 1 nova/compute/manager.py
100644 2bb315d8fc3c68e875a50f28a1d60d9fed80ddae 2 nova/compute/manager.py
100644 60ddebdcf3a0f90d0f4b58836edc67bd8fbfc262 3 nova/compute/manager.py
##############883289######################
nova.image.glance.show_by_name should use a image filter.
This implementation get all images, then filtering on nova process.
https://github.com/openstack/nova/blob/stable/diablo/nova/image/glance.py#L230
git checkout master
git checkout -b essex-openstack-qa-nova-883289
git cherry-pick f89b82a039076366a13f769a576b9c6ceba4b570
git cherry-pick 44f11c36302af5a7fbb5b47f8b1d067021dc5e32
####Status
100644 ca14b8fe268d90a6fd20bd4b16a41b22a5d82824 1 nova/image/glance.py
100644 9eea8eb4c35eb0f6a4a2c5e762bc33290ea29ccb 2 nova/image/glance.py
100644 ae89a804d90d6e25ac9e8d44665e65bfaf135635 3 nova/image/glance.py
##############883293######################
combination of log_notifier and log.PublishErrorsHandler causes infinite loop like this.
log.error() --\u003e PublishErrorsHandler#notifier.api.notify() --\u003e log_notifier.notify() --\u003e log.error()
PublishErrorsHandler should check FLAGS.list_notifier_drivers FLAGS.notification_driver.
git checkout master
git checkout -b essex-openstack-qa-nova-883293
git cherry-pick 9cf5945c9e64d1c6a2eb6d9499e80d6c19aed058
[essex-openstack-qa-nova-883293 dc95477] Add testcases for nova/log.py Fixes bug 883293.
1 files changed, 66 insertions(+), 0 deletions(-)
git cherry-pick 2a95311263cbda5886b9409284fea2d155b3cada
[essex-openstack-qa-nova-883293 0d9d179] combination of log_notifier and log.PublishErrorsHandler causes infinite loop Fixes bug 883293.
1 files changed, 4 insertions(+), 0 deletions(-)
####Status
##############883309######################
https://github.com/openstack/nova/blob/stable/diablo/nova/virt/images.py#L38
This will throw the IOError. This should be handled, and the module should throw APIError
git checkout master
git checkout -b essex-openstack-qa-nova-883309
git cherry-pick b27e41164ea902dc5213c1fc8d57bbaa94bd535d
[essex-openstack-qa-nova-883309 8820ed8] nova.virt.images.py should handle IOError Fixes bug 883309.
1 files changed, 5 insertions(+), 2 deletions(-)
####Status
##############883310######################
If instance_type['memory_mb'] or instance_type['vcpus'] are zero, this method throws ZeroDivisionError.
https://github.com/openstack/nova/blob/master/nova/quota.py#L100
git checkout master
git checkout -b essex-openstack-qa-nova-883310
git cherry-pick 0c2905d53b0684228f3f8711190355bba258c4b8
####Status
100644 f4b481ebe49362be619d645a341e9ce27c079c6c 1 nova/tests/test_quota.py
100644 6b39adab2994ff9f24cb7c4ce52b589669b2b7ab 2 nova/tests/test_quota.py
100644 40527fcc99c046db4e5b8897fb3b22e3a2814100 3 nova/tests/test_quota.py
##############883318######################
add_security_group and remove_security_group refers 'state' column which is already deleted.
This produce AttributeError.
https://github.com/openstack/nova/blob/master/nova/compute/api.py#L711
'state' should be power_state
git checkout master
git checkout -b essex-openstack-qa-nova-883318
git cherry-pick b50dfacfc238303224811aec818195cdc899e3e7
[essex-openstack-qa-nova-883318 8e014c3] Fixes bug 883318
1 files changed, 2 insertions(+), 2 deletions(-)
####Status
##############883320######################
revoke_cert may throw ProcessExecutionError.
https://github.com/openstack/nova/blob/master/nova/crypto.py#L164
This is bad pattern.
(See Policy of Exception Handling
https://blueprints.launchpad.net/openstack-qa/+spec/nova-exception-policy)
git checkout master
git checkout -b essex-openstack-qa-nova-883320
git cherry-pick a8bc057436b4d345424092357602845ec0efc9db
[essex-openstack-qa-nova-883320 d5388e2] Fixes bug 883320.
1 files changed, 33 insertions(+), 3 deletions(-)
####Status
##############883322######################
nova.network.manager should handle exceptions and rollback.
Example
associate_floating_ip didn't handle driver.bind_floating_ip(). The method should handle exceptions and cleanup.
https://github.com/openstack/nova/blob/master/nova/network/manager.py#L341
This also affects.
- FloatingIP.init_host_floating_ips()
- FloatingIP.disassociate_floating_ip()
- NetworkManager.deallocate_fixed_ip()
- FlatDHCPManager.init_host()
- FlatDHCPManager._setup_network()
- VlanManager.init_host()
- VlanManager._setup_network()
git checkout master
git checkout -b essex-openstack-qa-nova-883322
git cherry-pick 8e7d23ce4590c7d565206200ba52ac7c0224089e
####Status
100644 844aba25a0917fd0d129455f9498193c8c3b4a77 1 nova/tests/test_network.py
100644 759650839f75c9640af6a552062dbc27a5b575aa 2 nova/tests/test_network.py
100644 42b81c2b55a9376868a26201b2bbd3f7acdfda39 3 nova/tests/test_network.py
##############883326######################
shutil.rmtree(tmpdir) may throw OSError. This should be handled.
https://github.com/openstack/nova/blob/stable/diablo/nova/crypto.py#L124
git checkout master
git checkout -b essex-openstack-qa-nova-883326
git cherry-pick a3852c8843b40cc6945c206b33ed9e4dafa0cc8d
[essex-openstack-qa-nova-883326 bc7ddb1] Fixes bug 883326.
1 files changed, 10 insertions(+), 2 deletions(-)
####Status
##############883328######################
get_glance_client throws UnboundLocalError when image_href is refs.
UnboundLocalError: local variable 'glance_host' referenced before assignment
https://github.com/openstack/nova/blob/stable/diablo/nova/image/glance.py#L90
In this line, the variables is host, port
https://github.com/openstack/nova/blob/stable/diablo/nova/image/glance.py#L110
but glance_host, glance_port variable is used
https://github.com/openstack/nova/blob/stable/diablo/nova/image/glance.py#L113
git checkout master
git checkout -b essex-openstack-qa-nova-883328
git cherry-pick ea13ea9ec68c24a36c22e44918b6880ca6e30362
[essex-openstack-qa-nova-883328 3c467b8] get_glance_client throws UnboundLocalError Fixing bug 883328.
1 files changed, 2 insertions(+), 0 deletions(-)
git cherry-pick b4ec0838cd2d079da34471f36bc8512037d621e8
####Status
100644 13c8ff843a0d28ed714ebd8c95e6355413ac0452 1 nova/image/glance.py
100644 3e6204a4adf968342a405f5a78198da29912eaed 2 nova/image/glance.py
100644 949eb9afca448b0805dbd07d115bf6702b48964c 3 nova/image/glance.py
##############883333######################
wsgi.stop should check _server is None or not
https://github.com/openstack/nova/blob/stable/diablo/nova/wsgi.py#L96
When the server method called in order of Server.start_tcp --\u003e Server.stop, AttributeError raised.
git checkout master
git checkout -b essex-openstack-qa-nova-883333
git cherry-pick a0dd9d83396afa76c52f1348b31b1c1ed7a5de72
git cherry-pick 19cf43f87129b712b2a6a34b6e9a33c7f50c460c
####Status
100644 1a0025f67a83dea1ea7d54722e028ccbb9e7dc9e 1 nova/wsgi.py
100644 09b45be5a64534aed12b7e822cf17e14e2c40ff0 2 nova/wsgi.py
100644 5802b212c4d29edadc3e394c48cb5144eebe893f 3 nova/wsgi.py
##############883335######################
https://github.com/openstack/nova/blob/stable/diablo/nova/network/manager.py#L649
This bug also affects
release_fixed_ip
git checkout master
git checkout -b essex-openstack-qa-nova-883335
git cherry-pick 4019db67468aeec7a3d9ad7f09a49c10b57a0a84
####Status
100644 844aba25a0917fd0d129455f9498193c8c3b4a77 1 nova/tests/test_network.py
100644 759650839f75c9640af6a552062dbc27a5b575aa 2 nova/tests/test_network.py
100644 39b448a4e994ddd2dd5eaba2883c268dbc3a2b3b 3 nova/tests/test_network.py
##############883336######################
When I create this instance with volume_id parameter, I got UnpackError
Because VolumeIsBusy inherits Error class directly.
VolumeIsBusy should inherit NovaException
https://github.com/openstack/nova/blob/stable/diablo/nova/exception.py#L385
git checkout master
git checkout -b essex-openstack-qa-nova-883336
git cherry-pick 9051d726179bcf937d87f2073fc4658b5d19150a
[essex-openstack-qa-nova-883336 06ecb71] Modified VolumeIsBusy should inherit NovaException. Fixed bug 883336.
1 files changed, 3 insertions(+), 1 deletions(-)
####Status
##############883337######################
config_drive_id is used in nova.compute.api ,but it is not exist in the model of Instance.
https://github.com/openstack/nova/blob/stable/diablo/nova/compute/api.py#L263
git checkout master
git checkout -b essex-openstack-qa-nova-883337
git cherry-pick 8bfeec86e554c8eb38423a4560ca7bdc2391db09
[essex-openstack-qa-nova-883337 dff477d] Fixes bug 883337
2 files changed, 4 insertions(+), 0 deletions(-)
####Status
##############884147######################
-Test Specification
https://docs.google.com/spreadsheet/ccc?key=0Ah4SRFAhJkHXdHBDSWZvSmE1OVFQenVZdG1lcTZuU3c\u0026hl=en_US
-Tracability-matrix
https://docs.google.com/spreadsheet/ccc?key=0Ah4SRFAhJkHXdHJhYzlHNnNBNUpBakNBb2FVaHdTdkE
git checkout master
git checkout -b essex-openstack-qa-nova-884147
git cherry-pick ff052e3c1591d7b5dc1f56c50923b3e02398ee4d
####Status
100644 5549ea4538120ded4e8b55a839d9c8cc8f98587b 1 nova/tests/scheduler/test_abstract_scheduler.py
100644 b2e149c241801d2137fc241ec31e85cbdba348ee 3 nova/tests/scheduler/test_abstract_scheduler.py
##############884581######################
-Test specification
https://docs.google.com/spreadsheet/ccc?key=0AuaiYdujau1adDY3NWFSZWx1UEtVY0N2NU1hOS1nR3c\u0026hl=ja#gid=0
-Tracability-matrix
https://docs.google.com/spreadsheet/ccc?key=0AuaiYdujau1adGVVdG1JWXVMeVZvYUhXNXRwcjA2cHc\u0026hl=ja#gid=0
-Github branch
https://github.com/ntt-pf-lab/nova/commits/openstack-qa-nova-884581
git checkout master
git checkout -b essex-openstack-qa-nova-884581
git cherry-pick 6c81560a6a4307b82dd72357e43baacb8ca26985
git cherry-pick e15c05d73cfce796226c30ee032ea524ec256bd6
git cherry-pick df13d4f5a81f121b6c747f4679a342bd41b0aa04
####Status
100644 0b49542bf1a917541c85ec975a3f2edf8d2cc0e8 1 nova/tests/scheduler/test_scheduler.py
100644 2c32bbd9474d145d27a2235e5ae404de2082e17a 2 nova/tests/scheduler/test_scheduler.py
100644 d01f57ee22fd11fca2858e18e7ddb826da07d240 3 nova/tests/scheduler/test_scheduler.py
##############884584######################
-Test Specification
-Traceability Matrix
-github
git checkout master
git checkout -b essex-openstack-qa-nova-884584
git cherry-pick 444711f2cde2209bf8c1b65f66e9a42254340595
[essex-openstack-qa-nova-884584 4ce4f6b] Add testcases for /nova/scheduler/simple Fixes bug 884584.
1 files changed, 329 insertions(+), 0 deletions(-)
create mode 100644 nova/tests/scheduler/test_simple.py
####Status
##############884601######################
-Test Specification
https://docs.google.com/spreadsheet/ccc?key=0As5cC18HZlbndHlYckFCRFBQWWdrcy02dUtCSTdzTEE
-Tracability-matrix
https://docs.google.com/spreadsheet/ccc?key=0As5cC18HZlbndEZTTW5MUXlGTWhqaGJJM0lyb0w0anc
-github
git checkout master
git checkout -b essex-openstack-qa-nova-884601
git cherry-pick 3a87b1044a8c09efcc5d9f2e1038dc870ea91ee9
git cherry-pick 27652ce8d2a6815b960eaa7c078e34c5f2967b6b
git cherry-pick 513fcfe611ea204572df1ec2f9458515e72b5bcc
git cherry-pick a577dec90aa5b21506cbfa18bd59e75dea12baf8
git cherry-pick c1382e2fe24b2d4956cad0b365edf6f63b6c69d5
git cherry-pick 294770d6daf48d2ea4c709b53d883da5718bf02f
####Status
100644 85cf1cdaeb9ae19c7604021ea20a06ac3d3ac4f7 1 nova/tests/test_virt_disk.py
100644 1ea05fe0690863645f5202d109354cadfee540c0 3 nova/tests/test_virt_disk.py
##############884616######################
-Test Specification
https://docs.google.com/spreadsheet/ccc?key=0AulGiQepLutkdHJndVhFc2NESlNWSjNPTVB4VDVuNWc
-Tracability-matrix
https://docs.google.com/spreadsheet/ccc?key=0AulGiQepLutkdHljcTBvZGdyU2VrN184ZWNmd2thYnc
git checkout master
git checkout -b essex-openstack-qa-nova-884616
git cherry-pick 57ebe0f00b761b6da5467a6752cc6ef1ed8f3b80
[essex-openstack-qa-nova-884616 f919c11] Add testcases for nova.virt.libvirt.netutils Fixes bug 884616
1 files changed, 159 insertions(+), 0 deletions(-)
create mode 100644 nova/tests/virt/__init__.py
create mode 100644 nova/tests/virt/libvirt/__init__.py
create mode 100644 nova/tests/virt/libvirt/test_netutils.py
####Status
##############884827######################
InvalidRPCConnectionReuse is not defined in nova.rpc.impl_kombu
https://github.com/openstack/nova/blob/stable/diablo/nova/rpc/impl_kombu.py#L577
git checkout master
git checkout -b essex-openstack-qa-nova-884827
git cherry-pick eb0d30debd8ce8047d43a634cc948d0fb0b56d20
git cherry-pick 2392743a264a781144114d9ba2ea69f66a696b70
####Status
100644 753779f614773ced16e58ae778f8d66abbbf7c24 1 nova/exception.py
100644 129dc775f695ad6e8d101a548f73d7f22b3c8a44 2 nova/exception.py
100644 6a57a6e2e657cb37298bd42190d7f8691c3071fc 3 nova/exception.py
100644 005026968db19b9181cc5cef56838532a42c7698 1 nova/tests/test_rpc_kombu.py
100644 101ed14af6000b5ba71c29bfbcd6f7a01b27004c 2 nova/tests/test_rpc_kombu.py
100644 635640996c1619e69f1ddb0e35e9e4c553fcc363 3 nova/tests/test_rpc_kombu.py
##############884833######################
Middleware.factory calls __init__ with local_config
https://github.com/openstack/nova/blob/master/nova/wsgi.py#L245
but __init__ don't get local_config parameter.
https://github.com/openstack/nova/blob/master/nova/wsgi.py#L248
git checkout master
git checkout -b essex-openstack-qa-nova-884833
git cherry-pick 4e0f24946d27b29ada38b95db6b5597119d0f952
[essex-openstack-qa-nova-884833 d7c88ee] API mismatch in nova.wsgi.Middleware. Fixes 884833.
1 files changed, 1 insertions(+), 1 deletions(-)
####Status
##############884835######################
Not all of DBs do the commit automatically when the session closed.
Then some kind of modify API returns unmodified value.
For example, Sqllist + test configuration didn't commit automatically .
APs as follows have this issue.
network_associate
https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L1717
network_associate
network_disassociate_all
network_set_host
quota_destroy_all_by_project
git checkout master
git checkout -b essex-openstack-qa-nova-884835
git cherry-pick 14e38906f10a0b582db9bd308b44fc3acb19d202
[essex-openstack-qa-nova-884835 b2043b8] Modified db/sqlalchemy/api.py should call session.save Fixes bug 884835.
1 files changed, 3 insertions(+), 1 deletions(-)
####Status
##############884837######################
Following apis are not used in nova/db/sqlalchemy/api.py
This should be deleted.
virtual_interface_get_by_fixed_ip
instance_get_by_fixed_ip
instance_get_by_fixed_ipv6
volume_metadata_delete_all
volume_metadata_get_item
instance_metadata_delete_all
instance_metadata_get_item
instance_type_extra_specs_get_item
git checkout master
git checkout -b essex-openstack-qa-nova-884837
git cherry-pick c13b51f4694fc282e627ec0a3df8916b3aa22fbe
[essex-openstack-qa-nova-884837 d13fe4a] Modified Unused db.api in /nova/db/sqlalchemy/api.py Fixes bug 884837.
1 files changed, 2 insertions(+), 24 deletions(-)
####Status
##############884839######################
virtual_interface_update throws AttributeError when vif is not exist
This method should check whether vif is exist or not.
https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L965
git checkout master
git checkout -b essex-openstack-qa-nova-884839
git cherry-pick edf6f13bcad63273a08859bc2919253bdabe21d0
# On branch essex-openstack-qa-nova-884839
nothing to commit (working directory clean)
git cherry-pick 4d4b25d097ccdddc794c39174c824010a332a863
[essex-openstack-qa-nova-884839 90f5684] Modified virtual_interface_update throws AttributeError when vif is not exist. Fixes 884839.
1 files changed, 4 insertions(+), 1 deletions(-)
####Status
##############884842######################
This method always return True when the memory_mb is None.
https://github.com/openstack/nova/blob/master/nova/scheduler/driver.py#L380
This method should check memory_mb value.
assert_compute_node_has_enough_disk has same problem.
git checkout master
git checkout -b essex-openstack-qa-nova-884842
git cherry-pick 61a0ca23b5d44bbce3c51a8480d76ec408b4a5a8
[essex-openstack-qa-nova-884842 e69df96] assert_compute_node_has_enough_memory should check memory_mb is None or not Fixes bug 884842.
1 files changed, 5 insertions(+), 2 deletions(-)
####Status
##############884846######################
filename cloud be uninitiated .
https://github.com/openstack/nova/blob/stable/diablo/nova/scheduler/driver.py#L375
This is fixed in essex. But this should be backported to diablo.
git checkout master
git checkout -b essex-openstack-qa-nova-884846
git cherry-pick 97f022108f792aa2b154e741f14c1b8d448f29db
[essex-openstack-qa-nova-884846 6d62cd7] scheduler.driver. mounted_on_same_shared_storage refers uninitiated valiable Fixes bug 884846.
1 files changed, 4 insertions(+), 0 deletions(-)
####Status
##############885104######################
-Test Specification
https://docs.google.com/spreadsheet/ccc?key=0AhaCUzjDteQYdHktUThSRnRiSjhVNlU5Z2QwSzQ4MlE\u0026hl=en_US#gid=0
-Tracability-matrix
https://docs.google.com/spreadsheet/ccc?key=0AhaCUzjDteQYdHg4Wl81QmdXN2M2ZWFHTmJNRGQ2d3c\u0026hl=en_US#gid=0
git checkout master
git checkout -b essex-openstack-qa-nova-885104
git cherry-pick 7c2eafd3c7923712b693b0fb50da4371387625c3
git cherry-pick 73fcfb6f3a383fcc4b2a9421c77af6c28a3a316f
####Status
100644 5e184947f68235bf4d5eb0fc9b50dddd6cfd1653 1 nova/tests/scheduler/test_scheduler_api.py
100644 47c4255a507ddd01f68d93810a8d8701be03b229 3 nova/tests/scheduler/test_scheduler_api.py
##############885476######################
nova.virt.disk.py shoud handle exceptions of utils.execute
Example
Affected APIs
https://github.com/openstack/nova/blob/stable/diablo/nova/virt/disk.py#L97
- mkfs()
- inject_data()
- destroy_container()
- _link_device()
- _unlink_device()
- _inject_metadata_into_fs()
- _inject_key_into_fs()
- _inject_net_into_fs()
git checkout master
git checkout -b essex-openstack-qa-nova-885476
git cherry-pick bd5bb815e4e7b6177e5da54ef9f8295504da2027
git cherry-pick 0e1b19ba1bfdf0d80a7df52be22cb36ea5b3f2fb
####Status
100644 7d4a0ec589ddc720bf6db9fef17467760578aa57 1 nova/virt/disk.py
100644 9fe164cfbcfa5c99760b256ea5cd98536a31773d 2 nova/virt/disk.py
100644 7fafdf65158d114e456f55e82fe77e35f03bc187 3 nova/virt/disk.py
##############885478######################
get_scheduler_rules is not used, so this should be removed.
https://github.com/openstack/nova/blob/stable/diablo/nova/scheduler/manager.py#L84
git checkout master
git checkout -b essex-openstack-qa-nova-885478
git cherry-pick 471aa6caa6e8d76d18b8ec81fa601219bfac55ef
[essex-openstack-qa-nova-885478 6c6c4ec] Modified get_scheduler_rules is not used [diablo/stable]. Fixes bug 885478.
1 files changed, 2 insertions(+), 0 deletions(-)
####Status
##############886260######################
If fs is None, this function produce AttributeError
https://github.com/openstack/nova/blob/stable/diablo/nova/virt/disk.py#L278
API as follows has same problem
_inject_net_into_fs
_inject_metadata_into_fs
git checkout master
git checkout -b essex-openstack-qa-nova-886260
git cherry-pick f640599a82e52c184cc452764a772670c4c2ee65
[essex-openstack-qa-nova-886260 30c3840] _inject_key_into_fs should check fs is None or not Fixes bug 886260.
1 files changed, 10 insertions(+), 6 deletions(-)
####Status
##############886263######################
replace_uuid_with_id produces indexError when the args is array which contains 2 element.
https://github.com/openstack/nova/blob/stable/diablo/nova/scheduler/api.py#L338
The check to length is wrong.
https://github.com/openstack/nova/blob/stable/diablo/nova/scheduler/api.py#L345
git checkout master
git checkout -b essex-openstack-qa-nova-886263
git cherry-pick 52280294505af96af0a077758f8de025dbbb4086
[essex-openstack-qa-nova-886263 73ab2b2] IndexError: pop index out of range on replace_uuid_with_id Fixes bug 886263.
1 files changed, 5 insertions(+), 2 deletions(-)
####Status
##############886266######################
This module produces UnboundLocalError when the ip is irregal.
This module should catch UnboundLocalError, and this module should raise exception.InvalidCidr
https://github.com/openstack/nova/blob/master/nova/virt/libvirt/netutils.py
git checkout master
git checkout -b essex-openstack-qa-nova-886266
git cherry-pick 1beb9ef59d8d130df0943b0ef64b6771154f82f6
[essex-openstack-qa-nova-886266 db29c66] virt.libvirt.netutils.py should handle UnboundLocalError Fixes bug 886266.
1 files changed, 16 insertions(+), 3 deletions(-)
####Status
##############886272######################
setup_container produces UnboundLocalError
1 _link_device failed
2 device is set to None
3 _unlink_device(device, nbd) use device which is None
https://github.com/openstack/nova/blob/master/nova/virt/disk.py#L177
git checkout master
git checkout -b essex-openstack-qa-nova-886272
git cherry-pick ddf806c47ac6f2ee847739f71ab310ff1724592a
[essex-openstack-qa-nova-886272 27d7d0d] setup_container produces UnboundLocalError Fixes bug 886272.
1 files changed, 4 insertions(+), 0 deletions(-)
####Status
##############886275######################
destroy_container should catch exception from utils.execute
https://github.com/openstack/nova/blob/master/nova/virt/disk.py#L192
Thils should be like
https://github.com/openstack/nova/blob/master/nova/virt/disk.py#L199
git checkout master
git checkout -b essex-openstack-qa-nova-886275
git cherry-pick 68c22513dbeda3fdfba0e8fba7a87cf28328b5d1
[essex-openstack-qa-nova-886275 f5815d2] destroy_container should catch exception from utils.execute Fixes bug 886275.
1 files changed, 6 insertions(+), 1 deletions(-)
####Status
##############886278######################
This method produces TypeError when instance is None.
https://github.com/openstack/nova/blob/master/nova/virt/disk.py#L194
git checkout master
git checkout -b essex-openstack-qa-nova-886278
git cherry-pick 47676b94abf14937242f2cfddc1072c0186f440e
[essex-openstack-qa-nova-886278 fa00870] destroy_container should check instance argument Fixing bug 886278.
1 files changed, 7 insertions(+), 0 deletions(-)
####Status
##############887712######################
instance_update check's instance_Id is uuid or not.Then if the instance_id is uuid, this method use instance_get_by_uuid.
However this method didn't check this for instance_metadata_update which doesn't accept uuid.
https://github.com/openstack/nova/blob/stable/diablo/nova/db/sqlalchemy/api.py#L1546
git checkout master
git checkout -b essex-openstack-qa-nova-887712
git cherry-pick 328ca7ead030890fb1146dfe98dbcdb6024ce8a0
[essex-openstack-qa-nova-887712 c712d94] Modify instance_update with uuid as instance_Id and metadata fails. Fixes bug 887712.
1 files changed, 13 insertions(+), 7 deletions(-)
####Status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment