-
-
Save Zegnat/1900563 to your computer and use it in GitHub Desktop.
## Fixing your skip links. | |
[Read Damon Muma on this.](http://whatisdamon.com/blog/?p=247 'Why your ‘Skip to Content’ link might not work') He proposes the following jQuery solution (inspired by [Thompson](http://terrillthompson.com/blog/161 'Terrill Thompson'), fixed by me): | |
```javascript | |
// Apply focus properly when accessing internal links with keyboard in WebKit browsers. | |
$("a[href^='#']").not("a[href]='#'").click(function() { | |
$("#"+$(this).attr("href").slice(1)+"").focus(); | |
}); | |
``` | |
I don’t like to use jQuery however, and have been trying to port it to plain Javascript. | |
### Version history. | |
1. Pilot version. ([d385d2](https://gist.github.com/1900563/d385d26f9903106ba31c3340bac8301508b98d4e)) | |
2. `tabindex` now using `-1` instead of `0`, as per [Smith](http://terrillthompson.com/blog/161#comment-828 'Jared Smith'), added this README, and added UNLICENCE. ([c194df](https://gist.github.com/1900563/c194df813181bd8c101a27167f82e257668e58fa)) | |
3. **Current:** Updates to the README. |
(function(a,b,c){for(b=a.length;b--;)if(a[b].getAttribute('href').substr(0,1)=='#')a[b].onclick=function(c){c=document.getElementById(this.hash.substr(1));c.setAttribute('tabindex','-1');c.focus();c.removeAttribute('tabindex');};})(document.links); |
This is free and unencumbered software released into the public domain. | |
Anyone is free to copy, modify, publish, use, compile, sell, or | |
distribute this software, either in source code form or as a compiled | |
binary, for any purpose, commercial or non-commercial, and by any | |
means. | |
In jurisdictions that recognize copyright laws, the author or authors | |
of this software dedicate any and all copyright interest in the | |
software to the public domain. We make this dedication for the benefit | |
of the public at large and to the detriment of our heirs and | |
successors. We intend this dedication to be an overt act of | |
relinquishment in perpetuity of all present and future rights to this | |
software under copyright law. | |
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, | |
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF | |
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. | |
IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR | |
OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, | |
ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR | |
OTHER DEALINGS IN THE SOFTWARE. | |
For more information, please refer to <http://unlicense.org/> |
I preferred the native javascript version since the jQuery one may interfere with deeplinking "/#/deeplink" syntax because "/" cannot be used as jQuery selector.
@komputist sorry for missing your comment. I’ll try to look into it but I can’t promise anything. It’s easy to bind to an onClick
event and I don’t expect iCab to trigger a JavaScript event because you want to display the longdesc
.
Maybe I can couple this to the onhashchange
event, but no promises.
@komputist sorry for missing your comment. I’ll try to look into it but I can’t promise anything. It’s easy to bind to an onClick
event and I don’t expect iCab to trigger a JavaScript event because you want to display the longdesc
.
Maybe I can couple this to the onhashchange
event, but no promises.
The jQuery solution above doesn't work if the targets are not actual links i.e. if they are not able to accept focus. So I tried your pure JS solution but it interferred with some in-page scrolling I have that also uses fragment identifiers.
In the end I combined both approaches:
$('.skiplinks a').click(function() {
$("#" + $(this).attr("href").slice(1)).attr("tabindex",-1).focus().removeAttr("tabindex");
});
Thank you so much for this, works perfectly for me!
I think this should be included in the HTML5 Boilerplate , it's as important as .visuallyhidden
and chromeframe
, can't believe I didn't realise this was broken sooner.
This breaks the back-button of the browser. More info and fix on WebAIM's e-mail list:
http://webaim.org/discussion/mail_thread?thread=6363
Also, please vote for a webkit fix:
https://bugs.webkit.org/show_bug.cgi?id=116046
https://code.google.com/p/chromium/issues/detail?id=262171
Hi! Would it be possible to extend this method so that links followed from the longdesc attribute or the cite attribute would also change focus? For a Webkit browser that allows you to open @longdesc URLs and @cite URLs, see iCab. http://www.icab.de Longdesc attribute URLs and cite attribute URL are, in iCab, opened via a contextual menu. I have a test page here: http://malform.no/testing/a-demo-of/longdesc-with-hidden-iframe/