Skip to content

Instantly share code, notes, and snippets.

@conor-pwbot
Created January 10, 2023 00:17
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save conor-pwbot/2da1df8e3282a09a8753f8c3ec44591a to your computer and use it in GitHub Desktop.
Save conor-pwbot/2da1df8e3282a09a8753f8c3ec44591a to your computer and use it in GitHub Desktop.
ERROR: Macros with complex values should be enclosed in parentheses
WARNING: Avoid unnecessary line continuations
WARNING: space prohibited between function name and open parenthesis '('
==========
checkpatch - FAILED
WARNING: space prohibited between function name and open parenthesis '('
#52: FILE: arch/riscv/include/asm/insn-def.h:47:
+ .4byte ((\opcode << INSN_I_OPCODE_SHIFT) | \
WARNING: Avoid unnecessary line continuations
#52: FILE: arch/riscv/include/asm/insn-def.h:47:
+ .4byte ((\opcode << INSN_I_OPCODE_SHIFT) | \
ERROR: Macros with complex values should be enclosed in parentheses
#62: FILE: arch/riscv/include/asm/insn-def.h:57:
+#define __INSN_I(...) insn_i __VA_ARGS__
total: 1 errors, 2 warnings, 0 checks, 102 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Commit 7a47348ab322 ("RISC-V: insn-def: Add I-type insn-def") has style problems, please review.
NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment