Skip to content

Instantly share code, notes, and snippets.

@isaacs
Created August 15, 2012 18:29
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save isaacs/3362164 to your computer and use it in GitHub Desktop.
Save isaacs/3362164 to your computer and use it in GitHub Desktop.
From 4fda4ced60357d86f8698dcdec4c319381a47365 Mon Sep 17 00:00:00 2001
From: isaacs <i@izs.me>
Date: Wed, 15 Aug 2012 11:28:52 -0700
Subject: [PATCH] build: Don't set gcc_version for Windows
---
configure | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure b/configure
index 5304730..a801b65 100755
--- a/configure
+++ b/configure
@@ -342,7 +342,7 @@ def configure_node(o):
cc_version, is_clang = compiler_version()
o['variables']['clang'] = 1 if is_clang else 0
- if not is_clang:
+ if not is_clang and cc_version != 0:
o['variables']['gcc_version'] = 10 * cc_version[0] + cc_version[1]
# clang has always supported -fvisibility=hidden, right?
--
1.7.5.4
@saghul
Copy link

saghul commented Aug 15, 2012

You could do:

if not is_clang and cc_version:
    # stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment