Skip to content

Instantly share code, notes, and snippets.

@lholmquist
Created December 20, 2012 20:58
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save lholmquist/4348494 to your computer and use it in GitHub Desktop.
Save lholmquist/4348494 to your computer and use it in GitHub Desktop.

I wonder if we could put the AeroGear.isArray function in the aerogear.core.js file. for some reason i feel like it used to be there

currently it is in the aerogear.utilities.js file which also has the aerogear.ajax function. if some one makes a custom build of just datamanager, which needs the isArray function but not the ajax stuff, they are getting a little bit of extra code that they don't need.

Actually the core file needs the isArray function, and since everything depends on the core, there will be situations where custom builds will get more than they need.

The size difference is proabably trivial, but smaller is better in mobile

@secondsun
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment