Skip to content

Instantly share code, notes, and snippets.

@Habbie
Created April 26, 2013 11:41
Show Gist options
  • Save Habbie/5466724 to your computer and use it in GitHub Desktop.
Save Habbie/5466724 to your computer and use it in GitHub Desktop.
commit 8ac90bda3b21120b09b99b180c7fc57dcdbf272f
Author: Peter van Dijk <peter.van.dijk@netherlabs.nl>
Date: Sat Jan 7 02:30:14 2012 +0100
report serial after AXFR fetch; involves a getDomainInfo call; potential race condition
diff --git a/pdns/slavecommunicator.cc b/pdns/slavecommunicator.cc
index 33bb928..93e23c6 100644
--- a/pdns/slavecommunicator.cc
+++ b/pdns/slavecommunicator.cc
@@ -201,7 +201,11 @@ void CommunicatorClass::suck(const string &domain,const string &remote)
di.backend->commitTransaction();
di.backend->setFresh(domain_id);
- L<<Logger::Error<<"AXFR done for '"<<domain<<"', zone committed"<<endl;
+
+ // grab new serial
+ B->getDomainInfo(domain, di);
+ L<<Logger::Error<<"AXFR done for '"<<domain<<"', serial "<<di.serial<<", zone committed"<<endl;
+
if(::arg().mustDo("slave-renotify"))
notifyDomain(domain);
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment