Skip to content

Instantly share code, notes, and snippets.

@conor-pwbot
Created December 20, 2022 16:03
Show Gist options
  • Save conor-pwbot/60e3dec5d5a8aac1a2bec9369178a46d to your computer and use it in GitHub Desktop.
Save conor-pwbot/60e3dec5d5a8aac1a2bec9369178a46d to your computer and use it in GitHub Desktop.
ERROR: trailing whitespace
WARNING: please write a help paragraph that fully describes the config symbol
==========
checkpatch - FAILED
WARNING: please write a help paragraph that fully describes the config symbol
#31: FILE: arch/riscv/Kconfig:450:
+config TOOLCHAIN_HAS_ZBA
+ bool "Zba extension support for B extension on Address generation"
+ default y
+ depends on !64BIT || $(cc-option,-mabi=lp64 -march=rv64ima_zba)
+ depends on !32BIT || $(cc-option,-mabi=ilp32 -march=rv32ima_zba)
+
WARNING: please write a help paragraph that fully describes the config symbol
#37: FILE: arch/riscv/Kconfig:456:
+config TOOLCHAIN_HAS_ZBB
+ bool "Zbb extension support for B extension on Basic bit-manipulation"
+ default y
+ depends on !64BIT || $(cc-option,-mabi=lp64 -march=rv64ima_zbb)
+ depends on !32BIT || $(cc-option,-mabi=ilp32 -march=rv32ima_zbb)
+
WARNING: please write a help paragraph that fully describes the config symbol
#43: FILE: arch/riscv/Kconfig:462:
+config TOOLCHAIN_HAS_ZBC
+ bool "Zbc extension support for B extension on Carry-less multiplication"
+ default y
+ depends on !64BIT || $(cc-option,-mabi=lp64 -march=rv64ima_zbc)
+ depends on !32BIT || $(cc-option,-mabi=ilp32 -march=rv32ima_zbc)
+
WARNING: please write a help paragraph that fully describes the config symbol
#49: FILE: arch/riscv/Kconfig:468:
+config TOOLCHAIN_HAS_ZBS
+ bool "Zbs extension support for B extension on single-bit instruction"
+ default y
+ depends on !64BIT || $(cc-option,-mabi=lp64 -march=rv64ima_zbs)
+ depends on !32BIT || $(cc-option,-mabi=ilp32 -march=rv32ima_zbs)
+
ERROR: trailing whitespace
#66: FILE: arch/riscv/Makefile:64:
+# Check if the toolchain supports ratified B extensions $
total: 1 errors, 4 warnings, 0 checks, 72 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile
Commit 64f12d85a016 ("arch/riscv : Add support for Zba/Zbb/Zbc/Zbs ext in ISA realization") has style problems, please review.
NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment