gistfile1.irclog

Jan 28 16:20:32 <galderz>  i wanted to ask you about : ISPN-2752
Jan 28 16:20:36 <galderz>	https://issues.jboss.org/browse/ISPN-2752
Jan 28 16:22:00 <galderz>	from what I understand: as a resut of a new view you're sending a command, but this command is failing in another node cos the node is closing down...
Jan 28 16:22:46 <galderz>	note that it's a request's response where the exception is being sent
Jan 28 16:23:34 <galderz>	it's a pity that the exception is so generic
Jan 28 16:33:14 <galderz>	actually, we should probably include this within ISPN-2577?
Jan 28 17:14:19 <dberindei>	they're related, but I'm not sure if the solution is the same
Jan 28 17:14:59 <galderz>	i agree, but it's part of the work to silence shutdown/suspect related issues
Jan 28 17:15:28 <dberindei>	I think the main problem with ISPN-2572 is that we don't have a simple way to check if the cache is shutting down
Jan 28 17:16:15 <dberindei>	instead each component has to keep track of that, and most of the time they don't
Jan 28 17:16:16 <galderz>	you have cache status, is that not enough?
Jan 28 17:18:44 <dberindei>	how do you get a hold of that?
Jan 28 17:18:58 <dberindei>	is there a cache.getStatus() method?
Jan 28 17:19:16 <dberindei>	actually I just looked at the code and we can't really use that
Jan 28 17:19:58 <dberindei>	GroupRequest automatically sends a response with the IllegalStateException for each outstanding request during shutdown
Jan 28 17:20:58 <dberindei>	so there's nothing we can do on the node that's shutting down... unless we can somehow delay the shutdown until we have finished processing all the outstanding requests
Jan 28 17:21:12 <galderz>	dberindei, yeah, hence i was saying that it's a shame we cannot filter by type of exception
Jan 28 17:21:34 <dberindei>	our code could just well throw an IllegalStateException...
Jan 28 17:21:38 <galderz>	instead of IllegalStateE, something like: shuttingdownexceotion…etc
Jan 28 17:21:48 <galderz>	from JGroups
Jan 28 17:21:53 <dberindei>	ah right, you were saying the same thing
Jan 28 17:22:05 <galderz>	but that requires a JGroups code change
Jan 28 17:22:23 <galderz>	i don;t wanna start filtering by the exception message - it's bound to break
Jan 28 17:22:24 <dberindei>	well, we already extend the RpcDispatcher, maybe we could extend GroupRequest as well
Jan 28 17:22:40 <dberindei>	agree re: filtering by exception message