desc

CHECK: Alignment should match open parenthesis
CHECK: No space is necessary after a cast
CHECK: Unnecessary parentheses around v->counter
ERROR: "foo * bar" should be "foo *bar"
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that ';' (ctx:VxV)
WARNING: Prefer using '"%s...", __func__' to using '__xchg_local', this function's name, in a string
WARNING: Prefer using '"%s...", __func__' to using '__xchg_relaxed', this function's name, in a string
WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
WARNING: line length of 102 exceeds 100 columns

retcode

1

summary

==========
checkpatch - FAILED

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#96: FILE: arch/arm/include/asm/cmpxchg.h:28:
+static inline unsigned long __arch_xchg(unsigned long x, volatile void *ptr, int size)

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#149: FILE: arch/hexagon/include/asm/cmpxchg.h:22:
+static inline unsigned long __arch_xchg(unsigned long x, volatile void *ptr,

CHECK: Alignment should match open parenthesis
#150: FILE: arch/hexagon/include/asm/cmpxchg.h:23:
+static inline unsigned long __arch_xchg(unsigned long x, volatile void *ptr,
 				   int size)

CHECK: No space is necessary after a cast
#171: FILE: arch/ia64/include/asm/cmpxchg.h:8:
+({(__typeof__(*(ptr))) __arch_xchg((unsigned long) (x), (ptr), sizeof(*(ptr)));})

ERROR: space required after that ';' (ctx:VxV)
#171: FILE: arch/ia64/include/asm/cmpxchg.h:8:
+({(__typeof__(*(ptr))) __arch_xchg((unsigned long) (x), (ptr), sizeof(*(ptr)));})
                                                                               ^

CHECK: No space is necessary after a cast
#193: FILE: arch/ia64/include/uapi/asm/cmpxchg.h:58:
+({(__typeof__(*(ptr))) __arch_xchg((unsigned long) (x), (ptr), sizeof(*(ptr)));})

ERROR: space required after that ';' (ctx:VxV)
#193: FILE: arch/ia64/include/uapi/asm/cmpxchg.h:58:
+({(__typeof__(*(ptr))) __arch_xchg((unsigned long) (x), (ptr), sizeof(*(ptr)));})
                                                                               ^

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#206: FILE: arch/loongarch/include/asm/cmpxchg.h:65:
+__arch_xchg(volatile void *ptr, unsigned long x, int size)

ERROR: "foo * bar" should be "foo *bar"
#228: FILE: arch/m68k/include/asm/cmpxchg.h:12:
+static inline unsigned long __arch_xchg(unsigned long x, volatile void * ptr, int size)

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#228: FILE: arch/m68k/include/asm/cmpxchg.h:12:
+static inline unsigned long __arch_xchg(unsigned long x, volatile void * ptr, int size)

ERROR: "foo * bar" should be "foo *bar"
#237: FILE: arch/m68k/include/asm/cmpxchg.h:43:
+static inline unsigned long __arch_xchg(unsigned long x, volatile void * ptr, int size)

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#237: FILE: arch/m68k/include/asm/cmpxchg.h:43:
+static inline unsigned long __arch_xchg(unsigned long x, volatile void * ptr, int size)

WARNING: line length of 102 exceeds 100 columns
#246: FILE: arch/m68k/include/asm/cmpxchg.h:78:
+#define arch_xchg(ptr,x) ({(__typeof__(*(ptr)))__arch_xchg((unsigned long)(x),(ptr),sizeof(*(ptr)));})

ERROR: space required after that ',' (ctx:VxV)
#246: FILE: arch/m68k/include/asm/cmpxchg.h:78:
+#define arch_xchg(ptr,x) ({(__typeof__(*(ptr)))__arch_xchg((unsigned long)(x),(ptr),sizeof(*(ptr)));})
                      ^

ERROR: space required after that ',' (ctx:VxV)
#246: FILE: arch/m68k/include/asm/cmpxchg.h:78:
+#define arch_xchg(ptr,x) ({(__typeof__(*(ptr)))__arch_xchg((unsigned long)(x),(ptr),sizeof(*(ptr)));})
                                                                              ^

ERROR: space required after that ',' (ctx:VxV)
#246: FILE: arch/m68k/include/asm/cmpxchg.h:78:
+#define arch_xchg(ptr,x) ({(__typeof__(*(ptr)))__arch_xchg((unsigned long)(x),(ptr),sizeof(*(ptr)));})
                                                                                    ^

ERROR: space required after that ';' (ctx:VxV)
#246: FILE: arch/m68k/include/asm/cmpxchg.h:78:
+#define arch_xchg(ptr,x) ({(__typeof__(*(ptr)))__arch_xchg((unsigned long)(x),(ptr),sizeof(*(ptr)));})
                                                                                                    ^

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#259: FILE: arch/mips/include/asm/cmpxchg.h:71:
+unsigned long __arch_xchg(volatile void *ptr, unsigned long x, int size)

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#281: FILE: arch/openrisc/include/asm/cmpxchg.h:150:
+static inline unsigned long __arch_xchg(volatile void *ptr, unsigned long with,

CHECK: Alignment should match open parenthesis
#282: FILE: arch/openrisc/include/asm/cmpxchg.h:151:
+static inline unsigned long __arch_xchg(volatile void *ptr, unsigned long with,
 		int size)

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#303: FILE: arch/parisc/include/asm/cmpxchg.h:25:
+__arch_xchg(unsigned long x, volatile void *ptr, int size)

WARNING: Prefer using '"%s...", __func__' to using '__xchg_local', this function's name, in a string
#325: FILE: arch/powerpc/include/asm/cmpxchg.h:232:
+	BUILD_BUG_ON_MSG(1, "Unsupported size for __xchg_local");

WARNING: Prefer using '"%s...", __func__' to using '__xchg_relaxed', this function's name, in a string
#334: FILE: arch/powerpc/include/asm/cmpxchg.h:251:
+	BUILD_BUG_ON_MSG(1, "Unsupported size for __xchg_relaxed");

CHECK: Unnecessary parentheses around v->counter
#347: FILE: arch/riscv/include/asm/atomic.h:264:
+	return __arch_xchg(&(v->counter), n, size);			\

CHECK: Alignment should match open parenthesis
#383: FILE: arch/s390/include/asm/cmpxchg.h:18:
+static __always_inline unsigned long __arch_xchg(unsigned long x,
 					    unsigned long address, int size)

ERROR: space required after that ',' (ctx:VxV)
#413: FILE: arch/sh/include/asm/cmpxchg.h:49:
+	((__typeof__(*(ptr)))__arch_xchg((ptr),(unsigned long)(x), sizeof(*(ptr))))
 	                                      ^

ERROR: "foo * bar" should be "foo *bar"
#426: FILE: arch/sparc/include/asm/cmpxchg_32.h:18:
+static inline unsigned long __arch_xchg(unsigned long x, __volatile__ void * ptr, int size)

WARNING: line length of 102 exceeds 100 columns
#435: FILE: arch/sparc/include/asm/cmpxchg_32.h:28:
+#define arch_xchg(ptr,x) ({(__typeof__(*(ptr)))__arch_xchg((unsigned long)(x),(ptr),sizeof(*(ptr)));})

ERROR: space required after that ',' (ctx:VxV)
#435: FILE: arch/sparc/include/asm/cmpxchg_32.h:28:
+#define arch_xchg(ptr,x) ({(__typeof__(*(ptr)))__arch_xchg((unsigned long)(x),(ptr),sizeof(*(ptr)));})
                      ^

ERROR: space required after that ',' (ctx:VxV)
#435: FILE: arch/sparc/include/asm/cmpxchg_32.h:28:
+#define arch_xchg(ptr,x) ({(__typeof__(*(ptr)))__arch_xchg((unsigned long)(x),(ptr),sizeof(*(ptr)));})
                                                                              ^

ERROR: space required after that ',' (ctx:VxV)
#435: FILE: arch/sparc/include/asm/cmpxchg_32.h:28:
+#define arch_xchg(ptr,x) ({(__typeof__(*(ptr)))__arch_xchg((unsigned long)(x),(ptr),sizeof(*(ptr)));})
                                                                                    ^

ERROR: space required after that ';' (ctx:VxV)
#435: FILE: arch/sparc/include/asm/cmpxchg_32.h:28:
+#define arch_xchg(ptr,x) ({(__typeof__(*(ptr)))__arch_xchg((unsigned long)(x),(ptr),sizeof(*(ptr)));})
                                                                                                    ^

ERROR: "foo * bar" should be "foo *bar"
#457: FILE: arch/sparc/include/asm/cmpxchg_64.h:90:
+static inline unsigned long __arch_xchg(unsigned long x, __volatile__ void * ptr,

CHECK: Alignment should match open parenthesis
#458: FILE: arch/sparc/include/asm/cmpxchg_64.h:91:
+static inline unsigned long __arch_xchg(unsigned long x, __volatile__ void * ptr,
 				       int size)

ERROR: space required after that ',' (ctx:VxV)
#470: FILE: arch/xtensa/include/asm/cmpxchg.h:173:
+	((__typeof__(*(ptr)))__arch_xchg((unsigned long)(x),(ptr),sizeof(*(ptr))))
 	                                                   ^

ERROR: space required after that ',' (ctx:VxV)
#470: FILE: arch/xtensa/include/asm/cmpxchg.h:173:
+	((__typeof__(*(ptr)))__arch_xchg((unsigned long)(x),(ptr),sizeof(*(ptr))))
 	                                                         ^

ERROR: "foo * bar" should be "foo *bar"
#479: FILE: arch/xtensa/include/asm/cmpxchg.h:206:
+__arch_xchg(unsigned long x, volatile void * ptr, int size)

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#479: FILE: arch/xtensa/include/asm/cmpxchg.h:206:
+__arch_xchg(unsigned long x, volatile void * ptr, int size)

total: 18 errors, 13 warnings, 7 checks, 328 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit a783d7a775bd ("arch: rename all internal names __xchg to __arch_xchg") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.