Trott

'use strict';
require('../common');

const assert = require('assert');

assert(!Object.keys(global).includes('global'),
       'global should be non-enumerable');

Trott

In test/parallel/test-os.js:

• Two instances of == that are better as ===
• Several instances of .indexOf() that can be rewritten using .includes() for more clarity
• Bonus optional change: The os module has an undocumented and deprecated function os.getNetworkInterfaces() that is not tested at all. Write a minimal test for it.

Trott

• If you don't already have one, create a GitHub account

---

• Open the Node.js core repository (https://github.com/nodejs/node)

---

• Use the "Fork" button to fork the repository:

Trott

/Users/trott/io.js/lib/_debugger.js
   190:31  error  Expected '===' and instead saw '=='  eqeqeq
   205:24  error  Expected '===' and instead saw '=='  eqeqeq
   215:24  error  Expected '===' and instead saw '=='  eqeqeq
   221:41  error  Expected '===' and instead saw '=='  eqeqeq
   225:41  error  Expected '===' and instead saw '=='  eqeqeq
   229:41  error  Expected '===' and instead saw '=='  eqeqeq
   233:41  error  Expected '===' and instead saw '=='  eqeqeq
   331:25  error  Expected '===' and instead saw '=='  eqeqeq

Trott

'use strict';
var assert = require('assert');
var tls = require('tls');

var net = require('net');
var fs = require('fs');

var options = {
  key: fs.readFileSync(__dirname + '/../fixtures/keys/agent1-key.pem'),
  cert: fs.readFileSync(__dirname + '/../fixtures/keys/agent1-cert.pem')

Trott

'use strict';
var assert = require('assert');

var tls = require('tls');

var net = require('net');
var fs = require('fs');

var options = {
  key: fs.readFileSync('/Users/trott/io.js/test/fixtures/keys/agent1-key.pem'),

Trott

Releases wishlist:

• LTS release candidates as opposed to just release candidates for semver major releases (@brycebaril, @codepilot)

• Nightlies with a unique identifier in the version (@codepilot)

• Release candidates ought to be release candidates (@trott)

• Need for a 5.x.x-staging branch and a 6.x.x-staging branch (@brycebaril)

Trott

./node tools/eslint/bin/eslint.js src lib test tools/eslint-rules \
		--rulesdir tools/eslint-rules --quiet

/Users/trott/io.js/lib/_tls_common.js
   63:16  error  "i" is already defined    no-redeclare
   76:16  error  "i" is already defined    no-redeclare
  111:16  error  "i" is already defined    no-redeclare
  111:23  error  "len" is already defined  no-redeclare

/Users/trott/io.js/lib/buffer.js

Trott

'use strict';
const util = require('util');
const EventEmitter = require('events');

function MyEventEmitter() {
  EventEmitter.call(this);
}

// Inherit functions from `EventEmitter`'s prototype
util.inherits(MyEventEmitter, EventEmitter);

Trott

'use strict';
var assert = require('assert');

// Here we are testing the HTTP server module's flood prevention mechanism.
// When writeable.write returns false (ie the underlying send() indicated the
// native buffer is full), the HTTP server cork()s the readable part of the
// stream. This means that new requests will not be read (however request which
// have already been read, but are awaiting processing will still be
// processed).