andreastt

% cat dist/include/nsIRemoteAgent.h 
/*
 * DO NOT EDIT.  THIS FILE IS GENERATED FROM /home/ato/src/gecko/remote/nsIRemoteAgent.idl
 */

#ifndef __gen_nsIRemoteAgent_h__
#define __gen_nsIRemoteAgent_h__


#ifndef __gen_nsISupports_h__

andreastt

 0:07.71 xpcom/build
 0:08.46 In file included from /home/ato/src/gecko/xpcom/base/nsCOMPtr.h:30,
 0:08.46                  from /home/ato/src/gecko/obj-x86_64-pc-linux-gnu/dist/include/mozilla/Services.h:7,
 0:08.46                  from Services.cpp:4:
 0:08.46 Services.cpp: In function ‘void mozilla::services::Shutdown()’:
 0:08.46 /home/ato/src/gecko/xpcom/base/nsISupportsUtils.h:94:13: error: invalid use of incomplete type ‘class nsIRemoteAgent’
 0:08.46        (_ptr)->Release();    \
 0:08.46              ^~
 0:08.46 Services.cpp:591:3: note: in expansion of macro ‘NS_IF_RELEASE’
 0:08.46    NS_IF_RELEASE(gRemoteAgent);

andreastt

diff --git a/remote/RemoteAgent.jsm b/remote/RemoteAgent.jsm
index a87000c6c644..a9d561958b1e 100644
--- a/remote/RemoteAgent.jsm
+++ b/remote/RemoteAgent.jsm
@@ -223,7 +223,10 @@ class RemoteAgentClass {
   // XPCOM
 
   get QueryInterface() {
-    return ChromeUtils.generateQI([Ci.nsICommandLineHandler]);
+    return ChromeUtils.generateQI([

andreastt

geckodriver v0.26.0-alpha.0 (/home/ato/src/gecko/testing/geckodriver)
├── base64 v0.10.1
│   └── byteorder v1.3.1
├── chrono v0.4.6
│   ├── num-integer v0.1.39
│   │   └── num-traits v0.2.6
│   ├── num-traits v0.2.6 (*)
│   └── time v0.1.40
│       └── libc v0.2.60
│       [dev-dependencies]

andreastt

% git diff Cargo.toml
diff --git a/testing/mozbase/rust/mozrunner/Cargo.toml b/testing/mozbase/rust/mozrunner/Cargo.toml
index 2dd6e04a6b0d..f24a32dd80d6 100644
--- a/testing/mozbase/rust/mozrunner/Cargo.toml
+++ b/testing/mozbase/rust/mozrunner/Cargo.toml
@@ -8,7 +8,7 @@ license = "MPL-2.0"
 
 [dependencies]
 log = "0.4"
-mozprofile = { path = "../mozprofile" }

andreastt

% cd src/gecko/testing/webdriver
% cargo publish
    Updating `/home/ato/src/gecko/third_party/rust` index
error: failed to update dir /home/ato/src/gecko/third_party/rust

Caused by:
  failed to fetch `file:///home/ato/src/gecko/third_party/rust`

Caused by:
  could not find repository from '/home/ato/src/gecko/third_party/rust'; class=Repository (6)

andreastt

% ./mach lint -funix remote/
New python executable in /home/ato/src/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init/bin/python2.7
Not overwriting existing python script /home/ato/src/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init/bin/python (you must use /home/ato/src/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init/bin/python2.7)
Installing setuptools, pip, wheel...done.
running build_ext
copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil

Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
pulling from https://hg.mozilla.org/l10n/gecko-strings

andreastt

error: environment variable `MOZ_TOPOBJDIR` not defined
  --> modules/libpref/init/static_prefs/src/lib.rs:11:18
   |
11 | include!(concat!(env!("MOZ_TOPOBJDIR"), "/modules/libpref/static_prefs.rs"));
   |                  ^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

error: Could not compile `static_prefs`.

andreastt

diff --git a/testing/geckodriver/marionette/src/result.rs b/testing/geckodriver/marionette/src/result.rs
index 72fec8d67cba..3b04217a4c20 100644
--- a/testing/geckodriver/marionette/src/result.rs
+++ b/testing/geckodriver/marionette/src/result.rs
@@ -1,4 +1,4 @@
-use serde::{Deserialize, Deserializer, Serialize, Serializer};
+use serde::{de, Deserialize, Deserializer, Serialize, Serializer};
 use serde_json::Value;
 
 use crate::common::{Cookie, Timeouts, WebElement};

andreastt

fn from_value<'de, D, T>(deserializer: D) -> Result<T, D::Error>
where 
    D: Deserializer<'de>,
    T: serde::de::DeserializeOwned,
{
    #[derive(Debug, Deserialize)]
    struct Wrapper<T> {
        value: T,
    }
    let val = Wrapper::deserialize(deserializer)