archshift

if (itr == m_functions.end() || itr->second.func == nullptr) {
            std::string error = "unknown/unimplemented function '%s': port=%s";
            for (int i = 1; i <= num_params; ++i) {
                error += Common::StringFromFormat(", cmd_buff[%i]=%u", i, cmd_buff[i]);
            }

            std::string name;
            if (itr == m_functions.end())
                name = Common::StringFromFormat("0x%08X", cmd_buff[0]);
            else

archshift

[01:11:45]  <sdsf>	I just submitted my task
[01:11:55]  <sdsf>	I want to know what timezones do you guys live in
[01:12:04]  <guiand>	patience :)
[01:12:07]  <unicodesnowman>	sdsf, mentors don't check GCI all the time
[01:12:13]  <guiand>	your task will be reviewed eventually
[01:12:22]  <unicodesnowman>	they have jobs, other things to do, etc
[01:12:30]  <sdsf>	I want to have an idea about when I should submit the tasks before u guys sleep
[01:12:40]  <guiand>	patience is part of the beauty of open-source
[01:12:51]  <guiand>	you have to learn to submit and forget
[01:12:51]  <harsz89>	sdsf, normally we are living in different time zones

archshift

diff --git a/src/core/file_sys/directory_sdmc.cpp b/src/core/file_sys/directory_sdmc.cpp
index 60a197c..6374e5b 100644
--- a/src/core/file_sys/directory_sdmc.cpp
+++ b/src/core/file_sys/directory_sdmc.cpp
@@ -44,12 +44,7 @@ u32 Directory_SDMC::Read(const u32 count, Entry* entries) {
 
         WARN_LOG(FILESYS, "File %s: size=%llu dir=%d", filename.c_str(), file.size, file.isDirectory);
 
-        // TODO(Link Mauve): use a proper conversion to UTF-16.
-        for (size_t j = 0; j < FILENAME_LENGTH; ++j) {

archshift

diff --git a/src/core/file_sys/directory_sdmc.cpp b/src/core/file_sys/directory_sdmc.cpp
index 60a197c..4fd6469 100644
--- a/src/core/file_sys/directory_sdmc.cpp
+++ b/src/core/file_sys/directory_sdmc.cpp
@@ -44,12 +44,11 @@ u32 Directory_SDMC::Read(const u32 count, Entry* entries) {
 
         WARN_LOG(FILESYS, "File %s: size=%llu dir=%d", filename.c_str(), file.size, file.isDirectory);
 
-        // TODO(Link Mauve): use a proper conversion to UTF-16.
-        for (size_t j = 0; j < FILENAME_LENGTH; ++j) {

archshift

diff --git a/src/core/hle/kernel/archive.cpp b/src/core/hle/kernel/archive.cpp
index 647f0de..2e6c73b 100644
--- a/src/core/hle/kernel/archive.cpp
+++ b/src/core/hle/kernel/archive.cpp
@@ -178,7 +178,7 @@ public:
         case FileCommand::Close:
         {
             DEBUG_LOG(KERNEL, "Close %s %s", GetTypeName().c_str(), GetName().c_str());
-            Kernel::g_object_pool.Destroy<File>(GetHandle());
+            Kernel::g_object_pool.Destroy(GetHandle());

archshift

[22:30:46]  <archshift>	because as it stands it's literally closing the service itself
[22:30:51]  <yuriks>	yeah
[22:30:52]  <yuriks>	that's wrong
[22:33:13]  <yuriks>	that, the handles thing and processes are three reforms in the kernel I wanted to make

archshift

diff --git a/src/core/hle/kernel/archive.cpp b/src/core/hle/kernel/archive.cpp
index 647f0de..2e6c73b 100644
--- a/src/core/hle/kernel/archive.cpp
+++ b/src/core/hle/kernel/archive.cpp
@@ -178,7 +178,7 @@ public:
         case FileCommand::Close:
         {
             DEBUG_LOG(KERNEL, "Close %s %s", GetTypeName().c_str(), GetName().c_str());
-            Kernel::g_object_pool.Destroy<File>(GetHandle());
+            Kernel::g_object_pool.Destroy(GetHandle());

archshift

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 05a5604..4e37a69 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -69,6 +69,8 @@ if (ENABLE_GLFW)
     else()
         if (NOT APPLE)
             find_package(X11 REQUIRED)
+        else()
+            find_library(QUARTZCORE_LIBRARY QuartzCore)

archshift

/core/hle/service/fs_user.cpp:58 D[KERNEL] OpenFile: path=[Wchar: ⼀一椀渀琀攀渀搀漀 ㌀䐀匀⼀倀爀椀瘀愀琀攀⼀　　　㈀　㐀　　⼀瀀栀琀挀愀挀栀攀⸀戀椀渀], mode=1 attrs=0
/core/file_sys/archive_sdmc.cpp:53 D[FileSys] OpenFile: called path=[Wchar: ⼀一椀渀琀攀渀搀漀 ㌀䐀匀⼀倀爀椀瘀愀琀攀⼀　　　㈀　㐀　　⼀瀀栀琀挀愀挀栀攀⸀戀椀渀] mode=1
/core/file_sys/file_sdmc.cpp:36 E[FileSys] Open: Non-existing file /Users/gandrade-air/.citra-emu/sdmc/⼀一椀渀琀攀渀搀漀 ㌀䐀匀⼀倀爀椀瘀愀琀攀⼀　　　㈀　㐀　　⼀瀀栀琀挀愀挀栀攀⸀戀椀渀 can’t be open without mode create.
/core/hle/service/fs_user.cpp:65 E[KERNEL] OpenFile: failed to get a handle for file [Wchar: ⼀一椀渀琀攀渀搀漀 ㌀䐀匀⼀倀爀椀瘀愀琀攀⼀　　　㈀　㐀　　⼀瀀栀琀挀愀挀栀攀⸀戀椀渀]
/core/hle/service/fs_user.cpp:68 D[KERNEL] OpenFile: called
/core/hle/svc.cpp:98 D[SVC] SendSyncRequest: called handle=0x0000011C(fs:USER)
/core/hle/service/fs_user.cpp:324 D[KERNEL] OpenDirectory: type=4 size=12 data=[Wchar: ⼀䐀䌀䤀䴀]
/core/file_sys/archive_sdmc.cpp:101 D[FileSys] OpenDirectory: called path=[Wchar: ⼀䐀䌀䤀䴀]
/common/file_util.cpp:92 W[COMMON] IsDirectory: IsDirectory: stat failed on /Users/gandrade-air/.citra-emu/sdmc/⼀䐀䌀䤀䴀: No such 

archshift

0000000 31 55 4a 51 30 30 5f 31 01 00 00 00 b8 0b 01 00
0000010 00 00 00 00 d2 fb 18 00 00 00 00 00 00 00 00 00
0000020 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
*
006f550 00 00 00 00 00 00 00 00                        
006f558