arlolra

From 36310504086eac9d4575b5baedd25de298d17dde Mon Sep 17 00:00:00 2001
From: Arlo Breault <abreault@wikimedia.org>
Date: Wed, 14 Jan 2015 14:03:26 -0800
Subject: [PATCH] Added performance instrumentation to routes.js and
 mediawiki.SelectiveSerializer.js. Also added node-txstatsd wrapper to
 mediawiki.Util.js and node-txstatsd version to package.json

Change-Id: I973d8379816b8bebe7fc6794f4cde0ca117198a9
---
 api/routes.js                        | 12 +++++++-

arlolra

diff --git a/lib/ext.core.AttributeExpander.js b/lib/ext.core.AttributeExpander.js
index c0bdc53..c53f49f 100644
--- a/lib/ext.core.AttributeExpander.js
+++ b/lib/ext.core.AttributeExpander.js
@@ -19,13 +19,11 @@ var KV = defines.KV,
  * transclusions, etc. and returns the content.
  * ---------------------------------------------------------- */
 function stripMetaTags( tokens, wrapTemplates ) {
-	var isPushed = false, buf = [],
-		hasGeneratedContent = false;

arlolra

GWicke added a comment.

One issue with the format above (especially for GETs) is that we don't have a content type for the HTML & data-parsoid. This is important, as the content-type also indicates the spec version that parsoid currently emits, which we really need to track in the database.

To fix this, I have been thinking about a more generic framing structure for multi-part responses more along the lines of `multi-part/form-data`:

```
{
headers: {
'content-type': 'text/html;profile=mediawiki.org/specs/html/1.0.0'

arlolra

[warning][worker][7312] shutting down
[info][master][15116] shutting down, killing workers
[warning][worker][16223] shutting down
[warning][worker][19209] shutting down
[warning][worker][15130] shutting down
[warning][worker][24715] shutting down
[warning][worker][31151] shutting down
[warning][worker][744] shutting down
[warning][worker][15133] shutting down
[warning][worker][31544] shutting down

arlolra

# HG changeset patch
# User Arlo Breault <arlolra@gmail.com>
# Date 1414370632 25200
#      Sun Oct 26 17:43:52 2014 -0700
# Node ID dc8fd5bdcfede981cef6289203626f9bd83bf9b9
# Parent  030063bcb41284997f862b9b2d12e93bfc0b121a
Test

diff --git a/chat/components/src/imConversations.js b/chat/components/src/imConversations.js
--- a/chat/components/src/imConversations.js

arlolra

diff --git a/chat/components/src/test/test_conversations.js b/chat/components/src/test/test_conversations.js
new file mode 100644
--- /dev/null
+++ b/chat/components/src/test/test_conversations.js
@@ -0,0 +1,63 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+const { interfaces: Ci, utils: Cu } = Components;

arlolra

diff --git a/chat/components/src/test/xpcshell.ini b/chat/components/src/test/xpcshell.ini
--- a/chat/components/src/test/xpcshell.ini
+++ b/chat/components/src/test/xpcshell.ini
@@ -3,9 +3,10 @@
 ; file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 [DEFAULT]
 head = 
 tail = 
 

arlolra

ssh -v sergii
OpenSSH_6.2p2, OSSLShim 0.9.8r 8 Dec 2011
debug1: Reading configuration data /Users/arlolra/.ssh/config
debug1: /Users/arlolra/.ssh/config line 1: Applying options for *
debug1: /Users/arlolra/.ssh/config line 18: Applying options for sergii
debug1: Reading configuration data /etc/ssh_config
debug1: /etc/ssh_config line 20: Applying options for *
debug1: /etc/ssh_config line 102: Applying options for *
debug1: Executing proxy command: exec ssh -a -W sergii.torproject.org:22 perdulce.torproject.org
debug1: identity file /Users/arlolra/.ssh/id_rsa type 1

arlolra

Timestamp: 2014-10-23, 10:57:32 AM
Error: uncaught exception: Adding chat buddy flo-retina twice?!

Timestamp: 2014-10-23, 10:57:34 AM
Error: TypeError: this.linkedTabPanel is undefined
Source File: chrome://instantbird/content/tabbrowser.xml
Line: 2101

Timestamp: 2014-10-23, 10:57:34 AM
Error: TypeError: invalid 'in' operand this.selectedPanel

arlolra

require("prfun");

var request = Promise.promisify(require('request'), true);

var HOURS = 24 * 60 * 60 * 1000;

var opts = {
  method: "post",
  url: "https://logstash.wikimedia.org/logstash-2014.10.17/_search"
  auth: {