Things to look for when reviewing cookbook pull requests (examples are linked where explanation is necessary):
-
Attributes should be preferred over literals in resource properties
-
ChefSpec unit tests are included for any logic branches in recipes
-
Any plain Ruby is defined as a library method with rspec unit tests