Austin austinbv

## pulls_are_broken.md

      
              1 file
            
          
              0 forks
            
          
              4 comments
            
          
              0 stars
            
          
                austinbv
                / pulls_are_broken.md
            
            
              Created
              August 24, 2012 00:40
            
          
    Why I am tired of writing pull requests

I am sick of writing pull requests.  GitHub is an awesome place but it facilites a level of douchebaggery that was only reserved for the neckyist of neck beards.  I have only written a few pulls (maybe 20) in the past few years I have been using GitHub and yet to have one accepted.  Now I don't think it's because my pulls are bad, actually I am quite fond, normally tested feature additions or security patches to make the opensource projects I love the most... better.
Heres what happens to pull requests in my experience:

you first find something that needs fixing
you write a test to reproduce the problem
you pass the test
you push the code to github and wait


## app.js
var express = require('express')
  , http = require('http')
  , path = require('path');

var app = express()
  , io = require('socket.io').listen(app);

app.configure(function(){
  app.set('port', process.env.PORT || 3000);
  app.set('views', __dirname + '/views');

## x.js
function f() {
  setTimeout(f, 1000);
};

## superDu.ino
#include <Servo.h>
#include <SoftwareSerial.h>

char messageBuffer[12], cmd[3], pin[3], val[4], aux[4];
boolean debug = false;
int index = 0;
Servo servo;
SoftwareSerial mySerial(10, 11);


## mocha_server.js
fs = require('fs');
require('coffee-script');
process.env.NODE_ENV = 'test';

/**
 * Module dependencies.
 */

var express = require('express'),
  stylus = require('stylus'),

## gist:3157096
* {
-webkit-user-select:none;
-moz-user-select:none;
-ms-user-select:none;
user-select:none;
}

body {
background-image:0 99% 99%;
-webkit-background-size:80px 80px;

## gist:3157076
<body><div class="fridge">
  <div class="logo">Fridge</div>
  <div class="reflection"></div>
  <div class="handle">
    <span>Austin Vance</span>
  </div>
  <div class="shadow"></div>
</div></body>

## error
) Wordlist .getNouns should call a callback with the response:
     Error: done() called multiple times
      at multiple (/Users/austinbv/Dropbox/Documents/Sites/poet_app/node_modules/mocha/lib/runnable.js:152:31)
      at done (/Users/austinbv/Dropbox/Documents/Sites/poet_app/node_modules/mocha/lib/runnable.js:158:26)
      at Runnable.run.duration (/Users/austinbv/Dropbox/Documents/Sites/poet_app/node_modules/mocha/lib/runnable.js:174:9)
      at expect.have.been.calledWith.id (/Users/austinbv/Dropbox/Documents/Sites/poet_app/test/word_spec.coffee:44:11)
      at Word.getNouns (/Users/austinbv/Dropbox/Documents/Sites/poet_app/models/word.coffee:34:18)
      at process.startup.processNextTick.process._tickCallback (node.js:244:9)

  2) Wordlist .getNouns should call a callback with the response:

## gist:3126243
> sinon = require('sinon');
> sinon.useFakeXMLHttpRequest();
TypeError: Object #<Object> has no method 'useFakeXMLHttpRequest'
    at repl:1:7
    at REPLServer.self.eval (repl.js:111:21)
    at rli.on.e (repl.js:260:20)
    at REPLServer.self.eval (repl.js:118:5)
    at Interface.<anonymous> (repl.js:250:12)
    at Interface.EventEmitter.emit (events.js:88:17)
    at Interface._onLine (readline.js:183:10)

## output
✖ 1 of 3 tests failed:

  1) Wordlist should throw if no api key is defined:
     expected [Function] to throw Error but a Error was thrown
	var express = require('express')
	, http = require('http')
	, path = require('path');

	var app = express()
	, io = require('socket.io').listen(app);

	app.configure(function(){
	app.set('port', process.env.PORT \|\| 3000);
	app.set('views', __dirname + '/views');
	#include <Servo.h>
	#include <SoftwareSerial.h>

	char messageBuffer[12], cmd[3], pin[3], val[4], aux[4];
	boolean debug = false;
	int index = 0;
	Servo servo;
	SoftwareSerial mySerial(10, 11);
	fs = require('fs');
	require('coffee-script');
	process.env.NODE_ENV = 'test';

	/**
	* Module dependencies.
	*/

	var express = require('express'),
	stylus = require('stylus'),
	* {
	-webkit-user-select:none;
	-moz-user-select:none;
	-ms-user-select:none;
	user-select:none;
	}

	body {
	background-image:0 99% 99%;
	-webkit-background-size:80px 80px;
	<body><div class="fridge">
	<div class="logo">Fridge</div>
	<div class="reflection"></div>
	<div class="handle">
	<span>Austin Vance</span>
	</div>
	<div class="shadow"></div>
	</div></body>
	) Wordlist .getNouns should call a callback with the response:
	Error: done() called multiple times
	at multiple (/Users/austinbv/Dropbox/Documents/Sites/poet_app/node_modules/mocha/lib/runnable.js:152:31)
	at done (/Users/austinbv/Dropbox/Documents/Sites/poet_app/node_modules/mocha/lib/runnable.js:158:26)
	at Runnable.run.duration (/Users/austinbv/Dropbox/Documents/Sites/poet_app/node_modules/mocha/lib/runnable.js:174:9)
	at expect.have.been.calledWith.id (/Users/austinbv/Dropbox/Documents/Sites/poet_app/test/word_spec.coffee:44:11)
	at Word.getNouns (/Users/austinbv/Dropbox/Documents/Sites/poet_app/models/word.coffee:34:18)
	at process.startup.processNextTick.process._tickCallback (node.js:244:9)

	2) Wordlist .getNouns should call a callback with the response:
	> sinon = require('sinon');
	> sinon.useFakeXMLHttpRequest();
	TypeError: Object #<Object> has no method 'useFakeXMLHttpRequest'
	at repl:1:7
	at REPLServer.self.eval (repl.js:111:21)
	at rli.on.e (repl.js:260:20)
	at REPLServer.self.eval (repl.js:118:5)
	at Interface.<anonymous> (repl.js:250:12)
	at Interface.EventEmitter.emit (events.js:88:17)
	at Interface._onLine (readline.js:183:10)
	✖ 1 of 3 tests failed:

	1) Wordlist should throw if no api key is defined:
	expected [Function] to throw Error but a Error was thrown