Skip to content

Instantly share code, notes, and snippets.

@conor-pwbot
Created March 3, 2023 20:00
Show Gist options
  • Save conor-pwbot/bcd1321de9e8cfc3cd82f08f1592007d to your computer and use it in GitHub Desktop.
Save conor-pwbot/bcd1321de9e8cfc3cd82f08f1592007d to your computer and use it in GitHub Desktop.
CHECK: Consider using #include <linux/ftrace.h> instead of <asm/ftrace.h>
ERROR: do not initialise globals to false
WARNING: Reported-by: should be immediately followed by Link: with a URL to the report
==========
checkpatch - FAILED
WARNING: Reported-by: should be immediately followed by Link: with a URL to the report
#17:
Reported-by: Changbin Du <changbin.du@gmail.com>
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
CHECK: Consider using #include <linux/ftrace.h> instead of <asm/ftrace.h>
#96: FILE: arch/riscv/kernel/patch.c:14:
+#include <asm/ftrace.h>
ERROR: do not initialise globals to false
#104: FILE: arch/riscv/kernel/patch.c:24:
+int riscv_patch_in_stop_machine = false;
total: 1 errors, 1 warnings, 1 checks, 101 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Commit cd6a9b9ba50a ("RISC-V: Don't check text_mutex during stop_machine") has style problems, please review.
NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment