- Install Git
- Get familiar with Git commands
- Install a text editor
- Install Node.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
//contract FixedSupplyToken is ERC20Interface, Owned { | |
//https://ethernaut.zeppelin.solutions/ | |
contract MyToken { | |
uint totalTokens; | |
uint tokenCost; | |
mapping(address => uint) reserve; | |
mapping(address => uint) balances; | |
mapping(address => Account) accounts; | |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contract Wallet { | |
address owner; | |
address approver; | |
unit amountToWithdrawal; | |
function Wallet(address app) { | |
owner = msg.sender; | |
approver = app; | |
} | |
GENERAL:
- You can't include commits from different repos in a single code review using github pull requests, whereas you can with Crucible code reviews.
- It's risky to use a pull request for code that isn't ready to be merged yet. What if someone doesn't see the "DON'T MERGE" comment/title, and clicks the big green merge button?
VIEWING:
- You can't adjust the line width in which files are displayed, even if you make your browser window wider than the page. Some XML/HTML content extends well past 80 characters.
- There are numerous Chrome extensions which purport to provide this feature, but I haven't been able to get any of them to work for gh:e.
- You can't choose to ignore white space, so if a change involved indenting a lot of lines, you'll have a hard time figuring out what changed. In Crucible, you can choose to ignore white space.
- You can't see the full file name, if the file name and path are longer than ~70 characters, and the HTML element that contains the file name is absolutely sized so y
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!DOCTYPE html> | |
<html> | |
<head> | |
<script src="background.js"></script> | |
</head> | |
<body> | |
<textarea id="sandbox"></textarea> | |
</body> |