Hi everyone,
Yesterday, I merged in a branch to re-enable PHP notices in our development environments and to fix quite a few of them (I've updated more than 80 files in the process). I committed a few follow-up branches to fix broken tests. As it currently stands, I believe I've fixed all of the selenium tests, but I can't tell, because the test runner is currently blocked by a few jobs on bigmac. I also can't tell if simpletest is red or green, because I can't access Hudson (it's after hours, so couldn't get Mike to whitelist my IP). I may be blocking you from merging tomorrow, but please don't merge until the tests are resolved. I believe the effort will be worth the benefits. PHP notices have been disabled for quite a long time in our dev environments. I believe that re-enabling PHP notices should lead to much better quality code and result in fewer bugs. As part of our development process, we should keep an eye on two log files where the PHP notices will appear.
- /var/log/drupal.log
- /var/lo