Skip to content

Instantly share code, notes, and snippets.

View geet084's full-sized avatar
😉

Travis Gee geet084

😉
View GitHub Profile
@geet084
geet084 / code-review-checklist.md
Created December 10, 2018 18:08 — forked from thatPamIAm/code-review-checklist.md
Code Review Checklist

Pair-to-Pair Code Review

5 mins

  • Get together with your group and send a link of your team's GitHub Repo to the pair that is reviewing your project.
  • Look over this guide with your project partner and highlight the pieces where your team can use assistance/you would like your reviewers to take a closer look. Fork this gist and send the forked copy over to the pair reviewing your code.

45 mins

  • Follow the instructions to clone down the repo you are given and start reviewing the codebase. Take notes for written feedback.
@geet084
geet084 / code-review-checklist.md
Last active December 10, 2018 18:45 — forked from foxwellm/code-review-checklist.md
Code Review Checklist

What we would like reviewed

where would you see places where JQuery would help?

you can use jQuery, or also alternatively build in a helper function to do what you would like it to do i.e. buildBoxWith('width', 'height', 'other things') {};

How's our classes looking, planning on using DailyDouble Class and then Round3 as a sub class.

consider using a method to run methods within a class instead of chaining methods inside one another

Any unintuitive gameplay that glares out.

after round 3, doesn't appear to show a winner?

other: