Charles Lawrence geuis

## code-review-checklist.md

      
              1 file
            
          
              0 forks
            
          
              0 comments
            
          
              0 stars
            
          
                geuis
                / code-review-checklist.md
            
            
              Created
              March 4, 2014 19:54
            
          
readability
maintainability
consistency
exception handling
simplicity
test coverage
side effect
reuse of existing code
performance


## base32decode.js
(function(){
    "use strict";

    //Generate dictionary
    var arr = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ234567'.split(''),
        dict = {};
    for(var i=0, len=arr.length; i<arr.length; i++){
        dict[arr[i]] = i;
    }

## clever.html
<!doctype>
<html>
<head>
<script src="http://code.jquery.com/jquery-2.0.3.min.js"></script>
<script>

(function(){

window.clever = function(user, pass){

## remote-typeahead.js
<script>
// Charles Lawrence - Feb 16, 2012. Free to use and modify. Please attribute back to @geuis if you find this useful
// Twitter Bootstrap Typeahead doesn't support remote data querying. This is an expected feature in the future. In the meantime, others have submitted patches to the core bootstrap component that allow it.
// The following will allow remote autocompletes *without* modifying any officially released core code.
// If others find ways to improve this, please share.

    var autocomplete = $('#searchinput').typeahead()
        .on('keyup', function(ev){

            ev.stopPropagation();

## json.js
(function(){

    var parse = JSON.parse;

    JSON = {

        stringify: JSON.stringify,

        validate: function(str){


## whenthen.js
var when = function(){
    if( !(this instanceof when) ) return new when(arguments); //return new instance of itself

    var self = this; //cached so the syntax of code within the function is more readable

    self.pending = Array.prototype.slice.call(arguments[0]); //convert arguments passed in to array
    self.pending_length = self.pending.length; //cache length of the arguments array
    self.results = []; //container for results of async functions

    (function(){ // define pass() within this context so that the outer scope of self(this) is available when pass() is executed within the user's async functions

## tic-tac-toe.js
<!DOCTYPE html>
<html>
<head>
<style>
    html,body{
        padding:0;
        margin:0;
        font-family:arial;
    }
    .clearfix:after{
	(function(){
	"use strict";

	//Generate dictionary
	var arr = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ234567'.split(''),
	dict = {};
	for(var i=0, len=arr.length; i<arr.length; i++){
	dict[arr[i]] = i;
	}
	<!doctype>
	<html>
	<head>
	<script src="http://code.jquery.com/jquery-2.0.3.min.js"></script>
	<script>

	(function(){

	window.clever = function(user, pass){
	<script>
	// Charles Lawrence - Feb 16, 2012. Free to use and modify. Please attribute back to @geuis if you find this useful
	// Twitter Bootstrap Typeahead doesn't support remote data querying. This is an expected feature in the future. In the meantime, others have submitted patches to the core bootstrap component that allow it.
	// The following will allow remote autocompletes without modifying any officially released core code.
	// If others find ways to improve this, please share.

	var autocomplete = $('#searchinput').typeahead()
	.on('keyup', function(ev){

	ev.stopPropagation();
	(function(){

	var parse = JSON.parse;

	JSON = {

	stringify: JSON.stringify,

	validate: function(str){
	var when = function(){
	if( !(this instanceof when) ) return new when(arguments); //return new instance of itself

	var self = this; //cached so the syntax of code within the function is more readable

	self.pending = Array.prototype.slice.call(arguments[0]); //convert arguments passed in to array
	self.pending_length = self.pending.length; //cache length of the arguments array
	self.results = []; //container for results of async functions

	(function(){ // define pass() within this context so that the outer scope of self(this) is available when pass() is executed within the user's async functions
	<!DOCTYPE html>
	<html>
	<head>
	<style>
	html,body{
	padding:0;
	margin:0;
	font-family:arial;
	}
	.clearfix:after{