guillaume quintard gquintard
gquintard
/ gist:5426831
Created
April 20, 2013 18:01
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/data/AlbumWidget.ui b/data/AlbumWidget.ui | |
| index 9bdd133..ef5b019 100644 | |
| --- a/data/AlbumWidget.ui | |
| +++ b/data/AlbumWidget.ui | |
| @@ -200,29 +200,10 @@ | |
| <object class="GtkViewport" id="view"> | |
| <property name="visible">True</property> | |
| <property name="can_focus">False</property> | |
| + <property name="halign">start</property> | |
| + <property name="margin_top">64</property> |
gquintard
/ gist:5427567
Created
April 20, 2013 21:50
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| index ef5b019..ac8dc2a 100644 | |
| --- a/data/AlbumWidget.ui | |
| +++ b/data/AlbumWidget.ui | |
| @@ -88,6 +88,7 @@ | |
| <property name="visible">True</property> | |
| <property name="can_focus">False</property> | |
| <property name="xalign">1</property> | |
| + <property name="ypad">2</property> | |
| <property name="label" translatable="yes"><span color='grey'>Released</span></property> | |
| <property name="use_markup">True</property> |
gquintard
/ gist:5438274
Created
April 22, 2013 20:32
move various markup that do not change into glade, and use set_text instead of set_markup
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| index ac8dc2a..3d39ed0 100644 | |
| --- a/data/AlbumWidget.ui | |
| +++ b/data/AlbumWidget.ui | |
| @@ -39,11 +41,16 @@ | |
| <object class="GtkVBox" id="artistBox"> | |
| <property name="visible">True</property> | |
| <property name="can_focus">False</property> | |
| + <property name="valign">start</property> | |
| <property name="spacing">6</property> | |
| <child> |
gquintard
/ gist:5438513
Created
April 22, 2013 21:01
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| From 22b0851050153acd5cce23708973975f0aa2a6e0 Mon Sep 17 00:00:00 2001 | |
| From: Guillaume Quintard <guillaume.quintard@gmail.com> | |
| Date: Sat, 20 Apr 2013 23:49:11 +0200 | |
| Subject: [PATCH] more code cleaning | |
| put markup as pango attributes in the glade file. | |
| Conflicts: | |
| src/widgets.js | |
| --- |
gquintard
/ gist:5439643
Last active
December 16, 2015 13:09
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| From 7fe8db44b847b635d876c83b1a9629e77874ad6a Mon Sep 17 00:00:00 2001 | |
| From: Guillaume Quintard <guillaume.quintard@gmail.com> | |
| Date: Tue, 23 Apr 2013 01:45:34 +0200 | |
| Subject: [PATCH 2/2] declare global pixbufs in src/widget | |
| --- | |
| src/widgets.js | 32 ++++++++++++++++---------------- | |
| 1 file changed, 16 insertions(+), 16 deletions(-) | |
| diff --git a/src/widgets.js b/src/widgets.js |
gquintard
/ gist:5439636
Last active
December 16, 2015 13:09
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| From 68616aa5c24f65e67169931e711e730cf126bfb6 Mon Sep 17 00:00:00 2001 | |
| From: Guillaume Quintard <guillaume.quintard@gmail.com> | |
| Date: Tue, 23 Apr 2013 00:51:33 +0200 | |
| Subject: [PATCH 1/2] load symbolic icon only once for the albums view | |
| --- | |
| src/view.js | 9 ++++----- | |
| 1 file changed, 4 insertions(+), 5 deletions(-) | |
| diff --git a/src/view.js b/src/view.js |
gquintard
/ gist:5447321
Created
April 23, 2013 20:56
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| From 14345b4af1568511e532708cb29eddc0da762905 Mon Sep 17 00:00:00 2001 | |
| From: Guillaume Quintard <guillaume.quintard@gmail.com> | |
| Date: Tue, 23 Apr 2013 00:55:18 +0200 | |
| Subject: [PATCH] Use models as playlists | |
| this is a proof-of-concept, using the listStore of the Album view as a | |
| playlist if one item is clicked. | |
| Various enhacements can be made (embedding model/iter in one object, | |
| warning that the song as been paused...) and the theory remains open to | |
| discussion |
gquintard
/ gist:5477224
Created
April 28, 2013 15:30
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| JS LOG: onProgressScaleChangeValue 271.7746478873239 | |
| JS LOG: onProgressScaleChangeValue 271.7746478873239 | |
| JS ERROR: !!! Exception was: ReferenceError: Gst is not defined | |
| JS ERROR: !!! message = '"Gst is not defined"' | |
| JS ERROR: !!! fileName = '"/home/shivan/boxon/installed/share/gnome-music/widgets.js"' | |
| JS ERROR: !!! lineNumber = '211' | |
| JS ERROR: !!! stack = '"AlbumWidget<.updateModel@/home/shivan/boxon/installed/share/gnome-music/widgets.js:211 | |
| wrapper@/usr/share/gjs-1.0/lang.js:213 | |
| AlbumWidget<.update/<@/home/shivan/boxon/installed/share/gnome-music/widgets.js:188 | |
| _emit@/usr/share/gjs-1.0/signals.js:124 |
gquintard
/ gist:5477268
Created
April 28, 2013 15:42
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| JS ERROR: !!! Exception in callback for signal: playlist-item-changed | |
| JS ERROR: !!! message = '"undefined is not a function"' | |
| JS ERROR: !!! fileName = '"/home/shivan/boxon/installed/share/gnome-music/player.js"' | |
| JS ERROR: !!! lineNumber = '437' | |
| JS ERROR: !!! stack = '"Player<._updatePositionCallback@/home/shivan/boxon/installed/share/gnome-music/player.js:437 | |
| wrapper@/usr/share/gjs-1.0/lang.js:213 | |
| AlbumWidget<.updateModel@/home/shivan/boxon/installed/share/gnome-music/widgets.js:207 | |
| wrapper@/usr/share/gjs-1.0/lang.js:213 | |
| _emit@/usr/share/gjs-1.0/signals.js:124 | |
| Player<.load@/home/shivan/boxon/installed/share/gnome-music/player.js:129 |
gquintard
/ gist:5483460
Created
April 29, 2013 18:03
use a simpler updateModel function in the album view
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| From 9666e0cccb4b395a9370ada9457f222bed6eb970 Mon Sep 17 00:00:00 2001 | |
| From: Guillaume Quintard <guillaume.quintard@gmail.com> | |
| Date: Mon, 29 Apr 2013 20:02:30 +0200 | |
| Subject: [PATCH] use a simpler updateModel function in the album view | |
| --- | |
| src/widgets.js | 54 +++++++++++++++++++++++++++--------------------------- | |
| 1 file changed, 27 insertions(+), 27 deletions(-) | |
| diff --git a/src/widgets.js b/src/widgets.js |
OlderNewer