Skip to content

Instantly share code, notes, and snippets.

View gsherwood's full-sized avatar
🤧
Code sniffing

Greg Sherwood gsherwood

🤧
Code sniffing
View GitHub Profile
@gsherwood
gsherwood / 21-Feb-2014.json
Last active August 29, 2015 13:56
Comparison of coding standards across some well known PHP projects
{
"Arrays":{
"Array keyword case":{
"sniffs":{
"0":"Squiz.Arrays.ArrayDeclaration"
},
"total":94079,
"values":{
"lower":94077,
"upper":2
@gsherwood
gsherwood / zf2.txt
Last active August 29, 2015 13:56
Example output from PHP_CodeSniffer's Information report (--report=info)
Running with a single standard will allow sniffs in that standard to add metrics about the source code.
This is a good way to get a feel for how a code base is deviating from a standard and ways you can
tweak the standard to more closely match what the majority of developers are doing.
The report output is still very rough, so read output like this:
Function openning brace placement: new line [10431/10598, 98.42%]
same line => 167 (1.58%)
as this:
The majority of function openning braces are placed on a new line (98.42%).
@gsherwood
gsherwood / gist:8275236
Last active February 17, 2016 18:44
Possible fix for bug #20151 : Problem handling "if(): ... else: ... endif;" syntax
$ git diff
diff --git a/CodeSniffer/File.php b/CodeSniffer/File.php
index f45e307..e629fed 100644
--- a/CodeSniffer/File.php
+++ b/CodeSniffer/File.php
@@ -1446,7 +1446,7 @@ class PHP_CodeSniffer_File
if (PHP_CODESNIFFER_VERBOSITY > 1) {
$type = $tokens[$i]['type'];
$content = str_replace($eolChar, '\n', $tokens[$i]['content']);
- echo "\tStart scope map at $i: $type => $content".PHP_EOL;
@gsherwood
gsherwood / gist:6773172
Last active December 24, 2015 08:49
PHP_CodeSniffer (phpcs-fixer branch) run over ZF2. Shows all existing errors (warnings are muted) and which ones can be fixed automatically using phpcbf (docs: https://github.com/squizlabs/PHP_CodeSniffer/wiki/Fixing-Errors-Automatically)
$ php scripts/phpcs ../zf2/library/Zend/ --standard=PSR2 -p --report=source -ns
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
--------------------------------------------------------------------------------
SOURCE COUNT
--------------------------------------------------------------------------------
[x] PSR2.Methods.FunctionCallSignature.Indent 328
[ ] PSR2.Methods.FunctionCallSignature.MultipleArguments 276
[x] PSR2.Methods.FunctionCallSignature.CloseBracketLine 248
[x] Squiz.WhiteSpace.ScopeClosingBrace.ContentBefore 230