holyjak

public class S3FilesResourceTest {

    private static class FakeS3Facade implements S3Facade {
        List<S3File> fileList;

        public List<S3File> listObjects(String bucketName) {
            return fileList;
        }
    }

holyjak

#!/bin/sh
# A git pre-commit hook that verifies that the change does not introduce
# the use of a Jest/Jasmine exclusive test via 'it.only(..)', which would
# prevent most other tests from being run without any clear indication thereof

# Redirect output to stderr.
exec 1>&2

ADDED_IT_ONLY=$(git diff -U0 --cached -S"(\W|^)it\.only\s+?\(" --pickaxe-regex | egrep "(^\+.*it.only)|\+{3}")

holyjak

Refactoring & Type Errors in Clojure

While refactoring a relatively simple Clojure code to use a map instead of a vector, I have wasted perhaps a few hours due to essentially type errors. I want to share the experience and my thoughts about possible solutions since I encounter this problem quite often. I should mention that it is quite likely that it is more a problem (an opportunity? :-)) with me rather than the language, namely with the way I write and (not) test it.

The core of the problem is that I write chains of transformations based on my

holyjak

files:

  /opt/gor:
    source: "https://s3-eu-west-1.amazonaws.com/elasticbeanstalk-eu-west-1-<our-id>/our_fileserver/gor"
    authentication: S3Access
    mode: "000755"
    owner: root
    group: root

  # Script to start Gor in the background

holyjak

// Using http://lodash.com/ as `_`

// 1. IMPERATIVE
_(bundles).filter(function includeOnlyHandsets(bundle) {
    if (!filter.hardwareType) return true;
    return (bundle.product.type === filter.hardwareType);
})

// 2. DECLARATIVE
_(bundles).filter(filter.hardwareType ? 

holyjak

...
# The client code
@my.route('/cleanjson/<collection>/')
def getcleanjson(collection):
    cleandata = Cleanjson()
    cleandata.get_mongojson(str(collection), "?s={'_id': 1}")
    cleandata.parse_json(cleandata.rawjson)
    return cleandata.cleanjson

holyjak

...
# The client code
@my.route('/cleanjson/<collection>/')
def getcleanjson(collection):
    return Cleanjson().get_mongojson(str(collection), "?s={'_id': 1}", format=True)

holyjak

public interface LogEntry {
     Date getTimestamp();
     /** For dumping into a .tsv file to be imported into Hadoop */
     String toTabDelimitedString();
     String getSearchTerms();
     boolean hasSearchTerms();
     String[][] getColumns();
     String getKey();
     void mergeWith(LogEntry entry);
}

holyjak

public interface LogEntry {
    // same as before
}

holyjak

// compare two series and add the delta to the data for the current period
augmentSeriesWithPreviousValues:function (seriesData, previousSeriesData) {
    var series = seriesData.series;
    seriesData.previous = [];
    var previousSeries = previousSeriesData.series;
    
    ... // checks, computing maxRows, maxColumns, previousCategories
        // that maps category name to series index (id)
    
    for (var seriesId = 0; seriesId < series.length; seriesId++) {