jameswilson

You are a senior software engineer performing a one-shot code review of a GitHub pull request.

Your role is to identify real issues, meaningful risks, and high-leverage improvements for a professional development team. Assume the author is competent. Prefer correctness and signal over verbosity.

This is a one-shot, non-interactive review.

All relevant context for this review is provided in the initial prompt (e.g. PR title, description, timestamps, diff, and any additional metadata explicitly included).
You will receive no follow-up input.

jameswilson

# Add the following to  your project's .gitignore
# The approach here assumes you're going to want to have the awscli also configured
# on your host OS, so we can just copy configs from ~/.aws/ on your host OS into the
# ddev web container during startup by way of the .ddev/homeadditions folder.

.ddev/homeadditions/.aws

jameswilson

#!/bin/bash
#hooks/common/post-code-deploy/environment-indicator.sh
set -e

site="$1"
target_env="$2"
source_branch="$3"

docroot="/var/www/html/$site.$target_env/docroot"
DRUSH_CMD="/var/www/html/$site.$target_env/vendor/bin/drush --root=$docroot"

jameswilson

# This is an adaptation and simplication from the Platform.sh Drupal 10 templates:
# https://github.com/platformsh-templates/drupal10/blob/master/.platform.app.yaml
# https://github.com/platformsh-templates/drupal10/blob/master/drush/platformsh_deploy_drupal.sh

mounts:
    # Create a persistent filesystem location to house the PREVIOUS_PLATFORM_TREE_ID
    # value in a file that must be available for each build. 
    '/build_info':
        source: local
        source_path: 'build_info'

jameswilson

stages:
  - Deploy

# @todo implement a Build and Test step to verify code quality before deploy

# IMPORTANT: `acli push:artifact` leverages composer internally to build dependencies, so no separate build step is required.
'Deploy to Acquia':
  image: php:8.2
  stage: Deploy
  rules:

jameswilson

git checkout old_branch_name                # Ensure you're on the local branch.
git branch -M new_branch_name               # Rename branch locally.
git branch --unset-upstream                 # unset
git push origin :old_branch_name            # Delete the old branch
git push -u origin new_branch_name          # Push the new branch, set local branch to track the new remote

jameswilson

#!/bin/sh
#
# Acquia Cloud Hook: post-code-deploy
#
# See https://github.com/acquia/cloud-hooks/blob/master/samples/post-code-deploy.tmpl
# See https://docs.acquia.com/acquia-cloud-platform/develop-apps/api/cloud-hooks
#
# Installation: 
# 
# 1. Place this file at `hooks/common/post-code-deploy/acquia-cloud-clear-varnish.sh` in your repository.

jameswilson

image: php:8.3
clone:
  depth: full
pipelines:
  branches:
    develop:
      - step:
          script:
            - scripts/ci/build.sh
            - scripts/ci/test.sh

jameswilson

#!/usr/bin/env bash
###
### Description:
###
###    Create and tag a release for deployment to the build system and
###    remote hosting environment.
###
### Usage:
###
###        ./scripts/create-release.sh [1.2.3]

jameswilson

#!/bin/bash
# Deployment script for Acquia Cloud Next on a multisite (non-Site Factory) setup.
# Place this file in your repository at hooks/common/post-code-deploy/deploy.sh
# See https://github.com/acquia/cloud-hooks/blob/master/samples/post-code-deploy.tmpl

site="$1"
target_env="$2"

cd "/var/www/html/$site.$target_env/docroot"