- (done) Create
storage-ng
branch in yast-autoinstallation (Rakefile, Travis, etc.) - (done) Add yast-autoinstallation to the storage-ng OBS project.
- (done) Configure Jenkins for the new branch.
- (done) Comment the offending code.
- Only commented
AutoInstallRules
in order to installer works.
- Only commented
- (done) Make the unit test pass (probably commenting stuff)
- Commented modules import to avoid
yast2-installation
dependency.
- Commented modules import to avoid
- Skip that tests.
For this Hackweek two main objectives were proposed: (a) learn, understand and become familiar with proposal code, and (b) improve some classes with a special code smell. Let's see each one.
(a) This was harder than I expected. Proposal implementation has numerous related classes and its correct undestanding took me a while. The first two and a half days was dedicated to this task. Algorithms for deleting partitions, distributing free space or selecting best proposal were studied. Right now I have a good understanding of the code and I feel confortable working on it.
(b) Previous this week, that is, during my first two weeks at YaST teem (yes, this Hackweek came in my third week at SUSE), my workmate Ancor and me talked about different parts of the proposal that could improve. Specially, classes as PlannedVolume
and PlannedVolumeList
seem to have more responsibilities than they should. In the rest of the Hackweek t
- Working on this PBI (2) StorageNG: Make proposal work with Power.
- (done) Add tests to check proposal matches bootloader requirements.
- (done) Covered by YAML tests.
- Others:
- File
proposal_test
is too long, so it is splitted.
-
PBI (2) StorageNG: Make proposal work with Power closed:
-
Some improvements suggested during review process were done.
-
Trello task was moved to done column (review section was also added) .
-
Start working on PBI yast-storage-ng: Encrypted non-LVM proposal.
-
Main work is done.
-
Remains the question: Should we reuse swap when using encryption?
-
For now, it is not reused.
Done
- PBI (3) yast-storage-ng: Encrypted non-LVM proposal finished and merged, see PR.
Next
- Working on this PBI (3) Read setting from control file.
Yesterday
- Review PR
- New PBI (under waterline) (3) StorageNG: Activate and probe inactive LVM.
- My first task with libstorage code (C++ part).
- Reading documetation, study and become familiar with the code.
Today
- Continue with my introduction to libstorage.
Report
- PBI (3) StorageNG: Activate and probe inactive LVM.
- Install VM and prepare scenarios.
- Reproduce updater differences using old and new libstorage.
- Research how old libstorage activates VGs.
- Analyze how to do the same in new libstorage-ng.
Todo
Report
- Review PR.
- Continue with PBI (3) StorageNG: Activate and probe inactive LVM.
- Now Lvs can be selected in the list of systems to update.
- PR1: yast/yast-update#68.
- PR2: openSUSE/libstorage-ng#202.
- Manually tested.
- Discuss vg (and other stuff) activation in libstorage-ng.
Report
-
Review PRs of libstorage-ng:
-
Research why systems are not showed in the default list for updating.
- Related PBI: (3) StorageNG: Activate and probe inactive LVM.
TODO
Report
- Integrating improvements of storage-ng classes:
- Improvements report: https://gist.github.com/joseivanlopez/4b1f1091d212b10b0970cdd691ea2f2e.
- WIP PR: yast/yast-storage-ng#179.
- Fix bug with my last PBI:
- Show lvm systems in default list, PR: yast/yast-update#69.
Today