mackal

local index = 0;
local casting_data = {
    {
        "pulls his right arm back, preparing to cut a swathe through his opponents with his razor sharp claws.",
        "claws at those on his right flank.",
        6554
    },
    {
        "pulls his left arm back, preparing to cut a swathe through his opponents with his razor sharp claws.",
        "claws at those on his left flank.",

mackal

diff --git a/zone/tasks.h b/zone/tasks.h
index 0bc45c146..35c4d922b 100644
--- a/zone/tasks.h
+++ b/zone/tasks.h
@@ -26,6 +26,7 @@ Copyright (C) 2001-2004 EQEMu Development Team (http://eqemulator.net)
 #include <vector>
 #include <string>
 #include <algorithm>
+#include <unordered_map>
 

mackal

/*
  Name: Elaborate Frostwarded Armband
  ID: 91836
  Skill ID: 63
  Trivial: 355
  No fail: False
  Results: [[91836, 1], [81672, 1]]
  Components: [[35229, 1], [34404, 1], [38837, 1], [81672, 1], [34884, 1], [34477, 1], [13006, 1]]
  On Fail: [[81672, 1]]
  Containers: [36]

mackal

#include <cstring>
#include <cassert>
#include <cstdint>
#include <string>

class SerializeBuffer {
public:
    SerializeBuffer() : m_buffer(nullptr), m_capacity(0), m_pos(0) {}

    explicit SerializeBuffer(size_t size) : m_capacity(size), m_pos(0)

mackal

#include <random>
#include <iostream>
#include <cstdlib>
#include <cmath>

int main(int argc, char **argv)
{
    int accuracy = 1000;
    int avoidance = 1000;
    int runs = 10000;

mackal

Enabled checks:
    clang-analyzer-apiModeling.google.GTest
    clang-analyzer-core.CallAndMessage
    clang-analyzer-core.DivideZero
    clang-analyzer-core.DynamicTypePropagation
    clang-analyzer-core.NonNullParamChecker
    clang-analyzer-core.NonnilStringConstants
    clang-analyzer-core.NullDereference
    clang-analyzer-core.StackAddressEscape
    clang-analyzer-core.UndefinedBinaryOperatorResult

mackal

diff --git a/zone/waypoints.cpp b/zone/waypoints.cpp
index 45d199277..fb96b2c43 100644
--- a/zone/waypoints.cpp
+++ b/zone/waypoints.cpp
@@ -29,10 +29,13 @@ Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
 #include "npc.h"
 #include "quest_parser_collection.h"
 #include "water_map.h"
+#include "fastmath.h"
 

mackal

sub foo
  /declare c int local ${Me.XTargetSlots}
  /declare index int local
  /declare cur_hp int local 100
  /declare i int local
  /for i 1 to ${c}
    /if (${Me.XTargets[${i}].TargetType.Equal[auto hater]} && ${Me.XTargets[${i}].ID}) {
      /if (${Spawn[${Me.XTargets[${i}].ID}].ID} && ${Spawn[${Me.XTargets[${i}].ID}].CurrentHPs} < ${cur_hp}) {
        /varset cur_hp ${Spawn[${Me.XTargets[${i}].ID}].CurrentHPs}
        /varset index ${i}

mackal

==1777== 27 bytes in 1 blocks are definitely lost in loss record 5 of 46
==1777==    at 0x4C28C20: malloc (vg_replace_malloc.c:296)
==1777==    by 0x5E69E21: Perl_safesysmalloc (util.c:130)
==1777==    by 0x5E6A191: Perl_savepv (util.c:1025)
==1777==    by 0x5DFA342: Perl_newSTUB (op.c:8363)
==1777==    by 0x5E19C87: Perl_gv_init_pvn (gv.c:402)
==1777==    by 0x5E1B5E8: Perl_gv_fetchpvn_flags (gv.c:2187)
==1777==    by 0x5E1FF30: Perl_gv_fetchsv (gv.c:1391)
==1777==    by 0x5DFA63E: Perl_ck_rvconst (op.c:9047)
==1777==    by 0x5DFDC16: Perl_newUNOP (op.c:4285)

mackal

diff --git a/zone/spell_effects.cpp b/zone/spell_effects.cpp
index f55c091d6..30cf10450 100644
--- a/zone/spell_effects.cpp
+++ b/zone/spell_effects.cpp
@@ -2075,61 +2075,6 @@ bool Mob::SpellEffect(Mob* caster, uint16 spell_id, float partial, int level_ove
 #ifdef SPELL_EFFECT_SPAM
 				snprintf(effect_desc, _EDLEN, "Toss Up: %d", effect_value);
 #endif
-				double toss_amt = (double)spells[spell_id].base[i];
-				if(toss_amt < 0)