meandavejustice

commit 72670718acfe5f3292b4ab6b043469310a029912
Author: Dave Justice <djustice@mozilla.com>
Date:   Fri Jun 29 14:52:23 2018 -0400

    fix construction of download url (#3664)

commit 2ecb7ea344b2132b99db66211d9bcd70826a104f
Author: Dave Justice <djustice@mozilla.com>
Date:   Fri Jun 29 14:53:58 2018 -0400

meandavejustice

• ENVIRONMENT_TITLE=local ENVIRONMENT_URL=https://example.com/
• ENVIRONMENT_TITLE=dev ENVIRONMENT_URL=https://testpilot.dev.mozaws.net/
• ENVIRONMENT_TITLE=l10n ENVIRONMENT_URL=https://testpilot-l10n.dev.mozaws.net/
• ENVIRONMENT_TITLE=stage ENVIRONMENT_URL=https://testpilot.stage.mozaws.net/
• ENVIRONMENT_TITLE=production ENVIRONMENT_URL=https://testpilot.firefox.com/

meandavejustice

[testpilot] meandavejustice force-pushed production from 7ca364d to 28f2af4: https://git.io/vF1uv
12:16 PM testpilot/production 28f2af4 Danny Coates: bump addon version
12:16 PM → cloudops-ansible joined  ← github left  
12:17 PM 
<cloudops-ansible> testpilot static prod #65 building
12:17 PM ↔ cloudops-ansible nipped out  
12:18 PM 
<cloudops-ansible> testpilot static prod #65 build failed

meandavejustice

fix error message to help with resist fingerprinting (#3486)
fix feedback button test and remove problematic tests (#3485) 
put the loading spinner back. fixes #3453 (#3484)
Tweaks to quickstart docs and add-on build (#3483)
Auditing metrics for featured experiment (#3435)
update notes cntent for v4 (#3482)
Add notice for non en news feed items (#3481)
add headerLinkNews to app.ftl (#3478) 
Update pytest from 3.4.2 to 3.5.0 (#3479)
Move some more things out of gulp into webpack (#3426)

meandavejustice

Issue

Options.html form elements (and OPTIONS button in about:addons view) not showing up.

Current Code

Code is structured as such:

• webextension/options/options.html
• webextension/options/options.js
• webextension/manifest.json

meandavejustice

Okay so it sounds like Telemetry webextension api is coming! but its not going to be until Firefox 60, which is scheduled for release on May 9th
8:35 PM So we have 2 options as far as removing bootstrap goes
8:35 PM 1. I create a webextension experiment api for sending telemetry events (Could be super simple, or could get hairy, I don't know at this point)
8:36 PM 2. Create a branch where I remove all the rest of the bootstrap stuff and implement telemetry pings to match the coming webextension api, which will be merged right after the firefox 60 release in march.
8:36 PM Both should satisfy the OKR
8:37 PM Concerns against option 2 would be removal of capability to create embedded webextensions before then, (I will try and get a hard date for that now, but I was told it's a while away)
8:39 PM Concerns against option 1, Since I am unsure of what work it will take to actually implement the telmetry utils wrapped in the experiment api, I may not have it completed before End of this weekend when I leave for PTO

meandavejustice

diff --git a/package-lock.json b/package-lock.json
index 92a3dee..7d49c94 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -11713,7 +11713,7 @@
       "dev": true
     },
     "legal-docs": {
-      "version": "git+https://github.com/mozilla/legal-docs.git#ccab0c43aedf019260535ef07ce0950f005ed764"
+      "version": "git+https://github.com/mozilla/legal-docs.git#5c807d61c5b3170e5000f8f1d1be8feea613324e"

meandavejustice

meandave@LAPTOP-NA0Q0G86:/mnt/c/Users/Dave Justice/Code/testpilot$ npm run lint

> testpilot@1.0.0 lint /mnt/c/Users/Dave Justice/Code/testpilot
> npm-run-all lint:*


> testpilot@1.0.0 lint:styles /mnt/c/Users/Dave Justice/Code/testpilot
> sass-lint --verbose 'frontend/src/styles/**/*.scss' 'frontend/src/app/**/*.scss'

meandavejustice

meandave@mainframe-x250> firefox_nightly                                                                                                                                                                         ~
ExceptionHandler::GenerateDump cloned child 24747
ExceptionHandler::SendContinueSignalToChild sent continue signal to child
ExceptionHandler::WaitForContinueSignal waiting for continue signal...
ERROR:audioipc_server: server poll error: Interrupted system call (os error 4)

meandavejustice

loadIntoWindow: function (aDOMWindow) {
    if (!aDOMWindow) return;
    aDOMWindow.addEventListener('contextmenu', ev => {
      console.log('gContextMenu', ev.mCurrentBrowser.ownerGlobal.gContextMenu);
      console.log('oncontextmenu', ev, ev.mCurrentBrowser.ownerGlobal.gContextMenu.target);
      contextMenuOptions(aDOMWindow);
    });
    // aDOMWindow.document.oncontextmenu = function(ev) {
    //   console.log('oncontextmenu', ev);
    //   contextMenuOptions(aDOMWindow);