mejackreed

def footer_html
  Nokogiri::HTML::Builder.new do |doc|
    doc.div(class: 'sul-embed-footer') do
      doc.div(class: 'sul-embed-footer-toolbar') do
        unless @request.hide_metadata?
          doc.button(class: 'sul-embed-footer-tool sul-embed-btn sul-embed-btn-xs sul-embed-btn-default fa fa-info-circle', 'aria-expanded' => 'false', 'data-sul-embed-toggle' => 'sul-embed-metadata-panel')
        end
        unless @request.hide_embed_this?
          doc.button(class: 'sul-embed-footer-tool sul-embed-btn sul-embed-btn-xs sul-embed-btn-default fa fa-code', 'aria-expanded' => 'false', 'data-sul-embed-toggle' => 'sul-embed-embed-this-panel')
        end

mejackreed

We should stop creating geographic hierarchies in descriptive metadata period.

Geographic hierarchy can be a maintenance burden and difficult to update over time. It falls short in a lot of areas and doesn't really give us what we need for discovery.

My recommendation

Capture the most granular geographies within the metadata, no need to list the entire tree.

** Example ** from https://github.com/OpenGeoMetadata/edu.stanford.purl/blob/master/bc/899/yk/4538/mods.xml

mejackreed

##
  # Creates a CartoDB OneClick link link, using the configuration link
  # @param [String] file_link
  # @return [String]
  def cartodb_link(file_link)
    params  = URI.encode_www_form(
      file: file_link,
      provider: application_name,
      logo: Settings.APPLICATION_LOGO_URL
    )

mejackreed

it 'loads the SLY slider and scroll' do
  expect(page).to have_css('.sul-embed-thumb-slider-scroll', count: 1, visible: true)
  within '.sul-embed-was-seed' do
    expect(page.find('.sul-embed-was-thumb-list')['style']).to match(/webkit-transform: translateZ/)
  end
end

mejackreed

{
  "name": "Awesome WebMap",
  "bounds": [-180, -85, 180, 85],
  "center": [0,0],
  "layers": [
    { 
      "geojson": "https://gist.github.com/anonymous/9ec334f3536b4416670d"
    },
    {
      "wms": "http://mesonet.agron.iastate.edu/cgi-bin/wms/nexrad/n0r.cgi",

mejackreed

{
  "@context": "http://iiif.io/api/image/2/context.json",
  "@id": "https://sul-stacks.stanford.edu/image/iiif/bb537hc4022%2Fbb537hc4022_001",
  "width": 3712,
  "height": 5072,
  "protocol": "http://iiif.io/api/image",
  "sizes": [
    {
      "height": 317,
      "width": 232

mejackreed

Welcome

Wifi

"UST-Open"

mejackreed

Questions

We've been having trouble with facets. I cannot display the more link, Solr query always contains "10"?

Where is the solr configuration? This can be configured in Blacklight and Solr. Have you done limit: true? Yes.

We have a use case for changing how the facets work "oring them rather than anding them". Are there best practices around this? Can this be a configurable Blacklight feature?

mejackreed

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE WMT_MS_Capabilities SYSTEM "https://geowebservices.stanford.edu:443/geoserver/schemas/wms/1.1.1/WMS_MS_Capabilities.dtd">
<WMT_MS_Capabilities version="1.1.1" updateSequence="1524">
  <Service>
    <Name>OGC:WMS</Name>
    <Title/>
    <Abstract/>
    <KeywordList/>
    <OnlineResource xmlns:xlink="http://www.w3.org/1999/xlink" xlink:type="simple" xlink:href="https://geowebservices.stanford.edu:443/geoserver/"/>
    <ContactInformation>

mejackreed

Code Reviews

From: https://playbook.thoughtbot.com/#code-reviews

1. Create a local feature branch based off master.
2. When feature is complete and tests pass, stage the changes.
3. When you've staged the changes, commit them.
4. Write a good commit message.
5. Share your branch.
6. Submit a GitHub pull request.
7. Ask for a code review in Slack.