Skip to content

Instantly share code, notes, and snippets.

@misterdjules
Last active August 29, 2015 14:11
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save misterdjules/645bda5868d436bc3548 to your computer and use it in GitHub Desktop.
Save misterdjules/645bda5868d436bc3548 to your computer and use it in GitHub Desktop.

This is not a final decision, but here's a quick summary of some of the discussions we've been having so far in order to find the best way to solve this issue.

@indutny's change, while it seems reasonable and fixes this specific issue with s3.amazonaws.com, hasn't been tested thoroughly. Thus, releasing a new version with this change seems a bit too early.

For users who need to connect to s3.amazonaws.com, a workaround would be to specify the (now) missing unsafe CA certificate as an additional certificate to trust. The request module, and the built-in https and tls modules support that. Of course, there are critical security implications when doing that, and we would document them in details.

The current candidate fix could then be thoroughly tested and make it into the next stable release once we're confident that it doesn't break more sites than it fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment