Pere Miquel Brull pmbrull

## migration-fix.sql
UPDATE ingestion_pipeline_entity
SET json = jsonb_set(
  json::jsonb #- '{sourceConfig,config,viewParsingTimeoutLimit}',
  '{sourceConfig,config,queryParsingTimeoutLimit}',
  (json #> '{sourceConfig,config,viewParsingTimeoutLimit}')::jsonb,
  true
)
WHERE json #>> '{pipelineType}' = 'metadata'
AND json #>> '{sourceConfig,config,type}' = 'DatabaseMetadata';

## OM-migration-review.md

      
              1 file
            
          
              0 forks
            
          
              0 comments
            
          
              0 stars
            
          
                pmbrull
                / OM-migration-review.md
            
            
              Last active
              January 29, 2023 11:39
            
          
    Reproducing the steps:

❯ python -m venv venv-012
❯ source venv-012/bin/activate
❯ pip install "openmetadata-ingestion[snowflake,mysql,bigquery]~=0.12.3"
# Pin SQLAlchemy to 1.4 for old release without requirement fix
❯ pip install SQLAlchemy~=1.4
❯ metadata --version
metadata, version metadata 0.12.3.0 from /Users/pmbrull/tests/0123-0131-upgrade/venv-012/lib/python3.9 (python 3.9)

  
## airflow-2.2.2-constraint.txt
apache-airflow==2.2.2

## what_the_hash2.py
my_list  = [1, 2, 3]
hex(id(my_list))  # 0x104d7a580

my_list.append(4)  # mutate the list
hex(id(my_list))  # 0x104d7a580 -> still the same object.

my_string = "Levy"
hex(id(my_string))  # 0x104dec760

my_string += " the cat"

## what_the_hash1.py
data = {"cat": "Lévy", 2: "hello"}

data["cat"]  # Lévy
data[2]  # hello

## python_truth6.py
if password and get_funds() > 0:
    make_transaction()

## python_truth5.py
# The first argument is True
coffee = 10
milk = None

coffee or milk  # 10, milk is not evaluated
coffee and milk  # None, both expressions are evaluated

# The first argument is False
coffee = None
milk = 5

## python_truth4.py
class Coffee:
    def __init__(self, total_amount):
        self.total_amount = total_amount

    def drink(self, amount):
        if amount > self.total_amount:
            raise ValueError("Not enough coffee!")
        self.total_amount -= amount

    def __bool__(self):

## python_truth3.py
count = 0
if not count:  # Handles 0 and None
    ...

if count is None:  # Only handles None
    ...

## python_truth2.py
"""
help(int)

[...]
 |  __bool__(self, /)
 |      self != 0
[...]

help(str)
	UPDATE ingestion_pipeline_entity
	SET json = jsonb_set(
	json::jsonb #- '{sourceConfig,config,viewParsingTimeoutLimit}',
	'{sourceConfig,config,queryParsingTimeoutLimit}',
	(json #> '{sourceConfig,config,viewParsingTimeoutLimit}')::jsonb,
	true
	)
	WHERE json #>> '{pipelineType}' = 'metadata'
	AND json #>> '{sourceConfig,config,type}' = 'DatabaseMetadata';
	my_list = [1, 2, 3]
	hex(id(my_list)) # 0x104d7a580

	my_list.append(4) # mutate the list
	hex(id(my_list)) # 0x104d7a580 -> still the same object.

	my_string = "Levy"
	hex(id(my_string)) # 0x104dec760

	my_string += " the cat"
	data = {"cat": "Lévy", 2: "hello"}

	data["cat"] # Lévy
	data[2] # hello
	# The first argument is True
	coffee = 10
	milk = None

	coffee or milk # 10, milk is not evaluated
	coffee and milk # None, both expressions are evaluated

	# The first argument is False
	coffee = None
	milk = 5
	class Coffee:
	def __init__(self, total_amount):
	self.total_amount = total_amount

	def drink(self, amount):
	if amount > self.total_amount:
	raise ValueError("Not enough coffee!")
	self.total_amount -= amount

	def __bool__(self):
	count = 0
	if not count: # Handles 0 and None
	...

	if count is None: # Only handles None
	...
	"""
	help(int)

	[...]
	\| __bool__(self, /)
	\| self != 0
	[...]

	help(str)