Skip to content

Instantly share code, notes, and snippets.

View ppcano's full-sized avatar

Pepe Cano ppcano

View GitHub Profile
diff --git i/lib/broccoli/default-packager.js w/lib/broccoli/default-packager.js
index 1228226ee..af184f6db 100644
--- i/lib/broccoli/default-packager.js
+++ w/lib/broccoli/default-packager.js
@@ -845,46 +845,33 @@ module.exports = class DefaultPackager {
annotation: 'Tests To Process',
});
-
if (this.isModuleUnificationEnabled) {
diff --git i/lib/models/addon.js w/lib/models/addon.js
index 2f9de9d00..1734e3604 100644
--- i/lib/models/addon.js
+++ w/lib/models/addon.js
@@ -298,6 +298,10 @@ let addonProto = {
public: 'public',
};
+ if (this.isModuleUnification()) {
+ this.treePaths.styles = 'src/ui/styles';

I have reviewed the ember-octane-blueprint project and I have some thoughts that I would like to share:

The ember-octane-blueprint duplicates code from the ember-cli/module-unification-app blueprint; If we want to create tests for the ember-octane-blueprint project, we may end up duplicating the existing MU tests and having to maintain two similar MU app blueprints.

I wonder if a better strategy would be to figure out how the octane-blueprint project could reuse the existing module-unification-app blueprint.

@ppcano
ppcano / components.my-component.js
Last active November 2, 2018 13:18
New Twiddle
import Ember from 'ember';
import layout from '../templates/components/other-template';
export default Ember.Component.extend({
layout
});
{{es-footer}}
{{es-footer as |f|}}
{{#f.info}}
My custom info
{{/f.info}}
{{f.more}}
{{es-footer}}
@ppcano
ppcano / components.child-component.js
Created September 21, 2018 10:07 — forked from locks/components.child-component.js
Component template inheritance
import Ember from 'ember';
import Parent from './parent-component';
export default Parent.extend({
foo: 'baz'
});
{
"log": {
"version": "1.2",
"creator": {
"name": "WebInspector",
"version": "537.36"
},
"pages": [
{
"startedDateTime": "2018-01-30T11:05:24.052Z",
import http from "k6/http"
function logResponse(res) {
console.log('URL', res.url);
console.log(res.body);
for (var key in res.headers) {
console.log(key, res.headers[key]);
}
import http from "k6/http";
import { sleep } from "k6";
import { Counter } from "k6/metrics";
const vus = 10,
iterations = 10;
export let options = {
vus: vus,
iterations: vus*iterations
@ppcano
ppcano / adapters.post.js
Last active October 19, 2017 14:34 — forked from fivetanley/adapters.post.js
inverse link is overwritten
import DS from 'ember-data';
export default DS.RESTAdapter.extend();