प्रथमेश Sonpatki prathamesh-sonpatki

## issues_with_modules.md

      
              1 file
            
          
              14 forks
            
          
              23 comments
            
          
              118 stars
            
          
                ryanb
                / issues_with_modules.md
            
            
              Created
              November 29, 2012 22:38
            
              
                Points on how modules can make code difficult to read.
              
          
    My issues with Modules

In researching topics for RailsCasts I often read code in Rails and other gems. This is a great exercise to do. Not only will you pick up some coding tips, but it can help you better understand what makes code readable.
A common practice to organize code in gems is to divide it into modules. When this is done extensively I find it becomes very difficult to read. Before I explain further, a quick detour on instance_eval.
You can find instance_eval used in many DSLs: from routes to state machines. Here's an example from Thinking Sphinx.
class Article &lt; ActiveRecord::Base

  
## y2g.rb

def match_package(str)
  str.match /package\s.*;/
end

def match_import(str)
  str.match /import\s.*;/
end

def match_class(str)

	def match_package(str)
	str.match /package\s.*;/
	end

	def match_import(str)
	str.match /import\s.*;/
	end

	def match_class(str)