Skip to content

Instantly share code, notes, and snippets.

View schmidt-sebastian's full-sized avatar

Sebastian Schmidt schmidt-sebastian

  • San Francisco, CA
View GitHub Profile
diff --git a/firebase-database/src/main/java/com/google/firebase/database/core/utilities/Utilities.java b/firebase-database/src/main/java/com/google/firebase/database/core/utilities/Utilities.java
index 50299dc3..bdf49cdd 100644
--- a/firebase-database/src/main/java/com/google/firebase/database/core/utilities/Utilities.java
+++ b/firebase-database/src/main/java/com/google/firebase/database/core/utilities/Utilities.java
@@ -54,26 +54,32 @@ public class Utilities {
throw new IllegalArgumentException("Database URL does not specify a valid host");
}
- RepoInfo repoInfo = new RepoInfo();
- repoInfo.host = host.toLowerCase();
diff --git a/firebase-database/src/main/java/com/google/firebase/database/core/utilities/Utilities.java b/firebase-database/src/main/java/com/google/firebase/database/core/utilities/Utilities.java
index 50299dc3..bdf49cdd 100644
--- a/firebase-database/src/main/java/com/google/firebase/database/core/utilities/Utilities.java
+++ b/firebase-database/src/main/java/com/google/firebase/database/core/utilities/Utilities.java
@@ -54,26 +54,32 @@ public class Utilities {
throw new IllegalArgumentException("Database URL does not specify a valid host");
}
- RepoInfo repoInfo = new RepoInfo();
- repoInfo.host = host.toLowerCase();
diff --git a/packages/firestore/src/local/local_store.ts b/packages/firestore/src/local/local_store.ts
index cddfa5b01..af9cb9998 100644
--- a/packages/firestore/src/local/local_store.ts
+++ b/packages/firestore/src/local/local_store.ts
@@ -95,6 +95,14 @@ export interface QueryResult {
readonly remoteKeys: DocumentKeySet;
}
+class LocalStoreImpl {
+ // TODO: Move persistence here
diff --git a/dev/src/bulk-writer.ts b/dev/src/bulk-writer.ts
index 02bd661..e783a5f 100644
--- a/dev/src/bulk-writer.ts
+++ b/dev/src/bulk-writer.ts
@@ -16,13 +16,15 @@
import * as assert from 'assert';
import {FieldPath, Firestore} from '.';
-import {delayExecution} from './backoff';
+import {delayExecution, MAX_RETRY_ATTEMPTS} from './backoff';
diff --git a/packages/firestore/src/platform/platform.ts b/packages/firestore/src/platform/platform.ts
index 43a028189..091d8a410 100644
--- a/packages/firestore/src/platform/platform.ts
+++ b/packages/firestore/src/platform/platform.ts
@@ -62,7 +62,7 @@ export interface Platform {
toByteStreamReader(
source: BundleSource,
bytesPerRead: number
- ): ByteStreamReader;
+ ): ReadableStreamReader<Uint8Array>;
{
"interfaces": {
"google.firestore.v1.Firestore": {
"retry_codes": {
"non_idempotent": [],
"idempotent": [
"DEADLINE_EXCEEDED",
"UNAVAILABLE"
],
"deadline_exceeded_internal_unavailable": [
diff --git a/packages/firestore/src/api/database.ts b/packages/firestore/src/api/database.ts
index 158965fa9..4e62ec521 100644
--- a/packages/firestore/src/api/database.ts
+++ b/packages/firestore/src/api/database.ts
@@ -2393,12 +2393,8 @@ function validateSetOptions(
function validateSnapshotOptions(
methodName: string,
- options: firestore.SnapshotOptions | undefined
-): firestore.SnapshotOptions {
await db.doc('foo/bar').set({});
const start = Date.now();
const promises = Array.from({length: 500}).map((_, index) => {
db.doc("a/" + index).set({});
});
const middle = Date.now();
await Promise.all(promises);
const end = Date.now();
console.log("Midpoint " + (middle - start));
console.log("End " + (end - start));
diff --git a/dev/test/bulk-writer.ts b/dev/test/bulk-writer.ts
index 182eaa5..c096082 100644
--- a/dev/test/bulk-writer.ts
+++ b/dev/test/bulk-writer.ts
@@ -131,17 +131,13 @@ describe('BulkWriter', () => {
* /**
* Creates an instance with the mocked objects.
*
- * @param options.enforceSingleConcurrentRequest Whether to check that there
+ * @param enforceSingleConcurrentRequest Whether to check that there
diff --git a/dev/test/bulk-writer.ts b/dev/test/bulk-writer.ts
index 7dcb919..362fb5f 100644
--- a/dev/test/bulk-writer.ts
+++ b/dev/test/bulk-writer.ts
@@ -39,18 +39,9 @@ setLogFunction(() => {});
const PROJECT_ID = 'test-project';
-interface BulkWriterRequest {
- writes: api.IWrite[] | null;