ncochard

When you create a npm package, remember it might be used in a browser or a server, or even a command line utility… For each package you create, please pay attention at what it will be used for:

1. Is it going to be used as a dependency to a nodejs application that is not bundled? (e.g. command line utilities)
2. Is it going to be used as a dependency to a nodejs application that is bundled? (e.g. AWS Lambdas)
3. Is it going to be used as a dependency to a browser application (always bundled)?.

• In cases 2) and 3) you want to allow for tree shaking.
• In cases 1) and 2) you want to benefit from the "ES6"/"ES next" features supported natively by nodejs.
• In case 3) you also want to benefit from the native support of "ES6" from your browser.

tessguefen

<mvt:if expr="g.request_cookies:critical_css NE 1 AND g.Screen CIN '|SFNT|CTGY|PLST|PROD|'">
	<script>!function(a){"use strict";var b=function(b,c,d){function j(a){return e.body?a():void setTimeout(function(){j(a)})}function l(){f.addEventListener&&f.removeEventListener("load",l),f.media=d||"all"}var g,e=a.document,f=e.createElement("link");if(c)g=c;else{var h=(e.body||e.getElementsByTagName("head")[0]).childNodes;g=h[h.length-1]}var i=e.styleSheets;f.rel="stylesheet",f.href=b,f.media="only x",j(function(){g.parentNode.insertBefore(f,c?g:g.nextSibling)});var k=function(a){for(var b=f.href,c=i.length;c--;)if(i[c].href===b)return a();setTimeout(function(){k(a)})};return f.addEventListener&&f.addEventListener("load",l),f.onloadcssdefined=k,k(l),f};"undefined"!=typeof exports?exports.loadCSS=b:a.loadCSS=b}("undefined"!=typeof global?global:this);
	</script>
	<noscript><link href="&mvt:global:theme_path;/css/all.min.css" rel="stylesheet" type="text/css" defer="defer"></noscript>
	<mvt:if expr="g.Screen EQ 'SFNT'">

tessguefen

<mvt:assign name="l.comma" value="asciichar('44')" />
<mvt:assign name="l.linebreak" value="asciichar('10')" />

<mvt:foreach iterator="order" array="admin_order:orders">
	<mvt:foreach iterator="group" array="order:groups">
		<mvt:comment> <!-- Build Dynamic Array --> </mvt:comment>
			<mvt:if expr="miva_array_search( l.settings:products, 0, l.item, 'l.item:code EQ l.settings:group:code' )">
				<mvt:assign name="l.item:quantity" value="l.item:quantity + l.settings:group:quantity" />
				<mvt:assign name="l.item:subtotal" value="l.item:subtotal + l.settings:group:subtotal" />
			<mvt:else>

bheyde

<mvt:foreach iterator="order" array="admin_order:orders">
			
			<mvt:foreach iterator="coupon" array="order:coupons">
				
				<mvt:comment>
					:code
					:coupon_id
					:order_id
					:total (discount applied to order)

tessguefen

<mvt:foreach iterator="group" array="basket:groups">
	<mvt:comment> <!-- Build Dynamic Array --> </mvt:comment>
		<mvt:if expr="miva_array_search( l.settings:new_array, 0, l.item, 'l.item:code EQ l.settings:group:code' )">
			<mvt:assign name="l.item:quantity" value="l.item:quantity + l.settings:group:quantity" />
		<mvt:else>
			<mvt:assign name="l.success" value="miva_array_insert( l.settings:new_array, l.settings:group, -1 )" />
		</mvt:if>
	 <mvt:comment> <!-- Build Dynamic Array --> </mvt:comment>
</mvt:foreach>

bheyde

<mvt:comment>
Load all possible variants using toolkit
</mvt:comment>

<mvt:item name="toolkit" param="variantarray|vcount|g.product_code" />

<mvt:comment>
Loop though variants, load product information for each variant, insert into new array
</mvt:comment>

wojteklu

Code is clean if it can be understood easily – by everyone on the team. Clean code can be read and enhanced by a developer other than its original author. With understandability comes readability, changeability, extensibility and maintainability.

---

General rules

1. Follow standard conventions.
2. Keep it simple stupid. Simpler is always better. Reduce complexity as much as possible.
3. Boy scout rule. Leave the campground cleaner than you found it.
4. Always find root cause. Always look for the root cause of a problem.

Design rules

bheyde

<MvFUNCTION NAME = "Module_Description" PARAMETERS = "module var" STANDARDOUTPUTLEVEL = "">
	<MvASSIGN NAME = "l.module:code"		VALUE = "call_url_stsk">
	<MvASSIGN NAME = "l.module:name"		VALUE = "HTTP Request to URL">
	<MvASSIGN NAME = "l.module:provider"	VALUE = "Miva Merchant">
	<MvASSIGN NAME = "l.module:version"		VALUE = "9.0003">
	<MvASSIGN NAME = "l.module:api_ver"		VALUE = "9.05">
	<MvASSIGN NAME = "l.module:description" VALUE = "This Scheduled Task allows you to setup a URL which will get called via an http request when the task is run.">
	<MvASSIGN NAME = "l.module:features"	VALUE = "util, vis_util, scheduledtask">
</MvFUNCTION>

bheyde

<mvt:assign name="g.api_endpoint" value="'https://DJDHGSDJD-dsn.algolia.net'" />
<mvt:assign name="g.index_name" value="'docs.miva'" />

<mvt:assign name="g.path" value="'/1/indexes/' $ g.index_name $ '/390342730'" />
<mvt:assign name="g.api_request" value="g.api_endpoint $ g.path" />

<mvt:assign name="g.headers" value="'X-Algolia-API-Key: 17181817181912' $ asciichar( 13 ) $ asciichar( 10 )" />
<mvt:assign name="g.headers" value=" g.headers $ 'X-Algolia-Application-Id: HSGDJDJDGD' $ asciichar( 13 ) $ asciichar( 10 )" />

<mvt:call action="g.api_request" method="'PUT'" headers="'g.headers'">

tessguefen

if ( false === ( $mivaHeader = get_transient( 'miva_header' ) ) ) {
	$mivaHeader = file_get_contents("http://" . $hostname . "/mm5/merchant.mvc?Screen=WP-HEADER");
	set_transient( 'miva_header', $mivaHeader, 24 * HOUR_IN_SECONDS );
}
echo $mivaHeader;